MantisBT - Open CASCADE
View Issue Details
0031394Open CASCADE[OCCT] OCCT:Visualizationpublic2020-02-25 13:582020-02-29 19:05
kgv 
bugmaster 
normalminor 
verifiedfixed 
 
[OCCT] 7.5.0* 
Not required
0031394: Visualization, TKOpenGl - define OpenGl_Element::EstimatedDataSize() interface
Current implementation of OpenGl_FrameStats treats OpenGl_PrimitiveArray specifically to calculate Graphic3d_FrameStatsCounter_EstimatedBytesGeom counter.

It is desired making a common interface OpenGl_Element::EstimatedDataSize() to allow custom elements providing this information in reliable way.
N/A
No tags attached.
child of 0029346closed bugmaster Visualization, TKOpenGl - collect frame statistics 
Issue History
2020-02-25 13:58kgvNew Issue
2020-02-25 13:58kgvAssigned To => kgv
2020-02-25 14:00gitNote Added: 0090669
2020-02-25 14:31gitNote Added: 0090672
2020-02-25 15:01kgvRelationship addedchild of 0029346
2020-02-25 16:48kgvNote Added: 0090677
2020-02-25 16:48kgvAssigned Tokgv => osa
2020-02-25 16:48kgvStatusnew => resolved
2020-02-26 10:46osaNote Added: 0090682
2020-02-26 10:46osaAssigned Toosa => bugmaster
2020-02-26 10:46osaStatusresolved => reviewed
2020-02-29 12:50bugmasterNote Added: 0090733
2020-02-29 12:50bugmasterStatusreviewed => tested
2020-02-29 12:50bugmasterTest case number => Not required
2020-02-29 13:19bugmasterChangeset attached => occt master 3d60d73f
2020-02-29 13:19bugmasterStatustested => verified
2020-02-29 13:19bugmasterResolutionopen => fixed
2020-02-29 13:39gitNote Added: 0090742

Notes
(0090669)
git   
2020-02-25 14:00   
Branch CR31394 has been created by kgv.

SHA-1: b75b7b61a03f13aca6570feeaf57cb0904427bf4


Detailed log of new commits:

Author: kgv
Date: Tue Feb 25 14:00:31 2020 +0300

    0031394: Visualization, TKOpenGl - define OpenGl_Element::EstimatedDataSize() interface
    
    OpenGl_FrameStats::updateStructures() now relies on OpenGl_Element inteface
    instead of handling OpenGl_PrimitiveArray specifically
    for collecting Graphic3d_FrameStatsCounter_EstimatedBytesGeom counter.
    OpenGl_PrimitiveArray and OpenGl_Text implement new interface.

Author: kgv
Date: Sat Feb 1 00:50:04 2020 +0300

    0031341: Visualization - Graphic3d_Layer::UpdateCulling() ignores Presentation range
    
    Graphic3d_Layer::UpdateCulling() now takes into account BVH_Tree::EndPrimitive().
    'vstatprofiler structs' now properly prints number of structures in case of no culling.
(0090672)
git   
2020-02-25 14:31   
Branch CR31394 has been updated forcibly by kgv.

SHA-1: 02516f42622f0b73e5de3ae0d3ea0a502c2be4b3
(0090677)
kgv   
2020-02-25 16:48   
Patch is ready for review.

http://jenkins-test-12.nnov.opencascade.com:8080/view/CR31394-CR31394-KGV/ [^]
(0090682)
osa   
2020-02-26 10:46   
The patch was reviewed without remarks
(0090733)
bugmaster   
2020-02-29 12:50   
Combination -
OCCT branch : IR-2020-02-28
master SHA - ae87bb87d01660bc27090beabc1e7ea92ba1bb85
fe4497f3246e6bc1ced97ac331c148f0809ded15
Products branch : IR-2020-02-28 SHA - a8fed678f48fe34786623f45d3ed7ec70c4845cc
was compiled on Linux, MacOS and Windows platforms and tested in optimize mode.

Number of compiler warnings:
No new/fixed warnings

Regressions/Differences/Improvements:
No regressions/differences

CPU differences:
Debian80-64:
OCCT
Total CPU difference: 17017.45000000009 / 17018.03000000002 [-0.00%]
Products
Total CPU difference: 12539.800000000105 / 12533.37000000014 [+0.05%]
Windows-64-VC14:
OCCT
Total CPU difference: 18449.890625 / 18398.15625 [+0.28%]
Products
Total CPU difference: 14533.015625 / 14483.234375 [+0.34%]


Image differences :
No differences that require special attention

Memory differences :
No differences that require special attention
(0090742)
git   
2020-02-29 13:39   
Branch CR31394 has been deleted by inv.

SHA-1: 02516f42622f0b73e5de3ae0d3ea0a502c2be4b3