MantisBT - Open CASCADE
View Issue Details
0031320Open CASCADE[OCCT] OCCT:Application Frameworkpublic2020-01-25 20:382020-09-05 12:35
abv 
bugmaster 
normalminor 
verifiedfixed 
 
[OCCT] 7.5.0 
bugs caf bug31320
0031320: TObj - method TObj_Object::GetFatherObject() is not protected against deleted object
Method TObj_Object::GetFatherObject() will cause access violation if called for an object that has been removed from the document (i.e. whose method IsAlive() returns false).
bugs caf bug31320
No tags attached.
Issue History
2020-01-25 20:38abvNew Issue
2020-01-25 20:38abvAssigned To => mpv
2020-08-31 18:22gitNote Added: 0093774
2020-08-31 21:24mpvNote Added: 0093782
2020-08-31 21:24mpvAssigned Tompv => szy
2020-08-31 21:24mpvStatusnew => resolved
2020-08-31 21:24mpvSteps to Reproduce Updatedbug_revision_view_page.php?rev_id=23280#r23280
2020-09-01 11:18kgvNote Added: 0093797
2020-09-01 11:19kgvNote Edited: 0093797bug_revision_view_page.php?bugnote_id=93797#r23282
2020-09-01 11:37gitNote Added: 0093799
2020-09-01 11:38mpvNote Added: 0093800
2020-09-01 12:22gitNote Added: 0093806
2020-09-02 11:54szyNote Added: 0093847
2020-09-02 11:54szyAssigned Toszy => bugmaster
2020-09-02 11:54szyStatusresolved => reviewed
2020-09-05 12:07bugmasterNote Added: 0094054
2020-09-05 12:07bugmasterStatusreviewed => tested
2020-09-05 12:18bugmasterTest case number => bugs caf bug31320
2020-09-05 12:25bugmasterChangeset attached => occt master 17a5b567
2020-09-05 12:25bugmasterStatustested => verified
2020-09-05 12:25bugmasterResolutionopen => fixed
2020-09-05 12:35gitNote Added: 0094089

Notes
(0093774)
git   
2020-08-31 18:22   
Branch CR31320 has been created by mpv.

SHA-1: 616b2f125b737b650ea674a29598701b4b9c782d


Detailed log of new commits:

Author: mpv
Date: Mon Aug 31 18:24:59 2020 +0300

    31320: TObj - method TObj_Object::GetFatherObject() is not protected against deleted object
(0093782)
mpv   
2020-08-31 21:24   
Fixed. Please review.

http://occt-tests/CR31320-master-MPV-OCCT/Windows-64-VC14/diff_summary.html [^]
http://occt-tests/CR31320-master-MPV-Products/Windows-64-VC14/diff_summary.html [^]
http://occt-tests/CR31320-master-MPV-OCCT/Debian80-64/diff_summary.html [^]
http://occt-tests/CR31320-master-MPV-Products/Debian80-64/diff_summary.html [^]
(0093797)
kgv   
2020-09-01 11:18   
(edited on: 2020-09-01 11:19)
+puts "OCC31320"

Could you please add a full bug description to the test? E.g.
+puts "0031320: TObj - method TObj_Object::GetFatherObject() is not protected against deleted object"

   Handle(TObj_Object) aFather, aSon(this);
 
+  if (myLabel.IsNull())
+    return aFather;

tip: maybe it would be better moving this check before creating an unused aSon(this) handle...

(0093799)
git   
2020-09-01 11:37   
Branch CR31320 has been updated by mpv.

SHA-1: d20d3a0dd11b3ab79ca026d043d32d45a6b70d31


Detailed log of new commits:

Author: mpv
Date: Tue Sep 1 11:40:14 2020 +0300

    # minor changes due to KGV notes

(0093800)
mpv   
2020-09-01 11:38   
Done in the same branch CR31320. No re-testing is needed.
(0093806)
git   
2020-09-01 12:22   
Branch CR31320 has been updated forcibly by mpv.

SHA-1: 76d74fb9db9248c8d0a586f35cb389c37dc476d7
(0093847)
szy   
2020-09-02 11:54   
Reviewed.
(0094054)
bugmaster   
2020-09-05 12:07   
Combination -
OCCT branch : IR-2020-09-04
master SHA - a516227511f3452f9f55b79c961265b0bf210793
a206de37fbfa0bf71bd534ae47192bbec23b8522
Products branch : IR-2020-09-04 SHA - 134448d280fb82bfb14ffc6255ac1cb53f7fd1cf
was compiled on Linux, MacOS and Windows platforms and tested in optimize mode.

Number of compiler warnings:
No new/fixed warnings

Regressions/Differences/Improvements:
No regressions/differences

CPU differences:
Debian80-64:
OCCT
Total CPU difference: 17319.18000000012 / 17284.370000000214 [+0.20%]
Products
Total CPU difference: 12059.670000000087 / 12007.590000000067 [+0.43%]
Windows-64-VC14:
OCCT
Total CPU difference: 18776.390625 / 18770.796875 [+0.03%]
Products
Total CPU difference: 13251.640625 / 13222.90625 [+0.22%]


Image differences :
No differences that require special attention

Memory differences :
No differences that require special attention
(0094089)
git   
2020-09-05 12:35   
Branch CR31320 has been deleted by inv.

SHA-1: 76d74fb9db9248c8d0a586f35cb389c37dc476d7