MantisBT - Open CASCADE
View Issue Details
0031302Open CASCADE[OCCT] OCCT:Visualizationpublic2020-01-16 12:082020-01-23 12:28
iko 
bugmaster 
normalminor 
verifiedfixed 
[OCCT] 7.5.0 
[OCCT] 7.5.0 
v3d/glsl/pbr_tangent_normal
0031302: Visualization, TKOpenGl - wrong tangent space calculation for normal maps
Tangent space for normals must be independent of triangle orientation and must handle cases of back faces (inverted normals).
v3d/glsl/pbr_tangent_normals
No tags attached.
child of 0031096verified bugmaster Visualization, TKOpenGl - support metallic-roughness texture mapping 
child of 0031098verified bugmaster Visualization, TKOpenGl - support Normal texture map 
png normmap_tangent_KO.png (386,645) 2020-01-23 12:28
https://tracker.dev.opencascade.org/
png normmap_tangent_OK.png (377,881) 2020-01-23 12:28
https://tracker.dev.opencascade.org/
Issue History
2020-01-16 12:08ikoNew Issue
2020-01-16 12:08ikoAssigned To => iko
2020-01-16 12:12kgvProduct Version => 7.5.0
2020-01-16 12:13kgvRelationship addedchild of 0031096
2020-01-16 12:13kgvRelationship addedchild of 0031098
2020-01-16 16:12gitNote Added: 0089915
2020-01-16 17:39ikoNote Added: 0089918
2020-01-16 17:39ikoAssigned Toiko => kgv
2020-01-16 17:39ikoStatusnew => resolved
2020-01-16 17:39ikoSteps to Reproduce Updatedbug_revision_view_page.php?rev_id=22459#r22459
2020-01-16 17:41kgvAssigned Tokgv => bugmaster
2020-01-16 17:41kgvStatusresolved => reviewed
2020-01-17 15:51bugmasterNote Added: 0089933
2020-01-17 15:51bugmasterTest case number => v3d/glsl/pbr_tangent_normal
2020-01-17 15:51bugmasterStatusreviewed => tested
2020-01-18 12:27bugmasterChangeset attached => occt master 65584001
2020-01-18 12:27bugmasterStatustested => verified
2020-01-18 12:27bugmasterResolutionopen => fixed
2020-01-18 15:36gitNote Added: 0089941
2020-01-23 12:28kgvFile Added: normmap_tangent_KO.png
2020-01-23 12:28kgvFile Added: normmap_tangent_OK.png

Notes
(0089915)
git   
2020-01-16 16:12   
Branch CR31302 has been created by iko.

SHA-1: 5c2b846fa8f8c669f738409757cf2bee0b4a256d


Detailed log of new commits:

Author: iko
Date: Thu Jan 16 15:55:29 2020 +0300

    0031302: Visualization, TKOpenGl - wrong tangent space calculation for normal maps
    
    The normal after tangent space calculation has been reverted in order to be in right orientation.
    The tangent space calculation has been modified in order to handle back faces with inverted normal.
(0089918)
iko   
2020-01-16 17:39   
Please review the changes.

http://vm-jenkins-test-12.nnov.opencascade.com:8080/job/CR31302-master-IKO-OCCT-Windows-64-VC14-opt-test-compare/1/ [^]

http://vm-jenkins-test-12.nnov.opencascade.com:8080/job/CR31302-master-IKO-OCCT-Debian80-64-opt-test-compare/1/ [^]
(0089933)
bugmaster   
2020-01-17 15:51   
Combination -
OCCT branch : WEEK-2
master SHA - 6558400123b810d47bd346c56eb5b304fa48343e
fe4497f3246e6bc1ced97ac331c148f0809ded15
Products branch : WEEK-2 SHA - 61714ae872d45b51afb92a8857b495e2b7ecd308
was compiled on Linux, MacOS and Windows platforms and tested in optimize mode.

Number of compiler warnings:
No new/fixed warnings

Regressions/Differences/Improvements:
No regressions/differences

CPU differences:
Debian80-64:
OCCT
Total CPU difference: 17001.940000000115 / 16989.810000000103 [+0.07%]
Products
Total CPU difference: 10717.560000000085 / 10741.020000000053 [-0.22%]
Windows-64-VC14:
OCCT
Total CPU difference: 18446.140625 / 18447.0625 [-0.00%]
Products
Total CPU difference: 12698.09375 / 12436.203125 [+2.11%]


Image differences :
No differences that require special attention

Memory differences :
No differences that require special attention
(0089941)
git   
2020-01-18 15:36   
Branch CR31302 has been deleted by inv.

SHA-1: 5c2b846fa8f8c669f738409757cf2bee0b4a256d