MantisBT - Open CASCADE
View Issue Details
0031275Open CASCADE[OCCT] OCCT:Visualizationpublic2019-12-25 23:062020-02-05 10:53
kgv 
bugmaster 
normalfeature 
verifiedfixed 
 
[OCCT] 7.5.0* 
v3d/raytrace/normal_map
0031275: Visualization, TKOpenGl - handle normal-map texture with Path-Tracing
Path tracing currently ignores normal-map texture, which causes unexpected rendering results.
No tags attached.
related to 0031300new iko Visualization, TKOpenGl - Ray Tracing ignores FLAT shading mode 
child of 0031096verified bugmaster Visualization, TKOpenGl - support metallic-roughness texture mapping 
png helmet_pt_KO.png (128,578) 2020-01-23 13:00
https://tracker.dev.opencascade.org/
png helmet_pt_OK.png (130,134) 2020-01-23 13:00
https://tracker.dev.opencascade.org/
Issue History
2019-12-25 23:06kgvNew Issue
2019-12-25 23:06kgvAssigned To => iko
2019-12-25 23:07kgvRelationship addedchild of 0031096
2019-12-25 23:08kgvStatusnew => assigned
2020-01-14 19:55kgvRelationship addedrelated to 0031300
2020-01-21 17:46gitNote Added: 0089987
2020-01-22 17:17gitNote Added: 0089990
2020-01-23 11:06gitNote Added: 0090001
2020-01-23 12:25kgvNote Added: 0090009
2020-01-23 13:00kgvFile Added: helmet_pt_KO.png
2020-01-23 13:00kgvFile Added: helmet_pt_OK.png
2020-01-23 15:02kgvNote Added: 0090019
2020-01-24 11:29gitNote Added: 0090041
2020-01-24 13:40gitNote Added: 0090043
2020-01-24 13:40kgvNote Added: 0090044
2020-01-24 13:40kgvAssigned Toiko => bugmaster
2020-01-24 13:40kgvSeverityminor => feature
2020-01-24 13:40kgvStatusassigned => resolved
2020-01-24 13:40kgvStatusresolved => reviewed
2020-01-24 17:16bugmasterNote Added: 0090056
2020-01-24 17:17bugmasterTest case number => v3d/raytrace/normal_map
2020-01-24 17:19bugmasterStatusreviewed => tested
2020-01-25 13:09bugmasterChangeset attached => occt master 78607702
2020-01-25 13:09bugmasterStatustested => verified
2020-01-25 13:09bugmasterResolutionopen => fixed
2020-01-25 13:26gitNote Added: 0090059

Notes
(0089987)
git   
2020-01-21 17:46   
Branch CR31275 has been created by iko.

SHA-1: 1a84d777bfdc9ea39b0d1575a6775ecf5bed3201


Detailed log of new commits:

Author: iko
Date: Tue Jan 21 16:01:03 2020 +0300

    # work in progress
(0089990)
git   
2020-01-22 17:17   
Branch CR31275 has been updated forcibly by iko.

SHA-1: 491496e360db7c1e5fbc3aefd610b7482a895b1e
(0090001)
git   
2020-01-23 11:06   
Branch CR31275 has been updated forcibly by iko.

SHA-1: ecfb2abb81d9335af8c39526f17d6d17156f9520
(0090009)
kgv   
2020-01-23 12:25   
+  Standard_Boolean                  IgnoreNormalMap;

ToIgnoreNormalMapInRayTracing;

     + EOL"vec3  Normal;"
+    + Shaders_TangentSpaceNormal_glsl
     + aLights

Please include only when function is actually used.
(0090019)
kgv   
2020-01-23 15:02   
@@ -33,6 +33,6 @@ static const char Shaders_PointLightAttenuation_glsl[] =
   "  if (theRange == 0.0)\n"
   "  {\n"
   "    return 1.0 / (theConstAttenuation + theLinearAttenuation * theDistance);\n"
   "  }\n"
   "  return occRangedPointLightAttenuation (theDistance, theRange);\n"
-  "}\n";
+  "}";

Please add missing newline.
(0090041)
git   
2020-01-24 11:29   
Branch CR31275 has been updated forcibly by iko.

SHA-1: d1f4cbe5c4bc93b598b0f86fd421e6fe1208681e
(0090043)
git   
2020-01-24 13:40   
Branch CR31275 has been updated forcibly by kgv.

SHA-1: 4e4030f71bc96b220a3d7e934bb3b138ebe67513
(0090044)
kgv   
2020-01-24 13:40   
Please raise the patch.
(0090056)
bugmaster   
2020-01-24 17:16   
Combination -
OCCT branch : WEEK-4
master SHA - 6216ed573eba2e021c05ae79b13de3404ae2633d
fe4497f3246e6bc1ced97ac331c148f0809ded15
Products branch : WEEK-4 SHA - 78d1418219e11e1effe871d7f2886b736d7b8bdf
was compiled on Linux, MacOS and Windows platforms and tested in optimize mode.

Number of compiler warnings:
No new/fixed warnings

Regressions/Differences/Improvements:
No regressions/differences

CPU differences:
Debian80-64:
OCCT
Total CPU difference: 16995.39000000029 / 17005.860000000113 [-0.06%]
Products
Total CPU difference: 12132.210000000103 / 10725.040000000088 [+13.12%]
Windows-64-VC14:
OCCT
Total CPU difference: 18437.984375 / 18453.859375 [-0.09%]
Products
Total CPU difference: 14113.03125 / 12655.59375 [+11.52%]


Image differences :
No differences that require special attention

Memory differences :
No differences that require special attention
(0090059)
git   
2020-01-25 13:26   
Branch CR31275 has been deleted by inv.

SHA-1: 4e4030f71bc96b220a3d7e934bb3b138ebe67513