MantisBT - Open CASCADE
View Issue Details
0031213Open CASCADE[OCCT] OCCT:Codingpublic2019-12-03 12:192020-12-02 17:12
kgv 
bugmaster 
normaltrivial 
closedfixed 
[OCCT] 7.5.0 
[OCCT] 7.5.0[OCCT] 7.5.0 
Not required
0031213: Coding Rules, RWStl_Reader - THE_BUFFER should NOT be a global object
Variable THE_BUFFER introduced by 0030964 has wrong name as it is not constant / global:
--- a/src/RWStl/RWStl_Reader.cxx
+++ b/src/RWStl/RWStl_Reader.cxx
+  // Buffer to read
+  Standard_ReadLineBuffer THE_BUFFER (THE_BUFFER_SIZE);
Not required
No tags attached.
child of 0030964closed bugmaster Data Exchange - use Standard_ReadLineBuffer within OBJ reader 
Issue History
2019-12-03 12:19kgvNew Issue
2019-12-03 12:19kgvAssigned To => mzernova
2019-12-03 12:19kgvRelationship addedchild of 0030964
2019-12-03 12:19kgvStatusnew => assigned
2019-12-03 13:56gitNote Added: 0089358
2019-12-03 13:57mzernovaNote Added: 0089359
2019-12-03 13:57mzernovaAssigned Tomzernova => kgv
2019-12-03 13:57mzernovaStatusassigned => resolved
2019-12-03 13:57mzernovaSteps to Reproduce Updatedbug_revision_view_page.php?rev_id=22290#r22290
2019-12-03 14:46kgvNote Added: 0089360
2019-12-03 14:46kgvAssigned Tokgv => mzernova
2019-12-03 14:46kgvStatusresolved => assigned
2019-12-03 15:19kgvSummaryCoding Rules, RWStl_Reader - misnamed variable THE_BUFFER => Coding Rules, RWStl_Reader - THE_BUFFER should NOT be a global variable
2019-12-03 15:19kgvSummaryCoding Rules, RWStl_Reader - THE_BUFFER should NOT be a global variable => Coding Rules, RWStl_Reader - THE_BUFFER should NOT be a global object
2019-12-04 15:55gitNote Added: 0089378
2019-12-04 15:56gitNote Added: 0089379
2019-12-04 15:57mzernovaNote Added: 0089380
2019-12-04 15:57mzernovaAssigned Tomzernova => kgv
2019-12-04 15:57mzernovaStatusassigned => resolved
2019-12-04 16:55kgvAssigned Tokgv => bugmaster
2019-12-04 16:55kgvStatusresolved => reviewed
2019-12-06 19:15bugmasterTest case number => Not required
2019-12-08 11:51bugmasterNote Added: 0089430
2019-12-08 11:51bugmasterStatusreviewed => tested
2019-12-08 11:52bugmasterChangeset attached => occt master c37bd936
2019-12-08 11:52bugmasterStatustested => verified
2019-12-08 11:52bugmasterResolutionopen => fixed
2019-12-08 12:14gitNote Added: 0089439
2019-12-08 12:14gitNote Added: 0089440
2020-12-02 16:41emoFixed in Version => 7.5.0
2020-12-02 17:12emoStatusverified => closed

Notes
(0089358)
git   
2019-12-03 13:56   
Branch CR31213 has been created by mzernova.

SHA-1: 90c466dd242a4117240ed35ee00a6de3cbc89343


Detailed log of new commits:

Author: mzernova
Date: Tue Dec 3 13:51:02 2019 +0300

    0031213: Coding Rules, RWStl_Reader - misnamed variable THE_BUFFER
    
    Renamed THE_BUFFER variable.
(0089359)
mzernova   
2019-12-03 13:57   
The patch CR31213 is ready to review
(0089360)
kgv   
2019-12-03 14:46   
  36 namespace
  37 {
  46   // Buffer to read
  47   Standard_ReadLineBuffer RWStl_myBuffer (THE_BUFFER_SIZE);

This buffer should not be put into a global variable!
(0089378)
git   
2019-12-04 15:55   
Branch CR31213 has been updated by mzernova.

SHA-1: b58002c6ddb1d256924c698870a629dedf08b866


Detailed log of new commits:

Author: mzernova
Date: Wed Dec 4 15:48:19 2019 +0300

    remarks from kgv

(0089379)
git   
2019-12-04 15:56   
Branch CR31213_1 has been created by mzernova.

SHA-1: 10e12d458a1b441e77cea3e4836201ed19a055a1


Detailed log of new commits:

Author: mzernova
Date: Tue Dec 3 13:51:02 2019 +0300

    0031213: Coding Rules, RWStl_Reader - THE_BUFFER should NOT be a global object
    
    Variable THE_BUFFER has been renamed and moved.
(0089380)
mzernova   
2019-12-04 15:57   
The patch CR31213 is ready to review
(0089430)
bugmaster   
2019-12-08 11:51   
Combination -
OCCT branch : IR-2019-12-06
master SHA - 5a8d30b87b5ab8f44e9011dc432d0dc8eb67a77b
5f5b1aed1c6e139bbd34314eca77ae7abcd8895c
Products branch : IR-2019-12-06 SHA - 959ae07414622f22b3cf77b1922c1519d7e532d6
was compiled on Linux, MacOS and Windows platforms and tested in optimize mode.

Number of compiler warnings:
No new/fixed warnings

Regressions/Differences/Improvements:
No regressions/differences

CPU differences:
Debian80-64:
OCCT
Total CPU difference: 16960.660000000054 / 16953.66000000014 [+0.04%]
Products
Total CPU difference: 10744.040000000065 / 10823.520000000082 [-0.73%]
Windows-64-VC14:
OCCT
Total CPU difference: 18400.203125 / 18461.625 [-0.33%]
Products
Total CPU difference: 12762.109375 / 12785.21875 [-0.18%]


Image differences :
No differences that require special attention

Memory differences :
No differences that require special attention
(0089439)
git   
2019-12-08 12:14   
Branch CR31213_1 has been deleted by inv.

SHA-1: 10e12d458a1b441e77cea3e4836201ed19a055a1
(0089440)
git   
2019-12-08 12:14   
Branch CR31213 has been deleted by inv.

SHA-1: b58002c6ddb1d256924c698870a629dedf08b866