MantisBT - Open CASCADE
View Issue Details
0031193Open CASCADE[OCCT] OCCT:Visualizationpublic2019-11-25 11:392020-05-10 14:17
nds 
mzernova 
normalminor 
verifiedfixed 
[OCCT] 7.3.0 
[OCCT] 7.5.0* 
bugs/vis/bug31193
0031193: Visualization - OpenGl_Flipping wrong text position if local transformation set
Rotating scene shows the text in not correct position if the presentation has local transformation and the flipping mode is switch ON.
bugs/vis/bug31193
No tags attached.
related to 0030922verified mzernova Visualization - OpenGl_Text wrong local transformation if text has not own attach point 
png bug31193_wrong.png (7,286) 2020-04-29 14:56
https://tracker.dev.opencascade.org/
png bug31193_correct.png (7,236) 2020-04-29 15:00
https://tracker.dev.opencascade.org/
Issue History
2019-11-25 11:39ndsNew Issue
2019-11-25 11:39ndsAssigned To => nds
2019-11-25 11:39ndsRelationship addedrelated to 0030922
2020-04-29 00:56gitNote Added: 0091833
2020-04-29 00:56gitNote Added: 0091834
2020-04-29 12:28mzernovaNote Added: 0091851
2020-04-29 12:31mzernovaNote Added: 0091852
2020-04-29 12:31mzernovaAssigned Tonds => kgv
2020-04-29 12:31mzernovaStatusnew => resolved
2020-04-29 12:31mzernovaSteps to Reproduce Updatedbug_revision_view_page.php?rev_id=22875#r22875
2020-04-29 13:36kgvNote Added: 0091861
2020-04-29 13:36kgvAssigned Tokgv => mzernova
2020-04-29 13:36kgvStatusresolved => assigned
2020-04-29 14:20gitNote Added: 0091862
2020-04-29 14:22gitNote Added: 0091863
2020-04-29 14:22mzernovaNote Added: 0091864
2020-04-29 14:22mzernovaAssigned Tomzernova => kgv
2020-04-29 14:22mzernovaStatusassigned => resolved
2020-04-29 14:22kgvNote Added: 0091865
2020-04-29 14:23kgvAssigned Tokgv => mzernova
2020-04-29 14:23kgvStatusresolved => assigned
2020-04-29 14:40gitNote Added: 0091866
2020-04-29 14:41gitNote Added: 0091867
2020-04-29 14:42mzernovaNote Added: 0091868
2020-04-29 14:42mzernovaAssigned Tomzernova => kgv
2020-04-29 14:42mzernovaStatusassigned => resolved
2020-04-29 14:44kgvNote Added: 0091869
2020-04-29 14:56mzernovaFile Added: bug31193_wrong.png
2020-04-29 15:00mzernovaFile Added: bug31193_correct.png
2020-04-29 15:09kgvNote Added: 0091870
2020-04-29 16:35gitNote Added: 0091873
2020-04-29 16:36gitNote Added: 0091874
2020-04-29 16:41kgvNote Added: 0091876
2020-04-29 16:41kgvAssigned Tokgv => bugmaster
2020-04-29 16:41kgvStatusresolved => reviewed
2020-04-29 16:41kgvProduct Version => 7.3.0
2020-05-07 10:50bugmasterNote Added: 0091978
2020-05-07 10:50bugmasterStatusreviewed => tested
2020-05-07 10:52bugmasterTest case number => bugs/vis/bug31193
2020-05-10 14:01mzernovaChangeset attached => occt master ab9e277f
2020-05-10 14:01mzernovaAssigned Tobugmaster => mzernova
2020-05-10 14:01mzernovaStatustested => verified
2020-05-10 14:01mzernovaResolutionopen => fixed
2020-05-10 14:16gitNote Added: 0092048
2020-05-10 14:17gitNote Added: 0092049

Notes
(0091833)
git   
2020-04-29 00:56   
Branch CR31193 has been created by mzernova.

SHA-1: 770c33a86e90ef311db9fb47fb828eafdcdb98ca


Detailed log of new commits:

Author: mzernova
Date: Tue Apr 28 00:43:16 2020 +0300

    fix matrix in OpenGL_Flipping
    
    bugs/vis/bug31193: test case added

Author: nds
Date: Tue Aug 27 08:26:23 2019 +0300

    0031193: Visualization - OpenGl_Flipping wrong text position if local transformation set
    
    (cherry picked from commit 05ac0c7d75356573c725745bc19fab512a4bdad6)
(0091834)
git   
2020-04-29 00:56   
Branch CR31193_1 has been created by mzernova.

SHA-1: 0f2bde20291de58e6971d8180ed3db92418054d5


Detailed log of new commits:

Author: nds
Date: Tue Aug 27 08:26:23 2019 +0300

    0031193: Visualization - OpenGl_Flipping wrong text position if local transformation set
    
    Fix local transformation in OpenGl_Text if flag HasOwnAnchorPoint() is equal to Standard_False.
    Fix matrix in OpenGL_Flipping
    
    bugs/vis/bug31193: test case added
(0091851)
mzernova   
2020-04-29 12:28   
http://jenkins-test-12.nnov.opencascade.com:8080/view/CR31193-master-mzernova/ [^]
(0091852)
mzernova   
2020-04-29 12:31   
The patch CR31193 is ready to review
(0091861)
kgv   
2020-04-29 13:36   
> Fix local transformation in OpenGl_Text if flag HasOwnAnchorPoint() is equal to Standard_False.
> Fix matrix in OpenGL_Flipping
Could you please correct git message to elaborate how exactly both issues have been corrected (what kind of logic error existed in old code)?
(0091862)
git   
2020-04-29 14:20   
Branch CR31193_1 has been updated forcibly by mzernova.

SHA-1: 29893a172fc98ce7f4690f9096c7f0816e477173
(0091863)
git   
2020-04-29 14:22   
Branch CR31193 has been updated by mzernova.

SHA-1: f89107ae1d082e546668c7f4ff771436899d7bc1


Detailed log of new commits:

Author: mzernova
Date: Wed Apr 29 14:22:28 2020 +0300

    Before the patch, if the values of the isReversedX/Y/Z variables were set to false, then the WorldView matrix did not change and local transformation was not applied, which caused errors.
    In order to correctly set the local transformation in case the text does not have its own attach point, the local transformation is set in OpenGl_Text, and the ModelWorld matrix is changed in OpenGl_Flipper, instead of the WorldView matrix. In this case, local transformation will always be applied.

(0091864)
mzernova   
2020-04-29 14:22   
The patch CR31193 is ready to review
(0091865)
kgv   
2020-04-29 14:22   
> bugs/vis/bug31193: test case added
Test case has been lost in patch.
(0091866)
git   
2020-04-29 14:40   
Branch CR31193 has been updated by mzernova.

SHA-1: 1ca82d34e296d2942e09ec749b73f01c62bfa235


Detailed log of new commits:

Author: mzernova
Date: Wed Apr 29 14:39:51 2020 +0300

    bugs/vis/bug31193: test case added

(0091867)
git   
2020-04-29 14:41   
Branch CR31193_1 has been updated forcibly by mzernova.

SHA-1: 9ab9c59907247df5bce62d2baf0704bb6fb55ce0
(0091868)
mzernova   
2020-04-29 14:42   
The patch CR31193 is ready to review
(0091869)
kgv   
2020-04-29 14:44   
Please also attach screenshots for test case before and after the fix, to make it clean how wrong and correct look alike.
(0091870)
kgv   
2020-04-29 15:09   
+set mouse_pick {208 301}
+set mouse_drag {198 102}
+vmoveto {*}$mouse_pick
+vmanipulator m -startTransform {*}$mouse_pick
+vmanipulator m -transform {*}$mouse_drag
+vmanipulator m -stopTransform

Why such complexity with vmanipulator is needed?
Cannot be it replaced by a single vlocation call?
(0091873)
git   
2020-04-29 16:35   
Branch CR31193 has been updated by mzernova.

SHA-1: 06069a6f20e14370db6ec19d6cf02f51b893af01


Detailed log of new commits:

Author: mzernova
Date: Wed Apr 29 16:30:11 2020 +0300

    remarks from kgv

(0091874)
git   
2020-04-29 16:36   
Branch CR31193_1 has been updated forcibly by mzernova.

SHA-1: ab9e277f15988c69343b64ac487163b41ec120f4
(0091876)
kgv   
2020-04-29 16:41   
Please raise the patch in OCCT branch CR31193.
(0091978)
bugmaster   
2020-05-07 10:50   
Combination -
OCCT branch : WEEK-18
master SHA - b40cdc2b5584fdf78f90594a3c7469213c7dc4a6
a206de37fbfa0bf71bd534ae47192bbec23b8522
Products branch : WEEK-18 SHA - f3160246a8ae8356b116065842ce354791652bb4
was compiled on Linux, MacOS and Windows platforms and tested in optimize mode.

Number of compiler warnings:
No new/fixed warnings

Regressions/Differences/Improvements:
No regressions/differences

CPU differences:
Debian80-64:
OCCT
Total CPU difference: 17165.480000000167 / 17147.810000000212 [+0.10%]
Products
Total CPU difference: 11271.100000000095 / 11280.480000000087 [-0.08%]
Windows-64-VC14:
OCCT
Total CPU difference: 18654.578125 / 18665.890625 [-0.06%]
Products
Total CPU difference: 13128.59375 / 13209.109375 [-0.61%]


Image differences :
No differences that require special attention

Memory differences :
No differences that require special attention
(0092048)
git   
2020-05-10 14:16   
Branch CR31193_1 has been deleted by inv.

SHA-1: ab9e277f15988c69343b64ac487163b41ec120f4
(0092049)
git   
2020-05-10 14:17   
Branch CR31193 has been deleted by inv.

SHA-1: 06069a6f20e14370db6ec19d6cf02f51b893af01