MantisBT - Open CASCADE
View Issue Details
0031139Open CASCADE[OCCT] OCCT:Data Exchangepublic2019-11-07 00:022019-11-10 11:41
kgv 
bugmaster 
normaltrivial 
verifiedfixed 
[OCCT] 7.5.0* 
[OCCT] 7.5.0* 
Not required
0031139: Data Exchange - fix misprint in RWObj_CafReader
Patch for 0029902 has a misprint in RWObj_CafReader leading to no material merging being actually performed.
N/A
No tags attached.
child of 0029902verified apn Data Exchange, XCAF - provide extended Material definition for visualization purposes 
Issue History
2019-11-07 00:02kgvNew Issue
2019-11-07 00:02kgvAssigned To => kgv
2019-11-07 00:02kgvRelationship addedchild of 0029902
2019-11-07 00:03kgvSummaryData Exchange - fix misprint in RWObj_Reader => Data Exchange - fix misprint in RWObj_CafReader
2019-11-07 00:03kgvDescription Updatedbug_revision_view_page.php?rev_id=22162#r22162
2019-11-07 00:14gitNote Added: 0088759
2019-11-07 08:06kgvNote Added: 0088762
2019-11-07 08:06kgvAssigned Tokgv => bugmaster
2019-11-07 08:06kgvSeverityminor => trivial
2019-11-07 08:06kgvStatusnew => resolved
2019-11-07 08:06kgvStatusresolved => reviewed
2019-11-07 10:51bugmasterTest case number => Not required
2019-11-08 14:29bugmasterNote Added: 0088799
2019-11-08 14:29bugmasterStatusreviewed => tested
2019-11-10 11:18bugmasterChangeset attached => occt master a14f2b47
2019-11-10 11:18bugmasterStatustested => verified
2019-11-10 11:18bugmasterResolutionopen => fixed
2019-11-10 11:41gitNote Added: 0088833

Notes
(0088759)
git   
2019-11-07 00:14   
Branch CR31139 has been created by kgv.

SHA-1: dfe047d0a4f4746bf01c91fe5533d22438b8c431


Detailed log of new commits:

Author: kgv
Date: Thu Nov 7 00:11:57 2019 +0300

    0031139: Data Exchange - fix misprint in RWObj_CafReader
    
    RWObj_CafReader::BindNamedShape(), added missing bind to material map.
    XCAFDoc_VisMaterial::ConvertToCommonMaterial()/::ConvertToPbrMaterial(), added copying of base color texture.
    XCAFPrs_DocumentExplorer now properly fills XCAFDoc_VisMaterial property of XCAFPrs_Style.
(0088762)
kgv   
2019-11-07 08:06   
Please raise the patch.

http://jenkins-test-12.nnov.opencascade.com:8080/view/CR31139-master-KGV [^]
(0088799)
bugmaster   
2019-11-08 14:29   
Combination -
OCCT branch : WEEK-45
master SHA - 08b438b07684090e1a9b77f5ac9d152d4bec10c6
5f5b1aed1c6e139bbd34314eca77ae7abcd8895c
Products branch : WEEK-45 SHA - f88bc93e3637c4c42f3c154c0b0e167d4e297ae6
was compiled on Linux, MacOS and Windows platforms and tested in optimize mode.

Number of compiler warnings:
No new/fixed warnings

Regressions/Differences/Improvements:
No regressions/differences

CPU differences:
Debian80-64:
OCCT
Total CPU difference: 16835.010000000126 / 16848.430000000117 [-0.08%]
Products
Total CPU difference: 10830.110000000055 / 10873.690000000062 [-0.40%]
Windows-64-VC14:
OCCT
Total CPU difference: 18295.625 / 18319.515625 [-0.13%]
Products
Total CPU difference: 12840.953125 / 12848.859375 [-0.06%]


Image differences :
No differences that require special attention

Memory differences :
No differences that require special attention
(0088833)
git   
2019-11-10 11:41   
Branch CR31139 has been deleted by inv.

SHA-1: dfe047d0a4f4746bf01c91fe5533d22438b8c431