MantisBT - Open CASCADE
View Issue Details
0031043Open CASCADE[OCCT] OCCT:Modeling Algorithmspublic2019-10-07 18:582019-11-10 11:41
oan 
oan 
normalminor 
verifiedfixed 
 
[OCCT] 7.5.0* 
bugs modalg_7 bug31043
0031043: GCPnts_TangentialDeflection generates points which number is inconsistent with MinimumOfPoints parameter
Number of points generated by GCPnts_TangentialDeflection is less than specified value.

This patch is required by 0028500 in order to add additional points (e.g. one more comparing to previous result) for faces consisting of two straight edges with vertices covered by tolerance.
#Use edges of face 3 and 7 to reproduce problem.

test bugs mesh bug28500
explode a f
explode a_7 e
mkcurve c a_7_1

crvtpoints r c 0.01 1.57 1
#Nb points : 2

crvtpoints r c 0.01 1.57 2
#Nb points : 2

crvtpoints r c 0.01 1.57 3
#Nb points : 2

crvtpoints r c 0.01 1.57 4
#Nb points : 3

crvtpoints r c 0.01 1.57 5
#Nb points : 5

crvtpoints r c 0.01 1.57 6
#Nb points : 5
No tags attached.
child of 0028500new oan Artifact in shaded view of the shape 
Issue History
2019-10-07 18:58oanNew Issue
2019-10-07 18:58oanAssigned To => msv
2019-10-07 18:59oanRelationship addedchild of 0028500
2019-10-07 19:00gitNote Added: 0087932
2019-10-08 16:44oanNote Added: 0087948
2019-10-08 17:27oanNote Edited: 0087948bug_revision_view_page.php?bugnote_id=87948#r22002
2019-10-19 19:08gitNote Added: 0088330
2019-10-20 00:35gitNote Added: 0088338
2019-10-21 19:35gitNote Added: 0088393
2019-10-28 13:49gitNote Added: 0088633
2019-10-28 16:06oanNote Added: 0088635
2019-10-28 16:06oanStatusnew => resolved
2019-10-28 16:40msvNote Added: 0088636
2019-10-28 18:21msvNote Added: 0088639
2019-10-28 18:22msvAssigned Tomsv => oan
2019-10-28 18:22msvStatusresolved => assigned
2019-10-29 11:06gitNote Added: 0088642
2019-10-29 11:06oanNote Added: 0088643
2019-10-29 11:06oanAssigned Tooan => msv
2019-10-29 11:06oanStatusassigned => resolved
2019-10-29 11:40msvNote Added: 0088644
2019-10-29 11:40msvAssigned Tomsv => bugmaster
2019-10-29 11:40msvStatusresolved => reviewed
2019-10-30 23:21apnTest case number => bugs modalg_7 bug31043
2019-10-31 10:59apnStatusreviewed => tested
2019-11-02 17:43oanChangeset attached => occt master da6b95a0
2019-11-02 17:43oanAssigned Tobugmaster => oan
2019-11-02 17:43oanStatustested => verified
2019-11-02 17:43oanResolutionopen => fixed
2019-11-10 11:41gitNote Added: 0088848
2019-11-10 11:41gitNote Added: 0088849

Notes
(0087932)
git   
2019-10-07 19:00   
Branch CR31043 has been created by oan.

SHA-1: 7547121ede67a7b829ec519d4dfe2b365d9d6d5b


Detailed log of new commits:

Author: oan
Date: Mon Oct 7 19:00:21 2019 +0300

    0031043: GCPnts_TangentialDeflection generates points which number is inconsistent with MinimumOfPoints Parameter
    
    Updated crvtpoints command API to reproduce reported problem
(0087948)
oan   
2019-10-08 16:44   
(edited on: 2019-10-08 17:27)
Please use updated command from CR31043 to reproduce aforementioned problem.

General idea is to teach low-level algorithm to produce number of points at least equal to specified minimum value.

(0088330)
git   
2019-10-19 19:08   
Branch CR31043 has been updated by oan.

SHA-1: 723d59feac1abd068e4f62ba89bf9e5fe3e204bc


Detailed log of new commits:

Author: oan
Date: Sat Oct 19 19:07:14 2019 +0300

    # generate number of points according to the specified minimum value

(0088338)
git   
2019-10-20 00:35   
Branch CR31043 has been updated by oan.

SHA-1: 62be3d632af31671f01ecab8dc8dbbceb53710ae


Detailed log of new commits:

Author: oan
Date: Sun Oct 20 00:34:06 2019 +0300

    # added test case

(0088393)
git   
2019-10-21 19:35   
Branch CR31043 has been updated by oan.

SHA-1: 5aa6ff778cd480395a07562e9789565652cc2c9f


Detailed log of new commits:

Author: oan
Date: Mon Oct 21 19:33:32 2019 +0300

    # revert PerformCircular changes

(0088633)
git   
2019-10-28 13:49   
Branch CR31043 has been updated forcibly by oan.

SHA-1: 8fecfb21b6557277a95e0c50c4ad05f040098ad2
(0088635)
oan   
2019-10-28 16:06   
Please review:

http://occt-tests/CR31043_1-master-OAN-OCCT/Debian80-64/diff_summary.html [^]
http://occt-tests/CR31043_1-master-OAN-OCCT/Windows-64-VC14/diff_summary.html [^]
(0088636)
msv   
2019-10-28 16:40   
Note: please give the link to compare page instead of summary. It is because there is a link to other pages from compare where, e.g., I can see new compilation warnings.
(0088639)
msv   
2019-10-28 18:21   
No remarks. Combine to one commit with one message before integration.
(0088642)
git   
2019-10-29 11:06   
Branch CR31043_1 has been created by oan.

SHA-1: da6b95a0752b92e58c66f4d571a7702ba1bab5ab


Detailed log of new commits:

Author: oan
Date: Tue Oct 29 11:04:53 2019 +0300

    0031043: GCPnts_TangentialDeflection generates points which number is inconsistent with MinimumOfPoints Parameter
    
    Updated crvtpoints command API to reproduce reported problem
    Generate number of points according to the specified minimum value
(0088643)
oan   
2019-10-29 11:06   
Pushed to branch CR31043_1.
(0088644)
msv   
2019-10-29 11:40   
Reviewed.
(0088848)
git   
2019-11-10 11:41   
Branch CR31043_1 has been deleted by inv.

SHA-1: da6b95a0752b92e58c66f4d571a7702ba1bab5ab
(0088849)
git   
2019-11-10 11:41   
Branch CR31043 has been deleted by inv.

SHA-1: 8fecfb21b6557277a95e0c50c4ad05f040098ad2