MantisBT - Community
View Issue Details
0031020Community[OCCT] OCCT:Codingpublic2019-10-01 19:212020-12-02 17:12
sraymond 
apn 
normaltrivial 
closedfixed 
[OCCT] 7.4.0 
[OCCT] 7.5.0[OCCT] 7.5.0 
Not needed
0031020: Coding - invalid inline usage in BRepBlend_AppSurface
In file BRepBlend_AppSurface.cxx

the implementation uses the keyword inline:

inline void BRepBlend_AppSurface::TolReached (Standard_Real& Tol3d,
                     Standard_Real& Tol2d) const
{
  Tol3d = approx.MaxErrorOnSurf();
  Tol2d = 0;
  for (Standard_Integer ii=1; ii<=approx.NbCurves2d(); ii++) {
    Tol2d = Max(Tol2d, approx.Max2dError(ii));
  }
}

Causing undefined symbol import error

I guess it comes from copy/paste error form BRepBlend_AppSurface.lxx

Please consider removing inline declaration or move back the method BRepBlend_AppSurface::TolReached back to BRepBlend_AppSurface.lxx
N/A
No tags attached.
Issue History
2019-10-01 19:21sraymondNew Issue
2019-10-01 19:21sraymondAssigned To => msv
2019-10-01 23:07gitNote Added: 0087675
2019-10-01 23:07msvStatusnew => assigned
2019-10-01 23:11msvNote Added: 0087676
2019-10-01 23:11msvAssigned Tomsv => kgv
2019-10-01 23:11msvStatusassigned => resolved
2019-10-01 23:11msvSteps to Reproduce Updatedbug_revision_view_page.php?rev_id=21923#r21923
2019-10-01 23:13kgvNote Added: 0087677
2019-10-01 23:14kgvCategoryOCCT:Modeling Algorithms => OCCT:Coding
2019-10-01 23:14kgvSummaryinvalid inline usage in BRepBlend_AppSurface => Coding - invalid inline usage in BRepBlend_AppSurface
2019-10-01 23:17gitNote Added: 0087678
2019-10-01 23:17kgvAssigned Tokgv => bugmaster
2019-10-01 23:17kgvStatusresolved => reviewed
2019-10-04 20:25apnTest case number => Not needed
2019-10-04 20:25apnNote Added: 0087844
2019-10-04 20:25apnStatusreviewed => tested
2019-10-23 01:07apnChangeset attached => occt master 746cb7c3
2019-10-23 01:07apnAssigned Tobugmaster => apn
2019-10-23 01:07apnStatustested => verified
2019-10-23 01:07apnResolutionopen => fixed
2019-10-23 11:51gitNote Added: 0088472
2020-12-02 16:40emoFixed in Version => 7.5.0
2020-12-02 17:12emoStatusverified => closed

Notes
(0087675)
git   
2019-10-01 23:07   
Branch CR31020 has been created by msv.

SHA-1: ed5e72c58e4ae0f773474c8710b02e7da2a92f7b


Detailed log of new commits:

Author: msv
Date: Tue Oct 1 23:06:35 2019 +0300

    0031020: invalid inline usage in BRepBlend_AppSurface
    
    BRepBlend_AppSurface and some other classes have been corrected to avoid inlining member functions in .cxx code.
(0087676)
msv   
2019-10-01 23:11   
Please review.

http://jenkins-test-12.nnov.opencascade.com/view/CR31020-MSV/view/COMPARE/ [^]
(0087677)
kgv   
2019-10-01 23:13   
-  inline void Nullify ();
+  inline void Nullify ()

"inline" looks redundant here.
(0087678)
git   
2019-10-01 23:17   
Branch CR31020 has been updated forcibly by kgv.

SHA-1: bb9fce1dd28876170a0150708303801748eadbbd
(0087844)
apn   
2019-10-04 20:25   
Combination -
OCCT branch : CR31020
master SHA - ed5e72c58e4ae0f773474c8710b02e7da2a92f7b
5f5b1aed1c6e139bbd34314eca77ae7abcd8895c
Products branch : master SHA - 83df4cb7aa05ca0b1f190a68462fc970ee162d17
was compiled on Linux, MacOS and Windows platforms and tested in optimize mode.

Number of compiler warnings:
No new/fixed warnings

Regressions/Differences/Improvements:
No regressions/differences

CPU differences:
Debian80-64:
OCCT
Total CPU difference: 16811.49999999996 / 16862.21000000009 [-0.30%]
Products
Total CPU difference: 10514.920000000038 / 10559.290000000046 [-0.42%]
Windows-64-VC14:
OCCT
Total CPU difference: 18323.109375 / 18333.171875 [-0.05%]
Products
Total CPU difference: 12505.421875 / 12537.390625 [-0.25%]

Image differences :
No differences that require special attention

Memory differences :
No differences that require special attention
(0088472)
git   
2019-10-23 11:51   
Branch CR31020 has been deleted by kgv.

SHA-1: bb9fce1dd28876170a0150708303801748eadbbd