MantisBT - Open CASCADE
View Issue Details
0031014Open CASCADE[OCCT] OCCT:Inspectorspublic2019-09-30 16:392020-02-23 12:25
nds 
bugmaster 
normalintegration request 
verifiedfixed 
 
[OCCT] 7.5.0* 
Not needed
0031014: Inspectors - variables for Qt in CMake
Some corrections for qt.cmake.

1. 3RDPARTY_QT_DIR should be shown if Qt is not found. It helps to input it manually. Otherwise(now) we have to add this variable by add a new variable with such name. Firstly it's boring, secondly the user may not know the name of required variable.

2. 3RDPARTY_DLL_DIRS should contains path to Qt binaries if qt is found. This variable is used in TInspector/DRAWEXE executable in VStudio to start it with debugger there.

The case is reproduced only if used Qt product is placed out of 3RDPARTY_DIR.
No tags attached.
Issue History
2019-09-30 16:39ndsNew Issue
2019-09-30 16:39ndsAssigned To => apn
2019-09-30 16:40ndsSummaryInspectors - variables for Qt => Inspectors - variables for Qt in CMake
2019-10-10 20:12gitNote Added: 0088029
2020-01-29 17:22gitNote Added: 0090160
2020-01-30 08:38ndsAssigned Toapn => nds
2020-01-30 08:38ndsSeverityminor => integration request
2020-01-30 08:38ndsDescription Updatedbug_revision_view_page.php?rev_id=22492#r22492
2020-01-30 08:43ndsNote Added: 0090185
2020-01-30 08:43ndsAssigned Tonds => apn
2020-01-30 08:43ndsStatusnew => resolved
2020-01-30 08:43ndsDescription Updatedbug_revision_view_page.php?rev_id=22493#r22493
2020-02-05 14:46apnAssigned Toapn => nds
2020-02-05 14:46apnStatusresolved => assigned
2020-02-09 09:12gitNote Added: 0090427
2020-02-09 16:30gitNote Added: 0090431
2020-02-10 17:00gitNote Added: 0090462
2020-02-10 17:05ndsNote Added: 0090463
2020-02-10 17:05ndsAssigned Tonds => apn
2020-02-10 17:05ndsStatusassigned => resolved
2020-02-13 11:49apnNote Added: 0090513
2020-02-13 11:49apnTest case number => Not needed
2020-02-13 11:49apnAssigned Toapn => bugmaster
2020-02-13 11:49apnStatusresolved => reviewed
2020-02-14 09:52bugmasterNote Added: 0090521
2020-02-14 09:52bugmasterStatusreviewed => tested
2020-02-15 14:55bugmasterChangeset attached => occt master 28b13b31
2020-02-15 14:55bugmasterStatustested => verified
2020-02-15 14:55bugmasterResolutionopen => fixed
2020-02-15 15:05gitNote Added: 0090531
2020-02-15 15:05gitNote Added: 0090545
2020-02-15 15:05gitNote Added: 0090549
2020-02-23 12:25gitNote Added: 0090644
2020-02-23 12:25gitNote Added: 0090645

Notes
(0088029)
git   
2019-10-10 20:12   
Branch CR31014 has been created by nds.

SHA-1: 15c5bf66dce076c24ed9e32efdc8c19c4b55212c


Detailed log of new commits:

Author: nds
Date: Fri Oct 4 09:36:19 2019 +0300

    0031014: Inspectors - variables for Qt in CMake
    
    (cherry picked from commit f3dd41854b0f1af6181c61d4d06ed813c7c342fb)
(0090160)
git   
2020-01-29 17:22   
Branch CR31014_1 has been created by nds.

SHA-1: 2a27b2527e4118a8f817788465743f6c79c67586


Detailed log of new commits:

Author: nds
Date: Wed Jan 29 17:18:22 2020 +0300

    0031014: Inspectors - variables for Qt in CMake
    
    Creates 3RDPARTY_QT_DIR in case if Qt is not found in 3RDPARTY_DIR in addition to error warning
    Appends QTDIR DRAWEXE project in order to be able to launch Inspector in VisualStudio if 'BUILD_Inspector' is active
(0090185)
nds   
2020-01-30 08:43   
Dear Andrey

could you please review the issue.
Jenkins job is: http://jenkins-test-12.nnov.opencascade.com/view/CR31014-master-NDS/ [^]

Thank you in advance, Natalia
(0090427)
git   
2020-02-09 09:12   
Branch CR31014_2 has been created by nds.

SHA-1: df458b17067107decaf59b8fffc80658815680d9


Detailed log of new commits:

Author: nds
Date: Sun Feb 9 09:12:20 2020 +0300

    0031014: Inspectors - variables for Qt in CMake

Author: nds
Date: Sat Feb 8 01:29:18 2020 +0300

    0030749: Inspectors - compilation under tcl scripts
    
    - provide different CSF_QT content for debug and release modes
(0090431)
git   
2020-02-09 16:30   
Branch CR31014_3 has been created by nds.

SHA-1: acaacf48f43e597612fad72d260b889c807a0b1e


Detailed log of new commits:

Author: nds
Date: Sun Feb 9 16:30:07 2020 +0300

    0031014: Inspectors - variables for Qt in CMake
    
    It restores path to Qt binary in 3RDPARTY_DLL_DIRS.
    Avoid using QTDIR. However Qt application requires plugin library set. As the path contains Qt binary, we iterates by variables to find it and set it as qt plugin if found.
(0090462)
git   
2020-02-10 17:00   
Branch CR31014_4 has been created by nds.

SHA-1: 1cc96642b64044d5494831ca11e29571bd1e36c9


Detailed log of new commits:

Author: nds
Date: Mon Feb 10 17:00:39 2020 +0300

    0031014: Inspectors - variables for Qt in CMake
    
    It restores path to Qt binaries in 3RDPARTY_DLL_DIRS for correct start TInspectorEXE under VStudio.
(0090463)
nds   
2020-02-10 17:05   
Dear Andrey,

the patch is simplified as agreed, please check.

Thank you a lot, Natalia
(0090513)
apn   
2020-02-13 11:49   
Reviewed, ready for integration.
(0090521)
bugmaster   
2020-02-14 09:52   
Tested in framework of WEEK-7

Combination -
OCCT branch : WEEK-7
master SHA - ed81d053016438d0b36485eefa9da2a90616f824
fe4497f3246e6bc1ced97ac331c148f0809ded15
Products branch : WEEK-7 SHA - fa93736d0dfc60600eb038f1a228db0ca19b8500
was compiled on Linux, MacOS and Windows platforms and tested in optimize mode.

Number of compiler warnings:
No new/fixed warnings

Regressions/Differences/Improvements:
No regressions/differences

CPU differences:
Debian80-64:
OCCT
Total CPU difference: 16972.490000000067 / 16995.740000000096 [-0.14%]
Products
Total CPU difference: 11439.249999999975 / 11455.569999999962 [-0.14%]
Windows-64-VC14:
OCCT
Total CPU difference: 18436.9375 / 18439.6875 [-0.01%]
Products
Total CPU difference: 13329.09375 / 13351.46875 [-0.17%]


Image differences :
No differences that require special attention

Memory differences :
No differences that require special attention
(0090516)
bugmaster (administrator)
2020-02-13 16:40

  
Errors of compilation: CentOS64-64

http://jenkins-test-08.nnov.opencascade.com/view/WEEK-7_WEEK-7/view/PRODUCTS%20compile/job/WEEK-7_WEEK-7-Products-CentOS64-64-opt-compile/2/parsed_console/ [^] [^] [^]
(0090517)
git (administrator) [ private ]
2020-02-13 18:46

  
Branch CR31208_2 has been updated by aml in OCCT Products internal repository.

SHA-1: e3bdec72b72d3653294c8ee1c2ceca54150f6dd7


Detailed log of new commits:

Author: aml
Date: Thu Feb 13 18:46:13 2020 +0300

    # Fix compilation for CentOS.

(0090519)
bugmaster (administrator)
2020-02-14 09:51

  
Tested in framework of WEEK-7
Combination -
OCCT branch : WEEK-7
master SHA - ed81d053016438d0b36485eefa9da2a90616f824
fe4497f3246e6bc1ced97ac331c148f0809ded15
Products branch : WEEK-7 SHA - fa93736d0dfc60600eb038f1a228db0ca19b8500
was compiled on Linux, MacOS and Windows platforms and tested in optimize mode.

Number of compiler warnings:
No new/fixed warnings

Regressions/Differences/Improvements:
No regressions/differences

CPU differences:
Debian80-64:
OCCT
Total CPU difference: 16972.490000000067 / 16995.740000000096 [-0.14%]
Products
Total CPU difference: 11439.249999999975 / 11455.569999999962 [-0.14%]
Windows-64-VC14:
OCCT
Total CPU difference: 18436.9375 / 18439.6875 [-0.01%]
Products
Total CPU difference: 13329.09375 / 13351.46875 [-0.17%]


Image differences :
No differences that require special attention

Memory differences :
No differences that require special attention
(0090531)
git   
2020-02-15 15:05   
Branch CR31014_2 has been deleted by inv.

SHA-1: df458b17067107decaf59b8fffc80658815680d9
(0090545)
git   
2020-02-15 15:05   
Branch CR31014_1 has been deleted by inv.

SHA-1: 2a27b2527e4118a8f817788465743f6c79c67586
(0090549)
git   
2020-02-15 15:05   
Branch CR31014 has been deleted by inv.

SHA-1: 15c5bf66dce076c24ed9e32efdc8c19c4b55212c
(0090644)
git   
2020-02-23 12:25   
Branch CR31014_3 has been deleted by inv.

SHA-1: acaacf48f43e597612fad72d260b889c807a0b1e
(0090645)
git   
2020-02-23 12:25   
Branch CR31014_4 has been deleted by inv.

SHA-1: 1cc96642b64044d5494831ca11e29571bd1e36c9