MantisBT - Open CASCADE
View Issue Details
0030982Open CASCADE[OCCT] OCCT:Visualizationpublic2019-09-19 11:102019-12-01 12:49
kgv 
bugmaster 
normalintegration request 
verifiedfixed 
 
[OCCT] 7.5.0* 
Not required
0030982: Visualization, OpenGl_View::MinMaxValues() - do not add background quad into depth range
OpenGl_View::MinMaxValues() adds background quad into MinMax values.
However, it does not make sense, since background is always drawn without depth test enabled.

Bnd_Box OpenGl_View::MinMaxValues (const Standard_Boolean theToIncludeAuxiliary) const
{
  if (!IsDefined())
  {
    return Bnd_Box();
  }

  Bnd_Box aBox = base_type::MinMaxValues (theToIncludeAuxiliary);

  // add bounding box of gradient/texture background for proper Z-fit
  if (theToIncludeAuxiliary
    && (myBackgrounds[Graphic3d_TOB_TEXTURE]->IsDefined()
     || myBackgrounds[Graphic3d_TOB_GRADIENT]->IsDefined()))
  {
    const Handle(Graphic3d_Camera)& aCamera = Camera();
    Graphic3d_Vec2i aWinSize;
    Window()->Size (aWinSize.x(), aWinSize.y());
Test case v3d/glsl/tiles shows an issue within tiled dump (gradient background is broken).
No tags attached.
related to 0022582closed bugmaster Visualization - provide an API for dumping a sub-region of the viewport 
related to 0031129new kgv Visualization - revise background / environment API 
png tiles_409x409_rttile128_KO.png (18,147) 2019-11-22 15:51
https://tracker.dev.opencascade.org/
Issue History
2019-09-19 11:10kgvNew Issue
2019-09-19 11:10kgvAssigned To => kgv
2019-11-18 17:12kgvAssigned Tokgv => mzernova
2019-11-18 17:12kgvStatusnew => assigned
2019-11-20 12:10kgvDescription Updatedbug_revision_view_page.php?rev_id=22226#r22226
2019-11-22 15:50kgvRelationship addedrelated to 0022582
2019-11-22 15:50kgvRelationship addedrelated to 0031129
2019-11-22 15:51kgvFile Added: tiles_409x409_rttile128_KO.png
2019-11-22 15:52kgvSteps to Reproduce Updatedbug_revision_view_page.php?rev_id=22245#r22245
2019-11-27 10:58gitNote Added: 0089214
2019-11-27 13:27kgvNote Added: 0089215
2019-11-27 15:41gitNote Added: 0089218
2019-11-27 15:42gitNote Added: 0089219
2019-11-27 15:47mzernovaNote Added: 0089220
2019-11-27 15:47mzernovaAssigned Tomzernova => osa
2019-11-27 15:47mzernovaStatusassigned => resolved
2019-11-29 10:12mzernovaNote Added: 0089273
2019-11-29 18:20osaNote Added: 0089292
2019-11-29 18:20osaAssigned Toosa => bugmaster
2019-11-29 18:20osaStatusresolved => reviewed
2019-12-01 12:19bugmasterNote Added: 0089309
2019-12-01 12:19bugmasterStatusreviewed => tested
2019-12-01 12:20bugmasterTest case number => Not required
2019-12-01 12:22bugmasterChangeset attached => occt master f051908e
2019-12-01 12:22bugmasterStatustested => verified
2019-12-01 12:22bugmasterResolutionopen => fixed
2019-12-01 12:49gitNote Added: 0089323
2019-12-01 12:49gitNote Added: 0089324

Notes
(0089214)
git   
2019-11-27 10:58   
Branch CR30982 has been created by mzernova.

SHA-1: 8506fe074d1b2600dc87ac3bd3bb9cf367b2ab82


Detailed log of new commits:

Author: mzernova
Date: Wed Nov 27 10:14:30 2019 +0300

    0030982: Visualization, OpenGl_View::MinMaxValues() - do not add background quad into depth range
    
    Deleted adding background quad into depth range. Background is drawn in 2D coordinates. Fixed problem with using gradient background in tiles.
(0089215)
kgv   
2019-11-27 13:27   
+  Graphic3d_Vec2i aTileOffset;
+  Graphic3d_Vec2i aTileSize;

Tip: Graphic3d_Vec2i aTileOffset, aTileSize;

aWorldView.SetDiagonal (OpenGl_Vec4 (2.f / aTileSize.x(), 2.f / aTileSize.y(), 1.f, 1.f));

Please prefer floating point "2.0f" with zeros in OCCT.
(0089218)
git   
2019-11-27 15:41   
Branch CR30982 has been updated by mzernova.

SHA-1: 4cc5450925d4b1a277c74d52689e4d21fc19d767


Detailed log of new commits:

Author: mzernova
Date: Wed Nov 27 15:28:26 2019 +0300

    remarks from kgv

(0089219)
git   
2019-11-27 15:42   
Branch CR30982_1 has been created by mzernova.

SHA-1: 0e602d2c4977d02d3ac7886407355ff80914696f


Detailed log of new commits:

Author: mzernova
Date: Wed Nov 27 10:14:30 2019 +0300

    0030982: Visualization, OpenGl_View::MinMaxValues() - do not add background quad into depth range
    
    Deleted adding background quad into depth range. Background is drawn in 2D coordinates. Fixed problem with using gradient background in tiles.
(0089220)
mzernova   
2019-11-27 15:47   
The patch CR30982 is ready to review
(0089273)
mzernova   
2019-11-29 10:12   
http://vm-jenkins-test-12.nnov.opencascade.com:8080/view/CR30982_1-master-mzernova [^]
(0089292)
osa   
2019-11-29 18:20   
The patch was reviewed
(0089309)
bugmaster   
2019-12-01 12:19   
Combination -
OCCT branch : IR-2019-11-29
master SHA - 72f6dc612c43748a2c8862fe64c845d72be684d9
5f5b1aed1c6e139bbd34314eca77ae7abcd8895c
Products branch : IR-2019-11-29 SHA - aff67a24109b329e80e8ffbd905de67b6637cbae
was compiled on Linux, MacOS and Windows platforms and tested in optimize mode.

Number of compiler warnings:
No new/fixed warnings

Regressions/Differences/Improvements:
No regressions/differences

CPU differences:
Debian80-64:
OCCT
Total CPU difference: 16902.370000000145 / 16848.370000000145 [+0.32%]
Products
Total CPU difference: 10823.520000000082 / 10787.150000000072 [+0.34%]
Windows-64-VC14:
OCCT
Total CPU difference: 18406.375 / 18305.59375 [+0.55%]
Products
Total CPU difference: 1321.28125 / 1322.4375 [-0.09%]


Image differences :
No differences that require special attention

Memory differences :
No differences that require special attention
(0089323)
git   
2019-12-01 12:49   
Branch CR30982_1 has been deleted by inv.

SHA-1: 0e602d2c4977d02d3ac7886407355ff80914696f
(0089324)
git   
2019-12-01 12:49   
Branch CR30982 has been deleted by inv.

SHA-1: 4cc5450925d4b1a277c74d52689e4d21fc19d767