MantisBT - Open CASCADE
View Issue Details
0030895Open CASCADE[OCCT] OCCT:Codingpublic2019-08-13 10:562019-08-17 12:32
kgv 
bugmaster 
normalintegration request 
verifiedfixed 
 
[OCCT] 7.4.0* 
Not required
0030895: Coding Rules - specify std namespace explicitly for std::cout and streams
It is proposed eliminating usage of "cout", "istream" and other streams without specifying "std::" namespace explicitly.
N/A
No tags attached.
related to 0008239verified bugmaster Foundation Classes - directive "using namespace std" doesn't allow to build application with OCC and other 3rd party libraries 
Issue History
2019-08-13 10:56kgvNew Issue
2019-08-13 10:56kgvAssigned To => kgv
2019-08-13 10:57kgvRelationship addedrelated to 0008239
2019-08-13 11:11gitNote Added: 0086218
2019-08-13 13:26kgvNote Added: 0086223
2019-08-13 13:26kgvAssigned Tokgv => bugmaster
2019-08-13 13:26kgvStatusnew => resolved
2019-08-13 13:26kgvStatusresolved => reviewed
2019-08-13 19:46bugmasterNote Added: 0086234
2019-08-13 19:46bugmasterStatusreviewed => tested
2019-08-15 17:46bugmasterTest case number => Not required
2019-08-17 12:07bugmasterChangeset attached => occt master 04232180
2019-08-17 12:07bugmasterStatustested => verified
2019-08-17 12:07bugmasterResolutionopen => fixed
2019-08-17 12:24gitNote Added: 0086301

Notes
(0086218)
git   
2019-08-13 11:11   
Branch CR30895 has been created by kgv.

SHA-1: a6308d072f0622c727d959da643f5ce6416f08fa


Detailed log of new commits:

Author: tiv
Date: Fri Aug 2 10:32:16 2019 +0300

    0030895: Coding Rules - specify std namespace explicitly for std::cout and streams
    
    "endl" manipulator for Message_Messenger is renamed to "Message_EndLine".
    
    The following entities from std namespace are now used
    with std:: explicitly specified (from Standard_Stream.hxx):
    std::istream,std::ostream,std::ofstream,std::ifstream,std::fstream,
    std::filebuf,std::streambuf,std::streampos,std::ios,std::cout,std::cerr,
    std::cin,std::endl,std::ends,std::flush,std::setw,std::setprecision,
    std::hex,std::dec.
(0086223)
kgv   
2019-08-13 13:26   
Please raise the patch.

http://jenkins-test-12.nnov.opencascade.com:8080/view/CR30895-CR30895-KGV [^]
(0086234)
bugmaster   
2019-08-13 19:46   
Combination -
OCCT branch : CR30895
master SHA - a6308d072f0622c727d959da643f5ce6416f08fa
5f5b1aed1c6e139bbd34314eca77ae7abcd8895c
Products branch : CR30895 SHA - 6c5e84c652ce1299c2e1c3b2eff1a35443a236a9
was compiled on Linux, MacOS and Windows platforms and tested in optimize mode.

Number of compiler warnings:
No new/fixed warnings

Regressions/Differences/Improvements:
No regressions/differences

CPU differences:
Debian80-64:
OCCT
Total CPU difference: 16247.03000000008 / 16274.830000000024 [-0.17%]
Products
Total CPU difference: 10483.480000000058 / 10475.390000000047 [+0.08%]
Windows-64-VC14:
OCCT
Total CPU difference: 17643.71875 / 17627.84375 [+0.09%]
Products
Total CPU difference: 12072.390625 / 11990.921875 [+0.68%]


Image differences :
No differences that require special attention

Memory differences :
No differences that require special attention
(0086301)
git   
2019-08-17 12:24   
Branch CR30895 has been deleted by inv.

SHA-1: a6308d072f0622c727d959da643f5ce6416f08fa