MantisBT - Community
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0030873Community[OCCT] OCCT:Modeling Algorithmspublic2019-08-07 14:252020-09-15 16:48
Reporterdrazmyslovich 
Assigned Toemv 
PrioritynormalSeverityminor 
StatusassignedResolutionopen 
PlatformWindowsOSVC++ 2015OS Version64 bit
Product Version[OCCT] 7.4.0 
Target Version[OCCT] 7.6.0*Fixed in Version 
Test case number
Summary0030873: Avoid the loop in reshaper
DescriptionCurrently, BRepTools_ReShape utility is not resistent to application loops.
Steps To ReproduceTopoDS_Shape a;
TopoDS_Shape b;

BRepTools_ReShape reshaper;
reshaper.replace (a, b);
reshaper.replace (b, a);

reshaper.Apply (a); // infinite loop
Additional information
and documentation updates
TagsNo tags attached.
Relationships
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2019-08-07 14:25drazmyslovichNew Issue
2019-08-07 14:25drazmyslovichAssigned To => drazmyslovich
2019-08-07 14:27gitNote Added: 0086063
2019-08-07 14:27drazmyslovichNote Added: 0086064
2019-08-07 14:27drazmyslovichAssigned Todrazmyslovich => msv
2019-08-07 14:27drazmyslovichStatusnew => resolved
2019-08-08 09:56msvNote Added: 0086082
2019-08-08 09:56msvAssigned Tomsv => emv
2019-08-08 09:56msvStatusresolved => assigned
2019-08-08 09:56msvStatusassigned => resolved
2019-08-12 14:43emvNote Added: 0086195
2019-08-12 14:43emvAssigned Toemv => drazmyslovich
2019-08-12 14:43emvStatusresolved => assigned
2019-08-12 15:11emvTarget Version7.4.0 => 7.5.0
2019-08-12 15:20emvNote Added: 0086199
2019-12-18 14:35drazmyslovichAssigned Todrazmyslovich =>
2019-12-18 14:35drazmyslovichAssigned To => emv
2019-12-18 14:38drazmyslovichNote Added: 0089623
2020-09-15 16:48msvTarget Version7.5.0 => 7.6.0*

Notes
(0086063)
git   
2019-08-07 14:27   
Branch CR30873 has been created by drazmyslovich.

SHA-1: 828a75f2280fa20235acae49af4cb2f0876d71e9


Detailed log of new commits:

Author: drazmyslovich
Date: Wed Aug 7 13:25:15 2019 +0200

    0030873: Make ReShape tool resistant to replacement loops
(0086064)
drazmyslovich   
2019-08-07 14:27   
The proposed solution is submitted, please, review
(0086082)
msv   
2019-08-08 09:56   
Dear Eugeny, please review it.
(0086195)
emv   
2019-08-12 14:43   
It is not good to call the Apply method which supposed to rebuild the shape in the replace method. At this stage we just need to check if there is no cyclic dependency between the shape and newshape recorded into a map. I suggest implementing a separate method for that without rebuilding, only analyzing the map.
(0086199)
emv   
2019-08-12 15:20   
Additionally, it is better to use Assertion mechanism to warn the user about the error.
(0089623)
drazmyslovich   
2019-12-18 14:38   
Dear Eugeny, unfortunately, I have currently no capacity to implement the proposed improvement (and I won't have time during the next 6 months as well), therefore I assign this ticket to you as occasionally you (your team) will decide to undertake some action on it yourselves.
I wish you Happy New Year and Happy Holidays.
Regards,
Dima