MantisBT - Open CASCADE
View Issue Details
0030854Open CASCADE[OCCT] OCCT:Visualizationpublic2019-07-26 09:592019-08-11 10:50
kgv 
bugmaster 
normalminor 
closedfixed 
[OCCT] 7.4.0 
[OCCT] 7.4.0[OCCT] 7.4.0 
v3d/viewcube/style
0030854: Visualization, AIS_ViewCube - pack triangulations into common array(s)
AIS_ViewCube creates an independent primitive array per element (6 box sides, 8 corners, 8 edges = 22), which is redundant overcomplication.
Triangulations should be grouped by common aspects.
N/A
No tags attached.
child of 0028954closed bugmaster Visualization - implement interactive object AIS_ViewCube for camera manipulations 
Issue History
2019-07-26 09:59kgvNew Issue
2019-07-26 09:59kgvAssigned To => kgv
2019-07-26 10:00kgvRelationship addedchild of 0028954
2019-08-05 22:27gitNote Added: 0086013
2019-08-06 00:18gitNote Added: 0086014
2019-08-06 00:20kgvNote Added: 0086015
2019-08-06 00:20kgvAssigned Tokgv => san
2019-08-06 00:20kgvStatusnew => resolved
2019-08-09 11:20kgvAssigned Tosan => bugmaster
2019-08-09 11:20kgvStatusresolved => reviewed
2019-08-09 12:18bugmasterTest case number => v3d/viewcube/style
2019-08-09 12:33bugmasterNote Added: 0086113
2019-08-09 12:33bugmasterStatusreviewed => tested
2019-08-11 10:40bugmasterChangeset attached => occt master caa309aa
2019-08-11 10:40bugmasterStatustested => verified
2019-08-11 10:40bugmasterResolutionopen => fixed
2019-08-11 10:50gitNote Added: 0086146

Notes
(0086013)
git   
2019-08-05 22:27   
Branch CR30854 has been created by kgv.

SHA-1: 9c9492fd7cdbd66ffde84173e75c8697794bcd71


Detailed log of new commits:

Author: kgv
Date: Mon Aug 5 20:26:11 2019 +0300

    0030854: Visualization, AIS_ViewCube - pack triangulations into common array(s)
    
    Presentation computation has been modified to merge triangulations per box part type.
    Prs3d_Drawer::FaceBoundaryDraw() flag is now handled for drawing box sides edges.
    
    Graphic3d_ArrayOfPrimitives has been extended by auxiliary methods:
    - ::AddSegmentEdges(), ::AddTriangleEdges(), ::AddQuadEdges() raising exception on wrong primitive type.
    - ::AddQuadTriangleEdges() splitting quad into indexed triangulation;
    - ::AddTriangleStripEdges() splitting triangle strip into indexed triangulation;
    - ::AddTriangleFanEdges() splitting triangle fan into indexed triangulation;
    - ::AddPolylineEdges() splitting polyline into indexed segments.
(0086014)
git   
2019-08-06 00:18   
Branch CR30854 has been updated forcibly by kgv.

SHA-1: 38f6e84905a1944987a38cdde703373a0940c0b8
(0086015)
kgv   
2019-08-06 00:20   
Patch is ready for review.

http://jenkins-test-12.nnov.opencascade.com:8080/view/CR30854-master-KGV [^]
(0086113)
bugmaster   
2019-08-09 12:33   
Combination -
OCCT branch : CR30854
master SHA - 38f6e84905a1944987a38cdde703373a0940c0b8
5f5b1aed1c6e139bbd34314eca77ae7abcd8895c
Products branch : master SHA - 53815c0544dd1e39d32ee14979d7d88e78729edc
was compiled on Linux, MacOS and Windows platforms and tested in optimize mode.

Number of compiler warnings:
No new/fixed warnings

Regressions/Differences/Improvements:
No regressions/differences

CPU differences:
Debian80-64:
OCCT
Total CPU difference: 16232.520000000062 / 16237.229999999976 [-0.03%]
Products
Total CPU difference: 10480.390000000032 / 10493.010000000033 [-0.12%]
Windows-64-VC14:
OCCT
Total CPU difference: 17636.71875 / 17592.765625 [+0.25%]
Products
Total CPU difference: 12049.15625 / 12065.453125 [-0.14%]


Image differences :
No differences that require special attention

Memory differences :
No differences that require special attention
(0086146)
git   
2019-08-11 10:50   
Branch CR30854 has been deleted by inv.

SHA-1: 38f6e84905a1944987a38cdde703373a0940c0b8