MantisBT - Community
View Issue Details
0030846Community[OCCT] OCCT:Foundation Classespublic2019-07-17 11:552019-09-07 16:26
BenjaminBihler 
bugmaster 
normaltrivial 
closedfixed 
ALL
[OCCT] 6.5.1 
[OCCT] 7.4.0[OCCT] 7.4.0 
Not required
0030846: Foundation Classes - StorageInfo violates the C++ One Definition Rule
When building with link-time optimization (-flto), g++ warns that the struct StorageInfo is defined both in OSD_MAllocHook.cxx:250 and in NCollection_BaseAllocator.cxx:72. This violates the C++ One Definition Rule. Therefore the structures should be merged or renamed.
No tags attached.
Issue History
2019-07-17 11:55BenjaminBihlerNew Issue
2019-07-17 11:55BenjaminBihlerAssigned To => abv
2019-09-04 18:38kgvRelationship addedrelated to 0030864
2019-09-04 18:45gitNote Added: 0086751
2019-09-04 18:47kgvRelationship addedrelated to 0022256
2019-09-04 23:06kgvNote Added: 0086759
2019-09-04 23:06kgvSeverityminor => trivial
2019-09-04 23:06kgvStatusnew => resolved
2019-09-04 23:06kgvProduct Version => 6.5.1
2019-09-05 04:44abvNote Added: 0086763
2019-09-05 04:44abvAssigned Toabv => bugmaster
2019-09-05 04:44abvStatusresolved => reviewed
2019-09-05 18:15bugmasterTest case number => Not required
2019-09-05 18:17bugmasterNote Added: 0086811
2019-09-05 18:17bugmasterStatusreviewed => tested
2019-09-07 11:38bugmasterChangeset attached => occt master 9eefb360
2019-09-07 11:38bugmasterStatustested => verified
2019-09-07 11:38bugmasterResolutionopen => fixed
2019-09-07 16:26gitNote Added: 0086934

Notes
(0086751)
git   
2019-09-04 18:45   
Branch CR30846 has been created by kgv.

SHA-1: 34d19c2485b56b359f5d3f75c621b3ce8b3d159f


Detailed log of new commits:

Author: kgv
Date: Wed Sep 4 18:42:42 2019 +0300

    0030846: Foundation Classes - StorageInfo violates the C++ One Definition Rule
    
    Local definitions have been put into anonymouse namespace within files
    OSD_MAllocHook.cxx and NCollection_BaseAllocator.cxx.
(0086759)
kgv   
2019-09-04 23:06   
Patch is ready for review.

http://jenkins-test-12.nnov.opencascade.com:8080/view/CR30846-master-KGV/ [^]
(0086763)
abv   
2019-09-05 04:44   
No remarks, please integrate
(0086811)
bugmaster   
2019-09-05 18:17   
Combination -
OCCT branch : CR30846
master SHA - 34d19c2485b56b359f5d3f75c621b3ce8b3d159f
5f5b1aed1c6e139bbd34314eca77ae7abcd8895c
Products branch : master SHA - 34e9bf11c6b525830b5dee35839707da81e7d1ab
was compiled on Linux, MacOS and Windows platforms and tested in optimize mode.

Number of compiler warnings:
No new/fixed warnings

Regressions/Differences/Improvements:
No regressions/differences

CPU differences:
Debian80-64:
OCCT
Total CPU difference: 16200.500000000076 / 16167.270000000033 [+0.21%]
Products
Total CPU difference: 10489.310000000056 / 10484.930000000048 [+0.04%]
Windows-64-VC14:
OCCT
Total CPU difference: 18288.9375 / 18256.515625 [+0.18%]
Products
Total CPU difference: 12130.375 / 12168.265625 [-0.31%]


Image differences :
No differences that require special attention

Memory differences :
No differences that require special attention
(0086934)
git   
2019-09-07 16:26   
Branch CR30846 has been deleted by inv.

SHA-1: 34d19c2485b56b359f5d3f75c621b3ce8b3d159f