MantisBT - Open CASCADE
View Issue Details
0030804Open CASCADE[OCCT] OCCT:Foundation Classespublic2019-06-24 12:502019-07-08 12:58
kgv 
apn 
normalminor 
verifiedfixed 
[OCCT] 6.3.1 
[OCCT] 7.4.0* 
bugs fclasses bug30804
0030804: Foundation Classes - Poly_Connect crashes due to out-of-range array modification
Poly_Connect crashes on some triangulations due to out-of-range memory access.
pload MODELING VISUALIZATION
restore bug30804.brep b
vclear
vinit View1
vdisplay b
vfit


Result:
Error: AIS_Shape::Compute() wireframe presentation builder has failed (ACCESS VIOLATION at address 0xFFFFFFFFFFFFFFFF 
during 'READ' operation)
No tags attached.
? bug30804.brep (183,890) 2019-06-24 13:01
https://tracker.dev.opencascade.org/
Issue History
2019-06-24 12:50kgvNew Issue
2019-06-24 12:50kgvAssigned To => abv
2019-06-24 13:01kgvSteps to Reproduce Updatedbug_revision_view_page.php?rev_id=21419#r21419
2019-06-24 13:01kgvFile Added: bug30804.brep
2019-06-24 13:05kgvSummaryFoundation Classes - Poly_Connect crash due to out-of-range array modification => Foundation Classes - Poly_Connect crashes due to out-of-range array modification
2019-06-24 13:08gitNote Added: 0085258
2019-06-24 13:09gitNote Added: 0085260
2019-06-24 15:06kgvProduct Version7.3.0 => 6.3.1
2019-06-24 17:07kgvNote Added: 0085264
2019-06-24 17:07kgvAssigned Toabv => emv
2019-06-24 17:07kgvStatusnew => resolved
2019-06-25 08:49emvNote Added: 0085274
2019-06-25 08:49emvAssigned Toemv => kgv
2019-06-25 08:49emvStatusresolved => assigned
2019-06-25 11:26kgvNote Added: 0085280
2019-06-25 11:26kgvAssigned Tokgv => emv
2019-06-25 11:26kgvStatusassigned => resolved
2019-06-25 11:30gitNote Added: 0085283
2019-06-25 12:16emvAssigned Toemv => kgv
2019-06-25 12:16emvStatusresolved => assigned
2019-06-25 12:16emvNote Added: 0085287
2019-06-25 12:31gitNote Added: 0085288
2019-06-25 12:32kgvNote Added: 0085289
2019-06-25 12:32kgvAssigned Tokgv => emv
2019-06-25 12:32kgvStatusassigned => resolved
2019-06-25 12:32emvNote Added: 0085290
2019-06-25 12:32emvAssigned Toemv => bugmaster
2019-06-25 12:32emvStatusresolved => reviewed
2019-06-25 12:51apnTest case number => bugs fclasses bug30804
2019-06-25 13:08apnNote Added: 0085294
2019-06-25 13:08apnStatusreviewed => tested
2019-07-01 17:28apnChangeset attached => occt master 841aa8c4
2019-07-01 17:28apnAssigned Tobugmaster => apn
2019-07-01 17:28apnStatustested => verified
2019-07-01 17:28apnResolutionopen => fixed
2019-07-08 12:58gitNote Added: 0085477

Notes
(0085258)
git   
2019-06-24 13:08   
Branch CR30804 has been created by kgv.

SHA-1: 50493c95b9250876ed9926c00df4bf30c5579638


Detailed log of new commits:

Author: kgv
Date: Mon Jun 24 13:07:04 2019 +0300

    0030804: Foundation Classes - Poly_Connect crash due to out-of-range array modification
    
    Fixed initialization of edges array based on the wrong statement.
(0085260)
git   
2019-06-24 13:09   
Branch CR30804 has been updated forcibly by kgv.

SHA-1: 68948e0c59e652a55f3f4c4f0820fe9f6bb39731
(0085264)
kgv   
2019-06-24 17:07   
Patch is ready for review.

http://jenkins-test-12.nnov.opencascade.com:8080/view/CR30804-master-KGV [^]
(0085274)
emv   
2019-06-25 08:49   
- src/Poly/Poly_Connect.cxx
line 129-130, 166, 181-182 - The comments are not relevant with new variables

The attached shape has not been put into data base before testing, so obviously the test case has failed.
I've put the shape into data base now. Please restart the failing test cases.
(0085280)
kgv   
2019-06-25 11:26   
Testing results:

http://jenkins-test-12.nnov.opencascade.com:8080/view/CR30804-master-KGV-2/view/COMPARE/ [^]
(0085283)
git   
2019-06-25 11:30   
Branch CR30804 has been updated by kgv.

SHA-1: 90cf086785b5eacd96c80d7b07a600987cb922a3


Detailed log of new commits:

Author: kgv
Date: Tue Jun 25 11:29:25 2019 +0300

    # updated comments

(0085287)
emv   
2019-06-25 12:16   
line 166 - please change "fore each edge in triangle" to "for each edge in triangle"
(0085288)
git   
2019-06-25 12:31   
Branch CR30804 has been updated forcibly by kgv.

SHA-1: f87de7f799eb2859e726cb45579a3c86c6b30378
(0085289)
kgv   
2019-06-25 12:32   
Misprint fixed.
(0085290)
emv   
2019-06-25 12:32   
Reviewed.
(0085294)
apn   
2019-06-25 13:08   
Combination -
OCCT branch : CR30804
master SHA - 68948e0c59e652a55f3f4c4f0820fe9f6bb39731
d67d4b811012eef8913d3c535c29654d0acf3c4c
Products branch : master SHA - c08b242c9da615bfdf83ca463321740d4cc22898
was compiled on Linux, MacOS and Windows platforms and tested in optimize mode.

Number of compiler warnings:
No new/fixed warnings

Regressions/Differences/Improvements:
No regressions/differences

CPU differences:
Debian80-64:
OCCT
Total CPU difference: 16475.69 / 16513.620000000094 [-0.23%]
Products
Total CPU difference: 10489.11000000006 / 10515.620000000044 [-0.25%]
Windows-64-VC14:
OCCT
Total CPU difference: 17802.03125 / 17822.375 [-0.11%]
Products
Total CPU difference: 12072.71875 / 12126.671875 [-0.44%]

Image differences :
No differences that require special attention

Memory differences :
No differences that require special attention
(0085477)
git   
2019-07-08 12:58   
Branch CR30804 has been deleted by inv.

SHA-1: f87de7f799eb2859e726cb45579a3c86c6b30378