MantisBT - Community
View Issue Details
0030799Community[OCCT] OCCT:DRAWpublic2019-06-21 13:012019-07-20 11:56
user897 
bugmaster 
normalfeature 
closedfixed 
 
[OCCT] 7.4.0[OCCT] 7.4.0 
Not required
0030799: Draw Harness, ViewerTest - setup uniforms via vshader command
It is proposed extending vshader command to setup custom uniforms,
Not required
No tags attached.
Issue History
2019-06-21 13:01user897New Issue
2019-06-21 13:01user897Assigned To => apn
2019-06-21 13:01user897Assigned Toapn => user897
2019-06-21 13:01user897Statusnew => assigned
2019-06-25 14:15gitNote Added: 0085296
2019-06-25 14:22kgvNote Added: 0085297
2019-06-25 14:53gitNote Added: 0085300
2019-06-26 12:01user897Assigned Touser897 => kgv
2019-06-26 12:01user897Statusassigned => resolved
2019-06-26 12:01user897Steps to Reproduce Updatedbug_revision_view_page.php?rev_id=21432#r21432
2019-06-27 11:37kgvNote Added: 0085319
2019-06-27 11:37kgvAssigned Tokgv => user897
2019-06-27 11:37kgvStatusresolved => assigned
2019-07-08 17:52gitNote Added: 0085498
2019-07-17 13:25user897Assigned Touser897 => osa
2019-07-17 13:25user897Statusassigned => resolved
2019-07-17 19:10gitNote Added: 0085721
2019-07-18 11:33osaNote Added: 0085746
2019-07-18 11:34osaNote Added: 0085747
2019-07-18 11:34osaAssigned Toosa => bugmaster
2019-07-18 11:34osaStatusresolved => reviewed
2019-07-18 12:45bugmasterTest case number => Not required
2019-07-18 13:34bugmasterNote Added: 0085760
2019-07-18 13:34bugmasterStatusreviewed => tested
2019-07-20 11:42bugmasterChangeset attached => occt master 0dab5817
2019-07-20 11:42bugmasterStatustested => verified
2019-07-20 11:42bugmasterResolutionopen => fixed
2019-07-20 11:56gitNote Added: 0085845

Notes
(0085296)
git   
2019-06-25 14:15   
Branch CR30799 has been created by mzernova.

SHA-1: 743587ac7c58cf7c4a4c95d66614e8b18381f6c3


Detailed log of new commits:

Author: mzernova
Date: Tue Jun 25 13:41:45 2019 +0300

    0030799: Draw Harness, ViewerTest - setup uniforms via vshader command
    
    vshaderprog command now supports setup custom uniforms
(0085297)
kgv   
2019-06-25 14:22   
+                  "\n\t\t:   [-uniform name value]"

Please specify in help that this is a float uniform.

+      aProgram->PushVariableFloat (theArgVec[++anArgIter], float (atof (theArgVec[++anArgIter])));


atof -> Draw::Atof().
(0085300)
git   
2019-06-25 14:53   
Branch CR30799 has been updated by mzernova.

SHA-1: ae21db4828c9eefdb59b2a3c336ba76f1a90bce1


Detailed log of new commits:

Author: mzernova
Date: Tue Jun 25 14:51:59 2019 +0300

    0030799: Draw Harness, ViewerTest - setup uniforms via vshader command
    
    Added specification in help that this is a float uniform

(0085319)
kgv   
2019-06-27 11:37   
Please correct your git settings to setup acronym in Author and Commiter fields, then push squashed commit with correct fields.

Take a look at commit in gitweb to verify these fields:
http://git.dev.opencascade.org/gitweb/?p=occt.git;a=commitdiff;h=ae21db4828c9eefdb59b2a3c336ba76f1a90bce1 [^]
(0085498)
git   
2019-07-08 17:52   
Branch CR30799 has been updated forcibly by mzernova.

SHA-1: 3ec983b8bd4acd56d8fcafb1aa6ad826908baf89
(0085721)
git   
2019-07-17 19:10   
Branch CR30799 has been updated forcibly by mzernova.

SHA-1: db8d118cc3f9ed1dc631c100db1bab3c441e2fb2
(0085746)
osa   
2019-07-18 11:33   
http://jenkins-test-12.nnov.opencascade.com:8080/view/CR30799-master-OSA/ [^]
(0085747)
osa   
2019-07-18 11:34   
The patch CR30799 was reviewed
(0085760)
bugmaster   
2019-07-18 13:34   
Combination -
OCCT branch : CR30799
master SHA - db8d118cc3f9ed1dc631c100db1bab3c441e2fb2
32ce09545dc9c46a47a51a964a24b1f472e6c2c4
Products branch : master SHA - ce8f14216a548db739b749891b6f800b0d5c6e8b
was compiled on Linux, MacOS and Windows platforms and tested in optimize mode.

Number of compiler warnings:
No new/fixed warnings

Regressions/Differences/Improvements:
No regressions/differences

CPU differences:
Debian80-64:
OCCT
Total CPU difference: 16226.360000000115 / 16237.640000000089 [-0.07%]
Products
Total CPU difference: 10462.800000000021 / 10517.890000000038 [-0.52%]
Windows-64-VC14:
OCCT
Total CPU difference: 17637.453125 / 17623.078125 [+0.08%]
Products
Total CPU difference: 12076.25 / 12058.53125 [+0.15%]


Image differences :
No differences that require special attention

Memory differences :
No differences that require special attention
(0085845)
git   
2019-07-20 11:56   
Branch CR30799 has been deleted by inv.

SHA-1: db8d118cc3f9ed1dc631c100db1bab3c441e2fb2