MantisBT - Open CASCADE
View Issue Details
0030635Open CASCADE[OCCT] OCCT:Visualizationpublic2019-04-08 16:142019-04-14 15:41
kgv 
apn 
normalintegration request 
verifiedfixed 
 
[OCCT] 7.4.0 
Not needed
0030635: Visualization - move OpenGl_Layer to Graphic3d_Layer
OpenGl_Layer implementation is general-purpose and irrelevant to OpenGL (apart from the method OpenGl_Layer::Render()),
so that it should be moved from TKOpenGl to TKV3d toolkit.
N/A
No tags attached.
child of 0030631new kgv Visualization - Vulkan graphic driver prototype 
Issue History
2019-04-08 16:14kgvNew Issue
2019-04-08 16:14kgvAssigned To => kgv
2019-04-08 16:15kgvRelationship addedchild of 0030631
2019-04-08 16:27kgvDescription Updatedbug_revision_view_page.php?rev_id=20983#r20983
2019-04-08 16:53gitNote Added: 0083527
2019-04-08 18:11kgvNote Added: 0083536
2019-04-08 18:11kgvAssigned Tokgv => san
2019-04-08 18:11kgvStatusnew => resolved
2019-04-09 09:08kgvAssigned Tosan => osa
2019-04-09 12:05osaNote Added: 0083556
2019-04-09 12:05osaAssigned Toosa => bugmaster
2019-04-09 12:05osaStatusresolved => reviewed
2019-04-09 13:14apnTest case number => Not needed
2019-04-09 13:14apnNote Added: 0083566
2019-04-09 13:14apnStatusreviewed => tested
2019-04-14 15:36apnChangeset attached => occt master d325cb7f
2019-04-14 15:36apnAssigned Tobugmaster => apn
2019-04-14 15:36apnStatustested => verified
2019-04-14 15:36apnResolutionopen => fixed
2019-04-14 15:41gitNote Added: 0083716

Notes
(0083527)
git   
2019-04-08 16:53   
Branch CR30635 has been created by kgv.

SHA-1: 06e6ef272690991b2e83353c6f2e017aaccca86c


Detailed log of new commits:

Author: kgv
Date: Mon Apr 8 16:22:20 2019 +0300

    0030635: Visualization - move OpenGl_Layer to Graphic3d_Layer
    
    Renamed classes (moved from TKOpenGl to TKV3d):
    - OpenGl_Layer -> Graphic3d_Layer;
    - OpenGl_BVHClipPrimitiveSet -> Graphic3d_BvhCStructureSet;
    - OpenGl_BVHClipPrimitiveTrsfPersSet -> Graphic3d_BvhCStructureSetTrsfPers;
    - OpenGl_BVHTreeSelector -> Graphic3d_CullingTool.
    
    Method OpenGl_Layer::Render() has been moved to OpenGl_LayerList::renderLayer().
    
    Standard Z-layers list definition has been moved
    from OpenGl_GraphicDriver to base class Graphic3d_GraphicDriver.
(0083536)
kgv   
2019-04-08 18:11   
Patch is ready for review.
(0083556)
osa   
2019-04-09 12:05   
Reviewed without remarks.
(0083566)
apn   
2019-04-09 13:14   
Combination -
OCCT branch : CR30635
master SHA - 06e6ef272690991b2e83353c6f2e017aaccca86c
d67d4b811012eef8913d3c535c29654d0acf3c4c
Products branch : master SHA - d412f0b027477420c2d298427655475b16b61588
was compiled on Linux, MacOS and Windows platforms and tested in optimize mode.

Number of compiler warnings:
No new/fixed warnings

Regressions/Differences/Improvements:
No regressions/differences

CPU differences:
Debian80-64:
OCCT
Total CPU difference: 16602.930000000066 / 16561.32 [+0.25%]
Products
Total CPU difference: 10496.330000000049 / 10513.120000000044 [-0.16%]
Windows-64-VC14:
OCCT
Total CPU difference: 17953.5 / 17981.5625 [-0.16%]
Products
Total CPU difference: 12018.84375 / 11993.9375 [+0.21%]

Image differences :
No differences that require special attention

Memory differences :
No differences that require special attention
(0083716)
git   
2019-04-14 15:41   
Branch CR30635 has been deleted by inv.

SHA-1: 06e6ef272690991b2e83353c6f2e017aaccca86c