0030598: Visualization - redesign Prs3d_Drawer as aspects map

MantisBT - Open CASCADE

View Issue Details

Project

Category

View Status

Date Submitted

Last Update

0030598

Open CASCADE

[OCCT] OCCT:Visualization

public

2019-03-21 19:40

2020-04-16 10:57

Reporter

kgv

Assigned To

Priority

normal

Severity

integration request

Status

assigned

Resolution

open

Platform

OS Version

Product Version

Target Version

[OCCT] 7.5.0*

Fixed in Version

Test case number

Summary

0030598: Visualization - redesign Prs3d_Drawer as aspects map

Description

Current Prs3d_Drawer design provides a list of fixed properties of different types:
- Boolean flags
- Real parameters
- Prs3d_ShadingAspect
- Prs3d_TextAspect
- Prs3d_IsoAspect
- Prs3d_LineAspect
- Prs3d_PlaneAspect
- Prs3d_ArrowAspect
- Prs3d_DatumAspect
- Prs3d_DimensionAspect

All these properties can be either defined within Prs3d_Drawer instance ("own" aspects), or retrieved from Link aspect.

In addition, most properties are dynamically initialized and stored as Prs3d_Drawer instance fields when fetched and actually undefined (property is not "own" nor defined within Link).
This is an obsolete approach which should be avoided - instead it is proposed creating a global Prs3d_Drawer instance to preserve current behavior or to throw exception in this case.

The new Prs3d_Drawer design should define a map of properties so that it is preferable to define common base class for all properties. The key type of this map is to be determined - it might be string or integer number with enumeration defining UPPER value for values reserved by OCCT, so that applications can define own properties.

The rationale for map of aspects instead of a fixed list is that even existing Prs3d_Drawer definition includes too many properties, while most of properties have effect only within sub-set of AIS classes. It is also impossible defining more presentation properties through common mechanism of Prs3d_Drawer without its extension, so that custom presentations have to define such properties as class fields.

To avoid massive API changes, existing getter/setters have to be preserved.

MeshVS_Drawer is one of candidates for possible usage of new Prs3d_Drawer API.

Steps To Reproduce

Additional information
and documentation updates

Tags

No tags attached.

Relationships

related to	0030309	feedback	kgv	Community	AIS_Shape, Visualization - Free Boundary Aspect Is Not Correctly Used in Shaded Display Mode
related to	0031424	verified	kgv	Open CASCADE	Visualization - stop using Prs3d_Drawer::HLRAngle() parameter