MantisBT - Open CASCADE
View Issue Details
0030593Open CASCADE[OCCT] OCCT:Modeling Algorithmspublic2019-03-19 11:282019-04-08 12:18
kgv 
apn 
normalminor 
verifiedfixed 
[OCCT] 5.2.2 
[OCCT] 7.4.0* 
bugs modalg_2 bug21
0030593: Modeling Algorithms - ShapeUpgrade_ShapeDivide::Perform() throws Standard_NoMoreObject
ShapeUpgrade_ShapeDivide::Perform() throws Standard_NoMoreObject when exceptions are enabled.
Test case bugs/modalg_2/bug21
No tags attached.
Issue History
2019-03-19 11:28kgvNew Issue
2019-03-19 11:28kgvAssigned To => msv
2019-03-19 11:31gitNote Added: 0083102
2019-03-19 13:05gitNote Added: 0083109
2019-03-19 13:06gitNote Added: 0083110
2019-03-19 15:19kgvNote Added: 0083113
2019-03-19 15:19kgvStatusnew => resolved
2019-03-20 19:28msvNote Added: 0083155
2019-03-20 19:28msvAssigned Tomsv => kgv
2019-03-20 19:28msvStatusresolved => assigned
2019-03-20 22:21gitNote Added: 0083160
2019-03-21 06:59kgvNote Added: 0083162
2019-03-21 06:59kgvAssigned Tokgv => msv
2019-03-21 06:59kgvStatusassigned => resolved
2019-03-21 09:15msvNote Added: 0083169
2019-03-21 09:15msvAssigned Tomsv => bugmaster
2019-03-21 09:15msvStatusresolved => reviewed
2019-03-21 12:36apnTest case number => bugs modalg_2 bug21
2019-03-21 12:36apnNote Added: 0083181
2019-03-21 12:36apnStatusreviewed => tested
2019-03-24 18:54apnChangeset attached => occt master 2328cae2
2019-03-24 18:54apnAssigned Tobugmaster => apn
2019-03-24 18:54apnStatustested => verified
2019-03-24 18:54apnResolutionopen => fixed
2019-04-08 12:18gitNote Added: 0083491
2019-04-08 12:18gitNote Added: 0083497

Notes
(0083102)
git   
2019-03-19 11:31   
Branch CR30593 has been created by kgv.

SHA-1: 48f8f520ef8dd80a8ffc0881fcd4ba90a3627758


Detailed log of new commits:

Author: kgv
Date: Tue Mar 19 11:24:21 2019 +0300

    0030593: Modeling Algorithms - ShapeUpgrade_ShapeDivide::Perform() throws Standard_NoMoreObject
    
    Added missing TopExp_Explorer::More() check.
(0083109)
git   
2019-03-19 13:05   
Branch CR30593 has been updated by kgv.

SHA-1: f41d6f8329614a2552fcdb3fd943b73cff34bbc2


Detailed log of new commits:

Author: kgv
Date: Tue Mar 19 11:31:06 2019 +0300

    BRepCheck_Analyzer::Perform() - add missing TopExp_Explorer::More() check.

(0083110)
git   
2019-03-19 13:06   
Branch CR30593_1 has been created by kgv.

SHA-1: 3b4234e2601b5b33eca49c1935770ad959349a36


Detailed log of new commits:

Author: kgv
Date: Tue Mar 19 11:24:21 2019 +0300

    0030593: Modeling Algorithms - ShapeUpgrade_ShapeDivide::Perform() throws Standard_NoMoreObject
    
    Added missing TopExp_Explorer::More() checks to ShapeUpgrade_ShapeDivide::Perform() and BRepCheck_Analyzer::Perform().
(0083113)
kgv   
2019-03-19 15:19   
Patch is ready for review.

http://jenkins-test-12.nnov.opencascade.com:8080/view/CR30593_1-master-KGV/ [^]
(0083155)
msv   
2019-03-20 19:28   
src/BRepCheck/BRepCheck_Analyzer.cxx
- In line 150 the variable exp is always not initialized, so SetFailStatus(exp.Current()) may be simply removed.

Please check the difference in products on Linux:
IMAGE sat read_parallel_1 A1: A1.png differs [15895 different pixels]
(0083160)
git   
2019-03-20 22:21   
Branch CR30593_1 has been updated forcibly by kgv.

SHA-1: d0d5c7bad6b246f9a733e56a4a0ff44f65ea8d74
(0083162)
kgv   
2019-03-21 06:59   
Line has been removed.

http://jenkins-test-12.nnov.opencascade.com:8080/view/CR30593_1-master-KGV/ [^]
(0083169)
msv   
2019-03-21 09:15   
Reviewed.
(0083181)
apn   
2019-03-21 12:36   
Combination -
OCCT branch : CR30593_1
master SHA - d0d5c7bad6b246f9a733e56a4a0ff44f65ea8d74
d67d4b811012eef8913d3c535c29654d0acf3c4c
Products branch : master SHA - b3958866f73826c2eaaa9470209980d22e210fba
was compiled on Linux, MacOS and Windows platforms and tested in optimize mode.

Number of compiler warnings:
No new/fixed warnings

Regressions/Differences/Improvements:
No regressions/differences

CPU differences:
Debian80-64:
OCCT
Total CPU difference: 16631.159999999985 / 16593.449999999997 [+0.23%]
Products
Total CPU difference: 9106.930000000042 / 9102.210000000046 [+0.05%]
Windows-64-VC14:
OCCT
Total CPU difference: 17992.734375 / 17984.46875 [+0.05%]
Products
Total CPU difference: 10544.484375 / 10609.28125 [-0.61%]

Image differences :
No differences that require special attention

Memory differences :
No differences that require special attention
(0083491)
git   
2019-04-08 12:18   
Branch CR30593_1 has been deleted by inv.

SHA-1: d0d5c7bad6b246f9a733e56a4a0ff44f65ea8d74
(0083497)
git   
2019-04-08 12:18   
Branch CR30593 has been deleted by inv.

SHA-1: f41d6f8329614a2552fcdb3fd943b73cff34bbc2