MantisBT - Open CASCADE
View Issue Details
0030573Open CASCADE[OCCT] OCCT:Foundation Classespublic2019-03-14 19:232019-09-11 11:03
oan 
apn 
normalminor 
verifiedfixed 
 
[OCCT] 7.4.0 
Not needed
0030573: OSD_Parallel_TBB: limit number of execution threads using settings of OSD_ThreadPool::DefaultPool()
Currently there is no possibility to limit number of execution threads for TBB-based implementation of OSD_Parallel.

It is suggested to add tbb::task_scheduler_init to OSD_Parallel::forEach() method for that reason.
Not required
No tags attached.
related to 0029935verified bugmaster Foundation Classes - introduce OSD_ThreadPool class defining a thread pool 
parent of 0030959verified bugmaster OSD_Parallel_TBB: number of execution threads is strictly limited by the root scope 
child of 0028199assigned ski Add possibility to set number of threads for parallel execution 
Issue History
2019-03-14 19:23oanNew Issue
2019-03-14 19:23oanAssigned To => abv
2019-03-14 20:12gitNote Added: 0082962
2019-03-14 21:21kgvRelationship addedrelated to 0029935
2019-03-15 11:51gitNote Added: 0082973
2019-03-15 13:52oanNote Added: 0082983
2019-03-15 13:52oanStatusnew => resolved
2019-03-15 13:52oanSteps to Reproduce Updatedbug_revision_view_page.php?rev_id=20858#r20858
2019-03-15 17:14kgvAssigned Toabv => msv
2019-03-15 18:05gitNote Added: 0083001
2019-03-15 18:07msvNote Added: 0083002
2019-03-15 18:07msvAssigned Tomsv => bugmaster
2019-03-15 18:07msvStatusresolved => reviewed
2019-03-15 19:06apnTest case number => Not needed
2019-03-15 19:06apnNote Added: 0083007
2019-03-15 19:06apnStatusreviewed => tested
2019-03-17 15:40apnChangeset attached => occt master e9fb0cba
2019-03-17 15:40apnAssigned Tobugmaster => apn
2019-03-17 15:40apnStatustested => verified
2019-03-17 15:40apnResolutionopen => fixed
2019-03-19 10:32gitNote Added: 0083075
2019-03-25 14:23kgvRelationship addedchild of 0028199
2019-09-11 11:03oanRelationship addedparent of 0030959

Notes
(0082962)
git   
2019-03-14 20:12   
Branch CR30573 has been created by oan.

SHA-1: 36a857253ab268115229f824e833d199443c7b25


Detailed log of new commits:

Author: oan
Date: Thu Mar 14 19:22:04 2019 +0300

    0030573: OSD_Parallel_TBB: limit number of execution threads using settings of OSD_ThreadPool::DefaultPool()
    
    Add tbb::task_scheduler_init to OSD_Parallel::forEach().
(0082973)
git   
2019-03-15 11:51   
Branch CR30573 has been updated forcibly by oan.

SHA-1: dc7e28d61e982adb25c4ace8c97ce3ac7d80fffb
(0082983)
oan   
2019-03-15 13:52   
Dear Andrey,

please review branch CR30573.

Test reports:
http://occt-tests/CR30573-master-OAN-OCCT/Windows-64-VC14/diff_summary.html [^]
http://occt-tests/CR30573-master-OAN-OCCT/Debian80-64/diff_summary.html [^]
(0083001)
git   
2019-03-15 18:05   
Branch CR30573 has been updated forcibly by oan.

SHA-1: 7e9925efec2dc1cc80662f6054f1b9793e3c121a
(0083002)
msv   
2019-03-15 18:07   
Reviewed.
(0083007)
apn   
2019-03-15 19:06   
Combination -
OCCT branch : CR30573
master SHA - dc7e28d61e982adb25c4ace8c97ce3ac7d80fffb
d67d4b811012eef8913d3c535c29654d0acf3c4c
Products branch : master SHA - 19cf12d4f918562ea1456aa224c6f7a64b9c4ad7
was compiled on Linux, MacOS and Windows platforms and tested in optimize mode.

Number of compiler warnings:
No new/fixed warnings

Regressions/Differences/Improvements:
No regressions/differences

CPU differences:
Debian80-64:
OCCT
Total CPU difference: 16594.050000000094 / 16599.24999999996 [-0.03%]
Products
Total CPU difference: 9122.510000000038 / 9092.71000000004 [+0.33%]
Windows-64-VC14:
OCCT
Total CPU difference: 17988.640625 / 17985.28125 [+0.02%]
Products
Total CPU difference: 10584.359375 / 10460.953125 [+1.18%]

Image differences :
No differences that require special attention

Memory differences :
No differences that require special attention
(0083075)
git   
2019-03-19 10:32   
Branch CR30573 has been deleted by inv.

SHA-1: 7e9925efec2dc1cc80662f6054f1b9793e3c121a