MantisBT - Open CASCADE
View Issue Details
0030547Open CASCADE[OCCT] OCCT:Foundation Classespublic2019-03-08 21:392019-03-19 10:33
kgv 
apn 
normalfeature 
closedfixed 
 
[OCCT] 7.4.0[OCCT] 7.4.0 
Not needed
0030547: Foundation Classes - NCollection_DoubleMap lacks Seek() method
Other NCollection map classes provide interface for checking existence and fetching value within single query - via methods Seek() returning a pointer or overloaded methods Find() assigning found value passed as second argument.

NCollection_DoubleMap is inconsistent in this context - there are no similar methods.
N/A
No tags attached.
Issue History
2019-03-08 21:39kgvNew Issue
2019-03-08 21:39kgvAssigned To => abv
2019-03-09 02:38gitNote Added: 0082794
2019-03-09 04:43kgvNote Added: 0082795
2019-03-09 04:43kgvAssigned Toabv => msv
2019-03-09 04:43kgvStatusnew => resolved
2019-03-09 15:21abvNote Added: 0082804
2019-03-09 15:28gitNote Added: 0082805
2019-03-09 15:28kgvNote Added: 0082806
2019-03-09 19:50kgvAssigned Tomsv => abv
2019-03-10 13:53abvNote Added: 0082810
2019-03-10 13:53abvAssigned Toabv => bugmaster
2019-03-10 13:53abvStatusresolved => reviewed
2019-03-11 16:18apnTest case number => Not needed
2019-03-11 16:18apnNote Added: 0082844
2019-03-11 16:18apnStatusreviewed => tested
2019-03-17 15:40apnChangeset attached => occt master af2fa459
2019-03-17 15:40apnAssigned Tobugmaster => apn
2019-03-17 15:40apnStatustested => verified
2019-03-17 15:40apnResolutionopen => fixed
2019-03-19 10:33gitNote Added: 0083088

Notes
(0082794)
git   
2019-03-09 02:38   
Branch CR30547 has been created by kgv.

SHA-1: 3cf71a4829ec60ef1c6a1578e0e0ede79018b9c5


Detailed log of new commits:

Author: kgv
Date: Sat Mar 9 02:32:11 2019 +0300

    0030547: Foundation Classes - NCollection_DoubleMap lacks Seek() method
    
    Added Seek1() and Seek2() methods to NCollection_DoubleMap class.
(0082795)
kgv   
2019-03-09 04:43   
Patch is ready for review.
(0082804)
abv   
2019-03-09 15:21   
The check for IsEmpty() in the beginning of the method Seek1() is redundant since this check is made in the initializer of the "for" cycle variable. Macro Standard_NoSuchObject_Raise_if at the beginning of methods Find1() and Find2() (those returning reference) is also redundant for the same reason.
(0082805)
git   
2019-03-09 15:28   
Branch CR30547 has been updated forcibly by kgv.

SHA-1: af75d4677f1312b7bad9b8896b092b45b5a43a3a
(0082806)
kgv   
2019-03-09 15:28   
Corrected.
(0082810)
abv   
2019-03-10 13:53   
No more remarks, please integrate. Test results are in Jenkins job CR30547-master-KGV
(0082844)
apn   
2019-03-11 16:18   
Combination -
OCCT branch : CR30547
master SHA - af75d4677f1312b7bad9b8896b092b45b5a43a3a
d67d4b811012eef8913d3c535c29654d0acf3c4c
Products branch : master SHA - 50f65bc5ba4d0133f24f5e5850620f39f60a9163
was compiled on Linux, MacOS and Windows platforms and tested in optimize mode.

Number of compiler warnings:
No new/fixed warnings

Regressions/Differences/Improvements:
No regressions/differences

CPU differences:
Debian80-64:
OCCT
Total CPU difference: 16561.69000000007 / 16562.049999999996 [-0.00%]
Products
Total CPU difference: 9087.790000000026 / 9082.700000000026 [+0.06%]
Windows-64-VC14:
OCCT
Total CPU difference: 18044.609375 / 17955.015625 [+0.50%]
Products
Total CPU difference: 10459.65625 / 10469.015625 [-0.09%]

Image differences :
No differences that require special attention

Memory differences :
No differences that require special attention
(0083088)
git   
2019-03-19 10:33   
Branch CR30547 has been deleted by inv.

SHA-1: af75d4677f1312b7bad9b8896b092b45b5a43a3a