MantisBT - Open CASCADE
View Issue Details
0030488Open CASCADE[OCCT] OCCT:Visualizationpublic2019-02-07 17:282019-04-09 16:37
kgv 
apn 
normalminor 
verifiedfixed 
[OCCT] 7.1.0 
[OCCT] 7.4.0* 
Not needed
0030488: Visualization, Ray Tracing - empty error message on GLSL program compilation
OpenGl_View::initRaytraceResources() compiles GLSL program without OpenGl_ShaderProgram::Initialize(), so that error/warning processing is handled in different way.
Due to misprints in logic and code disabled by RAY_TRACE_PRINT_INFO macros, GLSL program compilation might miss meaningful information necessary for analysis.
N/A
No tags attached.
parent of 0030643verified apn Visualization, Ray-Tracing - shader compilation errors are not properly logged 
Issue History
2019-02-07 17:28kgvNew Issue
2019-02-07 17:28kgvAssigned To => kgv
2019-02-07 17:31gitNote Added: 0082073
2019-02-08 10:28kgvNote Added: 0082079
2019-02-08 10:28kgvAssigned Tokgv => san
2019-02-08 10:28kgvStatusnew => resolved
2019-02-08 10:29kgvDescription Updatedbug_revision_view_page.php?rev_id=20642#r20642
2019-02-08 22:44gitNote Added: 0082106
2019-02-13 09:59kgvAssigned Tosan => osa
2019-02-13 10:36osaNote Added: 0082165
2019-02-13 10:36osaAssigned Toosa => bugmaster
2019-02-13 10:36osaStatusresolved => reviewed
2019-02-14 13:21apnTest case number => Not needed
2019-02-14 13:21apnNote Added: 0082178
2019-02-14 13:21apnStatusreviewed => tested
2019-02-16 11:48apnChangeset attached => occt master 2bda8346
2019-02-16 11:48apnAssigned Tobugmaster => apn
2019-02-16 11:48apnStatustested => verified
2019-02-16 11:48apnResolutionopen => fixed
2019-03-05 13:46gitNote Added: 0082642
2019-04-09 16:37kgvRelationship addedparent of 0030643

Notes
(0082073)
git   
2019-02-07 17:31   
Branch CR30488 has been created by kgv.

SHA-1: cde177c880bb0eba2e3fda2e1fdf87ac90641f4a


Detailed log of new commits:

Author: kgv
Date: Thu Feb 7 17:24:47 2019 +0300

    0030488: Visualization, Ray Tracing - empty error message on GLSL program compilation
    
    OpenGl_ShaderObject::LoadAndCompile() - added method combining Load() and Compile() with optional error logging.
    OpenGl_ShaderProgram::Link() now logs failures by default.
(0082079)
kgv   
2019-02-08 10:28   
Patch is ready for review.

http://jenkins-test-12.nnov.opencascade.com:8080/view/CR30488-CR30488-KGV/ [^]
(0082106)
git   
2019-02-08 22:44   
Branch CR30488 has been updated forcibly by kgv.

SHA-1: bc6c383b9b7006920205e477daf2e85aba040cf8
(0082165)
osa   
2019-02-13 10:36   
Branch CR30488 in OCCT and OCCT Products is reviewed without remarks.
(0082178)
apn   
2019-02-14 13:21   
OCCT and Products branches CR30488 were tested with IR-WEEK7.

Combination -
OCCT branch : IR-WEEK7
master SHA - 1ccc1371b97227ae546f586e710e61f48d1a5353
d67d4b811012eef8913d3c535c29654d0acf3c4c
Products branch : IR-WEEK7 SHA - aa8c19a87ec380c51a0864b1f3808ee6a48d4f40
was compiled on Linux, MacOS and Windows platforms and tested in optimize mode.

Number of compiler warnings:
No new/fixed warnings

Regressions/Differences/Improvements:
No regressions/differences

CPU differences:
Debian80-64:
OCCT
Total CPU difference: 16531.74000000004 / 16545.53999999999 [-0.08%]
Products
Total CPU difference: 9082.45000000002 / 9061.810000000012 [+0.23%]
Windows-64-VC14:
OCCT
Total CPU difference: 17948.90625 / 17918.46875 [+0.17%]
Products
Total CPU difference: 10463.71875 / 10465.109375 [-0.01%]

Image differences :
No differences that require special attention

Memory differences :
No differences that require special attention
(0082642)
git   
2019-03-05 13:46   
Branch CR30488 has been deleted by kgv.

SHA-1: bc6c383b9b7006920205e477daf2e85aba040cf8