MantisBT - Open CASCADE
View Issue Details
0030483Open CASCADE[OCCT] OCCT:Visualizationpublic2019-02-07 12:002019-02-16 11:48
kgv 
apn 
normalminor 
verifiedfixed 
[OCCT] 7.1.0 
[OCCT] 7.4.0* 
Not needed
0030483: Visualization, Path Tracing - make Tile Size configurable
0027607 introduced Adaptive screen space sampling within Path Tracing engine, and new parameter Graphic3d_RenderingParams::NbRayTracingTiles managing the amount of tiles for this rendering mode.

Implementation about this flag is confusing - tiles size 32x32 cannot be modified.
N/A
No tags attached.
related to 0030476verified apn Visualization, Path Tracing - Adaptive Screen Sampling leads to unstable results 
child of 0027607closed kgv Visualization - Implement adaptive screen space sampling in path tracing 
Issue History
2019-02-07 12:00kgvNew Issue
2019-02-07 12:00kgvAssigned To => kgv
2019-02-07 12:00kgvRelationship addedchild of 0027607
2019-02-07 12:00kgvProduct Version7.2.0 => 7.1.0
2019-02-07 12:00kgvRelationship addedrelated to 0030476
2019-02-07 15:49gitNote Added: 0082064
2019-02-07 15:52gitNote Added: 0082065
2019-02-07 16:05gitNote Added: 0082067
2019-02-08 20:04kgvNote Added: 0082103
2019-02-08 20:04kgvAssigned Tokgv => san
2019-02-08 20:04kgvStatusnew => resolved
2019-02-11 12:43gitNote Added: 0082120
2019-02-11 16:50kgvSummaryVisualization, Path Tracing - Graphic3d_RenderingParams::NbRayTracingTiles parameter is ignored => Visualization, Path Tracing - make Tile Size configurable
2019-02-11 16:50kgvDescription Updatedbug_revision_view_page.php?rev_id=20661#r20661
2019-02-11 16:52gitNote Added: 0082130
2019-02-11 17:21gitNote Added: 0082131
2019-02-11 17:58gitNote Added: 0082133
2019-02-12 09:32gitNote Added: 0082142
2019-02-15 17:34kgvAssigned Tosan => osa
2019-02-15 17:34osaNote Added: 0082200
2019-02-15 17:34osaAssigned Toosa => bugmaster
2019-02-15 17:34osaStatusresolved => reviewed
2019-02-16 11:47apnTest case number => Not needed
2019-02-16 11:48apnChangeset attached => occt master 66d1cdc6
2019-02-16 11:48apnAssigned Tobugmaster => apn
2019-02-16 11:48apnStatusreviewed => verified
2019-02-16 11:48apnResolutionopen => fixed

Notes
(0082064)
git   
2019-02-07 15:49   
Branch CR30483 has been created by kgv.

SHA-1: aa0d8b2fa573df6dd60f7389df24d491071ec71f


Detailed log of new commits:

Author: kgv
Date: Wed Feb 6 19:21:23 2019 +0300

    0030483: Visualization, Path Tracing - Graphic3d_RenderingParams::NbRayTracingTiles parameter is ignored
    
    OpenGl_TileSampler has been refactored to better describe its logic and solve bugs:
    - Tile size is now recomputed based on desired number of tiles instead of hard-coded number 32.
    - Offset image now defines tile index instead of offset to tile origin.
    - Added 2D array defining the number of times to sample tile for straight-forward debugging.
    
    Graphic3d_RenderingParams has been extended with properties
    RayTracingMinTileSize/RayTracingMaxTileSize for testing various tile configurations.
    
    OpenGl_View::initRaytraceResources() now relies on tile properties of OpenGl_TileSampler
    instead of computing numbers of unknown purpose / unclear logic.
    OpenGl_View::runPathtrace() has been split into two methods per rendering stage.
    
    OpenGl_Texture::Init() now returns FALSE immediately on 0 input dimensions.
    Added Image_PixMapTypedData template class allowing to work with image data of known pixel format.
(0082065)
git   
2019-02-07 15:52   
Branch CR30483 has been updated forcibly by kgv.

SHA-1: 7865871c3641a47c18e0e0edb79725cef6af3fb2
(0082067)
git   
2019-02-07 16:05   
Branch CR30483 has been updated forcibly by kgv.

SHA-1: 079cb5bf0ebdcf9bb32a7594b1b08cf8a321c976
(0082103)
kgv   
2019-02-08 20:04   
Patch is ready for review.
(0082120)
git   
2019-02-11 12:43   
Branch CR30483 has been updated forcibly by kgv.

SHA-1: 626adf22cde790a0fff33404c2ccf44848a8b994
(0082130)
git   
2019-02-11 16:52   
Branch CR30483_1 has been created by kgv.

SHA-1: 6d5a0819ecdaa3afbd6fff2eb1a085bca5c2f2d1


Detailed log of new commits:

Author: kgv
Date: Wed Feb 6 19:21:23 2019 +0300

    0030483: Visualization, Path Tracing - make Tile Size configurable
    
    OpenGl_TileSampler has been refactored to better describe its logic:
    - Offset image now defines tile index instead of offset to tile origin.
    - Added 2D array defining the number of times to sample tile for straight-forward debugging.
    
    Graphic3d_RenderingParams has been extended with property
    RayTracingTileSize for testing various tile configurations.
    Default behavior is the following:
    - Target number of tiles (e.g. upper limit per frame): 256
    - Tile size: 32x32.
    
    OpenGl_View::runPathtrace() has been split into two methods per rendering stage.
    OpenGl_Texture::Init() now returns FALSE immediately on 0 input dimensions.
    
    Added Image_PixMapTypedData template class allowing to work with image data of known pixel format.
(0082131)
git   
2019-02-11 17:21   
Branch CR30483_1 has been updated forcibly by kgv.

SHA-1: bd7e3806abb4f8344d8ecf5a22e21054c77b791a
(0082133)
git   
2019-02-11 17:58   
Branch CR30483_1 has been updated forcibly by kgv.

SHA-1: 77bcc880e3f7cc43e5d98bad4e63d065b2e81e11
(0082142)
git   
2019-02-12 09:32   
Branch CR30483_1 has been updated forcibly by kgv.

SHA-1: c3f3f5c457860cc4001ebaab29b1fb948c133f7a
(0082200)
osa   
2019-02-15 17:34   
Review without remarks