MantisBT - Open CASCADE
View Issue Details
0030478Open CASCADE[OCCT] OCCT:Foundation Classespublic2019-02-06 12:322019-03-05 13:51
kgv 
apn 
normalfeature 
closedfixed 
[OCCT] 7.2.0 
[OCCT] 7.4.0[OCCT] 7.4.0 
Not needed
0030478: Foundation Classes, NCollection_Array2 - provide Resize/Move methods consistent to NCollection_Array1
Some time ago NCollection_Array1 has been extended with new methods Move()/Resize(), but NCollection_Array2 was not updated accordingly.
N/A
No tags attached.
related to 0028470closed bugmaster Foundation Classes, NCollection_Array1 - add Resize() method for re-allocating array with new limits 
Issue History
2019-02-06 12:32kgvNew Issue
2019-02-06 12:32kgvAssigned To => abv
2019-02-06 12:35gitNote Added: 0082045
2019-02-06 12:36kgvRelationship addedrelated to 0028470
2019-02-06 12:36kgvProduct Version => 7.2.0
2019-02-08 23:47gitNote Added: 0082107
2019-02-09 00:06gitNote Added: 0082108
2019-02-09 00:18gitNote Added: 0082109
2019-02-09 01:19kgvNote Added: 0082110
2019-02-09 01:19kgvAssigned Toabv => msv
2019-02-09 01:19kgvStatusnew => resolved
2019-02-11 15:21msvNote Added: 0082125
2019-02-11 15:21msvAssigned Tomsv => kgv
2019-02-11 15:21msvStatusresolved => assigned
2019-02-11 15:26gitNote Added: 0082126
2019-02-11 15:27kgvNote Added: 0082127
2019-02-11 15:27kgvAssigned Tokgv => msv
2019-02-11 15:27kgvStatusassigned => resolved
2019-02-11 15:38msvNote Added: 0082128
2019-02-11 15:38msvAssigned Tomsv => bugmaster
2019-02-11 15:38msvStatusresolved => reviewed
2019-02-12 20:31apnTest case number => Not needed
2019-02-12 20:31apnNote Added: 0082164
2019-02-12 20:31apnStatusreviewed => tested
2019-02-16 11:48apnChangeset attached => occt master 92435cd0
2019-02-16 11:48apnAssigned Tobugmaster => apn
2019-02-16 11:48apnStatustested => verified
2019-02-16 11:48apnResolutionopen => fixed
2019-03-05 13:46gitNote Added: 0082637

Notes
(0082045)
git   
2019-02-06 12:35   
Branch CR30478 has been created by kgv.

SHA-1: 2ebe2732d4fc09ec8ce4ac226aa20b77dad425ea


Detailed log of new commits:

Author: kgv
Date: Wed Feb 6 12:29:21 2019 +0300

    0030478: Foundation Classes, NCollection_Array2 - provide Resize/Move methods consistent to NCollection_Array1
(0082107)
git   
2019-02-08 23:47   
Branch CR30478 has been updated forcibly by kgv.

SHA-1: c8eb19e72879c98eb10d862829b8c0bc0f4a42de
(0082108)
git   
2019-02-09 00:06   
Branch CR30478 has been updated forcibly by kgv.

SHA-1: 0a3b0947bad86386c864cb80b71cce425d085424
(0082109)
git   
2019-02-09 00:18   
Branch CR30478 has been updated forcibly by kgv.

SHA-1: 92dd1afd8b98995b4d11733ad09ffef50850fd6e
(0082110)
kgv   
2019-02-09 01:19   
Patch is ready for review.

http://jenkins-test-12.nnov.opencascade.com:8080/view/CR30478-master-KGV/ [^]
(0082125)
msv   
2019-02-11 15:21   
Please nullify myData in move constructor and operator move. And change comments to the method move to directly say that the input object will be invalid after move.
(0082126)
git   
2019-02-11 15:26   
Branch CR30478 has been updated forcibly by kgv.

SHA-1: 3e3832fda71f50cfb021de285982abf4eb2d8d65
(0082127)
kgv   
2019-02-11 15:27   
Please take a look into updated branch.
(0082128)
msv   
2019-02-11 15:38   
Reviewed.
(0082164)
apn   
2019-02-12 20:31   
Combination -
OCCT branch : CR30478
master SHA - 3e3832fda71f50cfb021de285982abf4eb2d8d65
d67d4b811012eef8913d3c535c29654d0acf3c4c
Products branch : CR30478 SHA - 0a8745fd49c8e6ce55c90e7f6a3c07136661ca85
was compiled on Linux, MacOS and Windows platforms and tested in optimize mode.

Number of compiler warnings:
No new/fixed warnings

Regressions/Differences/Improvements:
No regressions/differences

CPU differences:
Debian80-64:
OCCT
Total CPU difference: 16534.000000000047 / 16545.53999999999 [-0.07%]
Products
Total CPU difference: 9049.330000000036 / 9061.810000000012 [-0.14%]
Windows-64-VC14:
OCCT
Total CPU difference: 17932.265625 / 17918.46875 [+0.08%]
Products
Total CPU difference: 10460.25 / 10465.109375 [-0.05%]

Image differences :
No differences that require special attention

Memory differences :
No differences that require special attention
(0082637)
git   
2019-03-05 13:46   
Branch CR30478 has been deleted by kgv.

SHA-1: 3e3832fda71f50cfb021de285982abf4eb2d8d65