MantisBT - Open CASCADE
View Issue Details
0030456Open CASCADE[OCCT] OCCT:Configurationpublic2019-01-23 13:252019-10-23 12:04
oan 
apn 
normalminor 
verifiedfixed 
 
[OCCT] 7.5.0 
Not needed
0030456: Make OCCT_CHECK_AND_UNSET_GROUP more general
occt_macros.cmake is quite useful for OCCT-based projects.
However, it is impossible to unset group of variables with random ending due to OCCT_CHECK_AND_UNSET_GROUP accepts specific variables only (x_DIR, x_LIBRARY, etc.)

It is suggested to make it more general in order to unset all variables with specified prefix.

This can be done using the following code:
get_cmake_property(VARS VARIABLES)
string (REGEX MATCHALL "(^|;)${GROUP_NAME}[A-Za-z0-9_]*" LOCAL_RESULT "${VARS}")

No tags attached.
Issue History
2019-01-23 13:25oanNew Issue
2019-01-23 13:25oanAssigned To => bugmaster
2019-01-23 14:54bugmasterAssigned Tobugmaster => apn
2019-07-19 16:28gitNote Added: 0085796
2019-07-19 17:26apnTest case number => Not needed
2019-07-19 17:26apnNote Added: 0085808
2019-07-19 17:26apnAssigned Toapn => oan
2019-07-19 17:26apnStatusnew => resolved
2019-09-18 13:51oanNote Added: 0087251
2019-09-25 22:08abvTarget Version7.4.0 => 7.5.0
2019-10-04 12:10oanNote Added: 0087809
2019-10-04 12:10oanAssigned Tooan => apn
2019-10-04 12:10oanStatusresolved => reviewed
2019-10-04 18:22apnAssigned Toapn => bugmaster
2019-10-04 19:55apnStatusreviewed => tested
2019-10-23 01:07apnChangeset attached => occt master 620a6baa
2019-10-23 01:07apnAssigned Tobugmaster => apn
2019-10-23 01:07apnStatustested => verified
2019-10-23 01:07apnResolutionopen => fixed
2019-10-23 11:51gitNote Added: 0088458

Notes
(0085796)
git   
2019-07-19 16:28   
Branch CR30456 has been created by apn.

SHA-1: 61066a148ee5e8cbd39f21c909dfb900d19c19f2


Detailed log of new commits:

Author: apn
Date: Fri Jul 19 16:25:59 2019 +0300

    0030456: Make OCCT_CHECK_AND_UNSET_GROUP more general
    
    Modify OCCT_CHECK_AND_UNSET_GROUP function to allow unset any group of variables
(0085808)
apn   
2019-07-19 17:26   
Dear oan, could you please review occt and products branches CR30456.

Compilation was checked: http://jenkins-test-12.nnov.opencascade.com/view/CR30456-master-APN/ [^]
(0087251)
oan   
2019-09-18 13:51   
Dear Andrey,

Thanks for the update, I will check it using the first moment I will be available.

Regards,
Oleg.
(0087809)
oan   
2019-10-04 12:10   
Dear Andrey,

It works without visible regressions with OCCT native environment, I have no remarks.

Reviewed.
(0088458)
git   
2019-10-23 11:51   
Branch CR30456 has been deleted by kgv.

SHA-1: 61066a148ee5e8cbd39f21c909dfb900d19c19f2