MantisBT - Open CASCADE
View Issue Details
0030435Open CASCADE[OCCT] OCCT:Modeling Algorithmspublic2019-01-10 13:052019-03-05 17:02
ifv 
ifv 
normalminor 
assignedopen 
[OCCT] 7.4.0* 
[OCCT] 7.4.0* 
0030435: Improving performance of Approx_ComputeCLine
Algorithm, implemented in Approx_ComputeCLine (approximation of continuous parametric function) is wide used in projection algorithm.
test perf moddata bug30435
No tags attached.
related to 0027651assigned ifv Add projection support in sewing pcurves handling 
related to 0027711assigned msv Blend-on-blend corrupts the shape 
Issue History
2019-01-10 13:05ifvNew Issue
2019-01-10 13:05ifvAssigned To => ifv
2019-01-10 13:06ifvRelationship addedrelated to 0027651
2019-01-10 13:07ifvStatusnew => assigned
2019-01-10 13:11gitNote Added: 0081712
2019-01-11 15:24gitNote Added: 0081754
2019-01-15 16:48gitNote Added: 0081786
2019-01-18 16:21gitNote Added: 0081818
2019-01-21 16:22gitNote Added: 0081852
2019-01-25 16:39gitNote Added: 0081882
2019-01-28 11:58gitNote Added: 0081904
2019-01-29 17:41gitNote Added: 0081919
2019-02-05 15:23gitNote Added: 0082037
2019-02-05 17:38ifvNote Added: 0082038
2019-02-05 17:38ifvAssigned Toifv => msv
2019-02-05 17:38ifvStatusassigned => resolved
2019-02-05 17:38ifvSteps to Reproduce Updatedbug_revision_view_page.php?rev_id=20631#r20631
2019-02-08 16:44msvRelationship addedrelated to 0027711
2019-02-08 16:57msvNote Added: 0082092
2019-02-08 16:57msvAssigned Tomsv => ifv
2019-02-08 16:57msvStatusresolved => assigned
2019-02-15 16:31gitNote Added: 0082199
2019-03-05 17:02gitNote Added: 0082697

Notes
(0081712)
git   
2019-01-10 13:11   
Branch CR30435 has been created by ifv.

SHA-1: 995e77f66621cd2f9e3370ba9d59bff9f1ab5302


Detailed log of new commits:

Author: ifv
Date: Thu Jan 10 13:07:01 2019 +0300

    0030435: Improving performance of Approx_ComputeCLine
(0081754)
git   
2019-01-11 15:24   
Branch CR30435 has been updated by ifv.

SHA-1: 027e964478c09a312c5942eb06bb3e500c459ec9


Detailed log of new commits:

Author: ifv
Date: Fri Jan 11 15:20:17 2019 +0300

    Fix regression 1

(0081786)
git   
2019-01-15 16:48   
Branch CR30435 has been updated forcibly by ifv.

SHA-1: 886844df71a7c4b3920fbd46520917aae331b4e4
(0081818)
git   
2019-01-18 16:21   
Branch CR30435 has been updated by ifv.

SHA-1: 00494f92e2ea7a98370de5f6c580abae58eccc15


Detailed log of new commits:

Author: ifv
Date: Fri Jan 18 16:14:56 2019 +0300

    Fix for performance problems (boolean volumemaker E4, E5, E6)

(0081852)
git   
2019-01-21 16:22   
Branch CR30435 has been updated by ifv.

SHA-1: adb7a48a2e5b314c383f3ec7d0aedb94d9b36acd


Detailed log of new commits:

Author: ifv
Date: Mon Jan 21 16:17:08 2019 +0300

    Fix for boolean volumemaker E6

Author: ifv
Date: Mon Jan 21 09:36:18 2019 +0300

    Revert "Fix for performance problems (boolean volumemaker E4, E5, E6)"
    
    This reverts commit 00494f92e2ea7a98370de5f6c580abae58eccc15.

(0081882)
git   
2019-01-25 16:39   
Branch CR30435 has been updated by ifv.

SHA-1: aa63e31beb706d6a860bbe8776bbee4c091ced70


Detailed log of new commits:

Author: ifv
Date: Fri Jan 25 16:32:58 2019 +0300

    Fix some bugs

(0081904)
git   
2019-01-28 11:58   
Branch CR30435 has been updated forcibly by ifv.

SHA-1: 1c9b639ff29a80171ffbf33b2d2d020b4c2d8b51
(0081919)
git   
2019-01-29 17:41   
Branch CR30435 has been updated forcibly by ifv.

SHA-1: 83cd458533ce0b45ee24dc5586c60c2aa25e6188
(0082037)
git   
2019-02-05 15:23   
Branch CR30435 has been updated forcibly by ifv.

SHA-1: c7e3522a5d38505f71227db84a1bee0b2f9700c5
(0082038)
ifv   
2019-02-05 17:38   
Branch CR300435 is ready for review

See CR30435-master-IFV for test results
(0082092)
msv   
2019-02-08 16:57   
src/Approx/Approx_ComputeCLine.gxx
- 414: incorrect comment
- 312: it seems must be "deg == mydegremin"

src/Approx/Approx_FitAndDivide.hxx
- 67: Actually myInvOrder is true by default, it is worth to tell it here.

src/IntTools/IntTools_EdgeEdge.cxx
- 228: please add comment for this code (copy from commit).

tests/perf/moddata/bug30435
- Put bug title along with its number.

tests/lowalgos/intss/bug27263
- Add check of length of the second curve.

What is the performance gain of this fix. Can you give some figures?
(0082199)
git   
2019-02-15 16:31   
Branch CR30435 has been updated forcibly by ifv.

SHA-1: c88524a3c114f34c196f4b4e843f722a5ef47269
(0082697)
git   
2019-03-05 17:02   
Branch CR30435 has been updated forcibly by ifv.

SHA-1: a12d40a5d15023fc4085fad1e8d9e1620d46c514