MantisBT - Open CASCADE
View Issue Details
0030428Open CASCADE[OCCT] OCCT:Modeling Algorithmspublic2018-12-29 15:032019-01-12 14:42
kgv 
bugmaster 
normaltrivial 
verifiedfixed 
[OCCT] 7.3.0 
[OCCT] 7.4.0* 
Not needed
0030428: Modeling Algorithms - BRepBndLib::AddOBB() throws exception on empty Compound
Calling BRepBndLib::AddOBB() on empty Compound leads to unhandled exception due to intermediate Bnd_Box result is not checked for IsVoid().
pload MODELING
compound c
bounding c
# OK
bounding -obb c
# ** Exception ** 00000155170C33F0 : Standard_ConstructionError: Bnd_Box is void
No tags attached.
Issue History
2018-12-29 15:03kgvNew Issue
2018-12-29 15:03kgvAssigned To => msv
2018-12-29 15:04kgvRelationship addedchild of 0029311
2018-12-29 15:45gitNote Added: 0081653
2018-12-29 15:45kgvNote Added: 0081654
2018-12-29 15:45kgvSeverityminor => trivial
2018-12-29 15:45kgvStatusnew => resolved
2018-12-30 14:58gitNote Added: 0081657
2019-01-09 10:05msvNote Added: 0081686
2019-01-09 10:05msvAssigned Tomsv => bugmaster
2019-01-09 10:05msvStatusresolved => feedback
2019-01-09 10:27gitNote Added: 0081687
2019-01-09 17:43bugmasterStatusfeedback => reviewed
2019-01-10 17:58bugmasterTest case number => Not needed
2019-01-11 10:32bugmasterNote Added: 0081745
2019-01-11 10:32bugmasterStatusreviewed => tested
2019-01-11 10:33bugmasterNote Edited: 0081745bug_revision_view_page.php?bugnote_id=81745#r20541
2019-01-12 14:34bugmasterChangeset attached => occt master 0939d4cf
2019-01-12 14:34bugmasterStatustested => verified
2019-01-12 14:34bugmasterResolutionopen => fixed
2019-01-12 14:42gitNote Added: 0081768

Notes
(0081653)
git   
2018-12-29 15:45   
Branch CR30428 has been created by kgv.

SHA-1: 20f20f99f996aa80430e9f47fafba5d2a2492c11


Detailed log of new commits:

Author: kgv
Date: Sat Dec 29 15:41:54 2018 +0300

    0030428: Modeling Algorithms - BRepBndLib::AddOBB() throws exception on empty Compound
    
    Added missing Bnd_Box::IsVoid() check.
(0081654)
kgv   
2018-12-29 15:45   
Trivial patch is ready for review.
(0081657)
git   
2018-12-30 14:58   
Branch CR30428 has been deleted by inv.

SHA-1: 20f20f99f996aa80430e9f47fafba5d2a2492c11
(0081686)
msv   
2019-01-09 10:05   
I have reviewed the branch. It was OK.
Why it was removed?
(0081687)
git   
2019-01-09 10:27   
Branch CR30428 has been created by kgv.

SHA-1: 20f20f99f996aa80430e9f47fafba5d2a2492c11


Detailed log of new commits:

Author: kgv
Date: Sat Dec 29 15:41:54 2018 +0300

    0030428: Modeling Algorithms - BRepBndLib::AddOBB() throws exception on empty Compound
    
    Added missing Bnd_Box::IsVoid() check.
(0081745)
bugmaster   
2019-01-11 10:32   
(edited on: 2019-01-11 10:33)
Fix has been tested in framework of WEEK-2:

Combination -
OCCT branch : WEEK-2 SHA - e86ab0bbd895a6609d2b948088ffe4f46e3a5f64
Products branch : WEEK-2 SHA - 0b9df64a156abd5cbfbfccb15967b46cdabfe1f8
was compiled on Linux, MacOS and Windows platforms and tested in optimize mode.

Number of compiler warnings:
No new/fixed warnings

Regressions/Differences/Improvements:
No regressions/differences

CPU differences:
Debian80-64:
OCCT
Total CPU difference: 16371.970000000036 / 16388.860000000008 [-0.10%]
Products
Total CPU difference: 7159.450000000021 / 7172.62000000003 [-0.18%]
Windows-64-VC14:
OCCT
Total CPU difference: 17753.953125 / 17753.9375 [+0.00%]
Products
Total CPU difference: 8592.859375 / 8592.53125 [+0.00%]


Image differences :
No differences that require special attention

Memory differences :
No differences that require special attention

(0081768)
git   
2019-01-12 14:42   
Branch CR30428 has been deleted by inv.

SHA-1: 20f20f99f996aa80430e9f47fafba5d2a2492c11