MantisBT - Open CASCADE
View Issue Details
0030416Open CASCADE[OCCT] OCCT:Foundation Classespublic2018-12-17 15:142018-12-30 14:46
msv 
msv 
normalminor 
verifiedfixed 
[OCCT] 7.3.0 
[OCCT] 7.4.0* 
Not needed
0030416: Incorrect implementation of the method Bnd_OBB::SquareExtent
Implementation of the method Bnd_OBB::SquareExtent is the following:
  //! Returns square diagonal of this box
  Standard_Real SquareExtent() const
  {
    return (4.0*myHDims[0] * myHDims[0] + 
            myHDims[1] * myHDims[1] +
            myHDims[1] * myHDims[1]);
  }

It must be as this:
  //! Returns square diagonal of this box
  Standard_Real SquareExtent() const
  {
    return 4.0 * (myHDims[0] * myHDims[0] + 
                  myHDims[1] * myHDims[1] +
                  myHDims[2] * myHDims[2]);
  }

N/A
No tags attached.
Issue History
2018-12-17 15:14msvNew Issue
2018-12-17 15:14msvAssigned To => abv
2018-12-17 15:16msvNote Added: 0081539
2018-12-17 15:19gitNote Added: 0081540
2018-12-17 15:23msvAssigned Toabv => msv
2018-12-17 15:23msvStatusnew => assigned
2018-12-17 17:10msvNote Added: 0081541
2018-12-17 17:10msvNote Added: 0081542
2018-12-17 17:10msvAssigned Tomsv => emv
2018-12-17 17:10msvStatusassigned => resolved
2018-12-17 17:10msvSteps to Reproduce Updatedbug_revision_view_page.php?rev_id=20495#r20495
2018-12-18 09:54emvNote Added: 0081544
2018-12-18 09:54emvAssigned Toemv => bugmaster
2018-12-18 09:54emvStatusresolved => reviewed
2018-12-18 11:28apnTest case number => Not needed
2018-12-18 11:28apnNote Added: 0081550
2018-12-18 11:28apnStatusreviewed => tested
2018-12-22 14:32msvChangeset attached => occt master 4b97f9b1
2018-12-22 14:32msvAssigned Tobugmaster => msv
2018-12-22 14:32msvStatustested => verified
2018-12-22 14:32msvResolutionopen => fixed
2018-12-23 12:57kgvRelationship addedchild of 0029311
2018-12-30 14:46gitNote Added: 0081656

Notes
(0081539)
msv   
2018-12-17 15:16   
This method has not been used yet anywhere in OCCT.
(0081540)
git   
2018-12-17 15:19   
Branch CR30416 has been created by msv.

SHA-1: 4b97f9b15b9ee39466ad827ec9f28688d893365d


Detailed log of new commits:

Author: msv
Date: Mon Dec 17 15:16:55 2018 +0300

    0030416: Incorrect implementation of the method Bnd_OBB::SquareExtent
    
    The method Bnd_OBB::SquareExtent has been corrected.
(0081541)
msv   
2018-12-17 17:10   
Test results are here http://jenkins-test-12.nnov.opencascade.com/view/CR30416-master-msv/view/COMPARE/ [^]
(0081542)
msv   
2018-12-17 17:10   
Please review.
(0081544)
emv   
2018-12-18 09:54   
Reviewed.
(0081550)
apn   
2018-12-18 11:28   
Combination -
OCCT branch : CR30416 SHA - 4b97f9b15b9ee39466ad827ec9f28688d893365d
Products branch : master SHA - 4b92b1495aa4777a767cfbc88afc00a4e9fb1b5f
was compiled on Linux, MacOS and Windows platforms and tested in optimize mode.

Number of compiler warnings:
No new/fixed warnings

Regressions/Differences/Improvements:
No regressions/differences

CPU differences:
Debian80-64:
OCCT
Total CPU difference: 16356.83000000011 / 16383.840000000093 [-0.16%]
Products
Total CPU difference: 7158.5100000000375 / 7155.460000000033 [+0.04%]
Windows-64-VC14:
OCCT
Total CPU difference: 17769.03125 / 17743.1875 [+0.15%]
Products
Total CPU difference: 8580.78125 / 8599.515625 [-0.22%]

Image differences :
No differences that require special attention

Memory differences :
No differences that require special attention
(0081656)
git   
2018-12-30 14:46   
Branch CR30416 has been deleted by inv.

SHA-1: 4b97f9b15b9ee39466ad827ec9f28688d893365d