MantisBT - Community
View Issue Details
0030396Community[OCCT] OCCT:Shape Healingpublic2018-12-05 19:402018-12-24 11:02
aothms 
gka 
normalcrash 
assignedopen 
VC++ 2017 64bitWindows10
 
 
bugs modalg_7 bug30396_1, bug30396_2
0030396: Infinite recursion during ShapeFix after BRepAlgoAPI_Cut
Attached is zip file with a cpp file and 7 shape serializations.

The cpp file loads a couple arguments for a boolean operation. A subsequent call to ShapeFix_Shape results in an infinite recursion.

The odd thing is that if the order in which the shapes are added to the list is changed (this order is also included in a code comment) the boolean op and shapefix call succeed and a visually correct result is obtained.
restore [locate_data_file bug30396.brep] a
explode a

bfuzzyvalue 1e-2
bnondestructive 1
bclearobjects
bcleartools
baddobjects a_1
baddtools a_2 a_3 a_4 a_5 a_6 a_7
bfillds
bbop r 2

checknbshapes r -solid 1 -shell 1
checkshape r
# checkshape reports errors in version 7.3.0,
# and it is OK with current master

fixshape r1 r
# fixshape hangs on a couple of seconds and crashes the application,
# if result is get from the version 7.3.0
No tags attached.
zip ifcopenshell_511.zip (6,704) 2018-12-05 19:40
https://tracker.dev.opencascade.org/
Issue History
2018-12-05 19:40aothmsNew Issue
2018-12-05 19:40aothmsAssigned To => msv
2018-12-05 19:40aothmsFile Added: ifcopenshell_511.zip
2018-12-20 17:19gitNote Added: 0081578
2018-12-20 17:22msvStatusnew => assigned
2018-12-20 17:24msvNote Added: 0081579
2018-12-20 17:56msvNote Added: 0081581
2018-12-20 17:56msvAssigned Tomsv => emv
2018-12-20 17:56msvStatusassigned => feedback
2018-12-21 11:54emvNote Added: 0081583
2018-12-21 11:54emvAssigned Toemv => msv
2018-12-21 11:54emvStatusfeedback => assigned
2018-12-21 15:44gitNote Added: 0081592
2018-12-21 16:47msvNote Added: 0081593
2018-12-21 16:47msvStatusassigned => resolved
2018-12-21 16:47msvSteps to Reproduce Updatedbug_revision_view_page.php?rev_id=20501#r20501
2018-12-21 16:48msvNote Added: 0081594
2018-12-21 16:48msvAssigned Tomsv => bugmaster
2018-12-21 16:48msvStatusresolved => reviewed
2018-12-21 16:51apnTest case number => bugs modalg_7 bug30396_1, bug30396_2
2018-12-21 16:51apnStatusreviewed => tested
2018-12-22 14:32apnChangeset attached => occt master 4473e336
2018-12-22 14:32apnAssigned Tobugmaster => apn
2018-12-22 14:32apnStatustested => verified
2018-12-22 14:32apnResolutionopen => fixed
2018-12-22 14:35apnAssigned Toapn => msv
2018-12-22 14:35apnStatusverified => closed
2018-12-22 14:35apnResolutionfixed => open
2018-12-22 14:35apnStatusclosed => assigned
2018-12-24 11:01msvSteps to Reproduce Updatedbug_revision_view_page.php?rev_id=20502#r20502
2018-12-24 11:02msvAssigned Tomsv => gka
2018-12-24 11:02msvCategoryOCCT:Modeling Algorithms => OCCT:Shape Healing

Notes
(0081578)
git   
2018-12-20 17:19   
Branch CR30396 has been created by msv.

SHA-1: 1b25c97fbc79b97d526440cc2ebd07375819b003


Detailed log of new commits:

Author: msv
Date: Thu Dec 20 17:10:00 2018 +0300

    Test for 0030396: Infinite recursion during ShapeFix after BRepAlgoAPI_Cut
    
    Two test cases are added. One for Boolean operation (it is good, because BO has been fixed already), and another for fixshape operation (it causes Draw crash).
(0081579)
msv   
2018-12-20 17:24   
The bug with BO is not reproduced in the master version.
However, the shape produced by the version 7.3 still crashes application during fixshape operation.
(0081581)
msv   
2018-12-20 17:56   
New test scripts have been created and pushed to the branch CR30396.

Dear Eugeny, please review the branch.

Results of new test scripts are here:
http://jenkins-test-12.nnov.opencascade.com/view/CR30396-master-msv/view/TESTING/job/CR30396-master-msv-OCCT-Debian80-64-opt-test-restart/HTML_20Report/ [^]
http://jenkins-test-12.nnov.opencascade.com/view/CR30396-master-msv/view/TESTING/job/CR30396-master-msv-OCCT-Windows-64-VC14-opt-test-restart/HTML_20Report/ [^]

Please do not close the bug after integration of the tests.
(0081583)
emv   
2018-12-21 11:54   
tests/bugs/modalg_7/bug30396_1:
- Please add checks for the area and volume properties of the result shapes.
- When operations complete, reset the options (fuzzy and safe mode) to default state.
- It will also be good to check other types of boolean operations in the same script.
(0081592)
git   
2018-12-21 15:44   
Branch CR30396 has been updated by msv.

SHA-1: a6e65fe79f4a042a079193eb74ee228edf7aa830


Detailed log of new commits:

Author: msv
Date: Fri Dec 21 15:41:55 2018 +0300

    #correction following remarks

(0081593)
msv   
2018-12-21 16:47   
Remarks have been considered.
(0081594)
msv   
2018-12-21 16:48   
Please integrate and then assign again to me.