MantisBT - Open CASCADE
View Issue Details
0030366Open CASCADE[OCCT] OCCT:Codingpublic2018-11-13 09:522019-03-05 13:46
nbv 
bugmaster 
normaltrivial 
verifiedfixed 
[OCCT] 5.0.0 
[OCCT] 7.4.0* 
Not needed
0030366: Coding Rules - GeometryTest_API2dCommands.cxx seems to be excess
Currently the file GeometryTest_API2dCommands.cxx defines some DRAW-commands. However, names of these commands are duplicate of analogical commands in the file GeomliteTest_API2dCommands.cxx, which are actively used by current OCCT-version.

So, is the file GeometryTest_API2dCommands.cxx really usefull?

P.S.

Please note, that calling of the method GeometryTest::API2dCommands(...) is commented in the file GeometryTest.cxx.
No tags attached.
has duplicate 0029679new msv Community Repeated registration commands(2dapprox), and will wrong when 2dapprox result nbpoint x1 y1 x2 y2 ... 
Issue History
2018-11-13 09:52nbvNew Issue
2018-11-13 09:52nbvAssigned To => kgv
2019-02-01 17:26kgvRelationship addedrelated to 0028631
2019-02-01 17:46kgvRelationship deletedrelated to 0028631
2019-02-01 17:46kgvSummaryThe file GeometryTest_API2dCommands.cxx seems to be excess => Coding Rules - The file GeometryTest_API2dCommands.cxx seems to be excess
2019-02-01 17:47kgvSummaryCoding Rules - The file GeometryTest_API2dCommands.cxx seems to be excess => Coding Rules - GeometryTest_API2dCommands.cxx seems to be excess
2019-02-01 17:47kgvProduct Version => 5.0.0
2019-02-01 17:49kgvNote Added: 0081992
2019-02-01 17:54gitNote Added: 0081993
2019-02-01 17:55kgvNote Added: 0081994
2019-02-01 17:55kgvAssigned Tokgv => bugmaster
2019-02-01 17:55kgvSeverityminor => trivial
2019-02-01 17:55kgvStatusnew => resolved
2019-02-01 17:55kgvStatusresolved => reviewed
2019-02-01 17:56kgvNote Edited: 0081992bug_revision_view_page.php?bugnote_id=81992#r20624
2019-02-04 15:08bugmasterTest case number => Not needed
2019-02-05 14:05bugmasterNote Added: 0082036
2019-02-05 14:05bugmasterStatusreviewed => tested
2019-02-10 19:36bugmasterChangeset attached => occt master 98ae54f7
2019-02-10 19:36bugmasterStatustested => verified
2019-02-10 19:36bugmasterResolutionopen => fixed
2019-03-02 22:47kgvRelationship addedhas duplicate 0029679
2019-03-05 13:46gitNote Added: 0082626

Notes
(0081992)
kgv   
2019-02-01 17:49   
(edited on: 2019-02-01 17:56)
This change was introduced in '1997.
> jpi 09/06/97 utilisation des commandes de GeomliteTest

(0081993)
git   
2019-02-01 17:54   
Branch CR30366 has been created by kgv.

SHA-1: 1d574a318db6f63de8f588c398c09c3642c57bb5


Detailed log of new commits:

Author: kgv
Date: Fri Feb 1 17:49:08 2019 +0300

    0030366: Coding Rules - GeometryTest_API2dCommands.cxx seems to be excess
(0081994)
kgv   
2019-02-01 17:55   
Please take trivial patch.
(0082036)
bugmaster   
2019-02-05 14:05   
tested in framework WEEK-6 branch


Combination -
OCCT branch : WEEK-6 SHA - 95c882e9d45466a9e296f33fb6a10289cf40332f
Products branch : WEEK-6 SHA - 72707298a0e5543f74709bf9d0186c8b8960ca25
was compiled on Linux, MacOS and Windows platforms and tested in optimize mode.

Number of compiler warnings:
No new/fixed warnings

Regressions/Differences/Improvements:
No regressions/differences

CPU differences:
Debian80-64:
OCCT
Total CPU difference: 16368.269999999928 / 16363.790000000015 [+0.03%]
Products
Total CPU difference: 7176.410000000036 / 7177.480000000016 [-0.01%]
Windows-64-VC14:
OCCT
Total CPU difference: 17772.359375 / 17773.921875 [-0.01%]
Products
Total CPU difference: 8601.046875 / 8604.828125 [-0.04%]


Image differences :
No differences that require special attention

Memory differences :
No differences that require special attention
(0082626)
git   
2019-03-05 13:46   
Branch CR30366 has been deleted by kgv.

SHA-1: 1d574a318db6f63de8f588c398c09c3642c57bb5