MantisBT - Open CASCADE
View Issue Details
0030329Open CASCADE[OCCT] OCCT:Foundation Classespublic2018-11-01 16:252019-02-10 19:36
nbv 
bugmaster 
normalminor 
verifiedfixed 
[OCCT] 7.4.0* 
[OCCT] 7.4.0* 
Not needed
0030329: Move BRepMesh_IncAllocator to NCollection package
BRepMesh_IncAllocator is thread safe (in difference with NCollection_IncAllocator). Nevertheless, it must be placed in NCollection package.
No tags attached.
child of 0026106verified bugmaster BRepMesh - revision of data model 
Issue History
2018-11-01 16:25nbvNew Issue
2018-11-01 16:25nbvAssigned To => oan
2018-11-01 16:25nbvRelationship addedchild of 0026106
2018-11-01 16:36msvAssigned Tooan => kgv
2018-11-01 16:36msvCategoryOCCT:Mesh => OCCT:Foundation Classes
2019-02-04 12:25gitNote Added: 0082005
2019-02-04 13:49gitNote Added: 0082020
2019-02-04 15:44kgvNote Added: 0082023
2019-02-04 15:44kgvAssigned Tokgv => msv
2019-02-04 15:44kgvStatusnew => resolved
2019-02-04 15:44kgvProduct Version => 7.4.0*
2019-02-04 17:33msvNote Added: 0082029
2019-02-04 17:33msvAssigned Tomsv => bugmaster
2019-02-04 17:33msvStatusresolved => reviewed
2019-02-04 17:46bugmasterTest case number => Not needed
2019-02-04 17:50bugmasterNote Added: 0082030
2019-02-04 17:50bugmasterStatusreviewed => tested
2019-02-10 19:36bugmasterChangeset attached => occt master 95c882e9
2019-02-10 19:36bugmasterStatustested => verified
2019-02-10 19:36bugmasterResolutionopen => fixed

Notes
(0082005)
git   
2019-02-04 12:25   
Branch CR30329 has been created by kgv.

SHA-1: 1407b7178c37ad99dddebda28cf9b26fad38d69f


Detailed log of new commits:

Author: kgv
Date: Mon Feb 4 12:21:14 2019 +0300

    0030329: Move BRepMesh_IncAllocator to NCollection package
    
    NCollection_IncAllocator constructor has been extended with optional mutex allocation (disabled by default).
(0082020)
git   
2019-02-04 13:49   
Branch CR30329_1 has been created by kgv.

SHA-1: d8e83b26e1880aa8f419c68a9574ee12494e085b


Detailed log of new commits:

Author: kgv
Date: Mon Feb 4 12:21:14 2019 +0300

    0030329: Move BRepMesh_IncAllocator to NCollection package
    
    NCollection_IncAllocator has been extended with optional mutex allocation (disabled by default).
(0082023)
kgv   
2019-02-04 15:44   
Patch is ready for review.

http://jenkins-test-12.nnov.opencascade.com:8080/view/CR30329_1-master-KGV [^]
(0082029)
msv   
2019-02-04 17:33   
Reviewed.
(0082030)
bugmaster   
2019-02-04 17:50   
Combination -
OCCT branch : CR30329_1 SHA - d8e83b26e1880aa8f419c68a9574ee12494e085b
Products branch : master SHA - 9aa25f353abc3855a46a51135af99c115d17b709
was compiled on Linux, MacOS and Windows platforms and tested in optimize mode.

Number of compiler warnings:
No new/fixed warnings

Regressions/Differences/Improvements:
No regressions/differences

CPU differences:
Debian80-64:
OCCT
Total CPU difference: 16378.389999999967 / 16366.799999999954 [+0.07%]
Products
Total CPU difference: 7176.760000000028 / 7183.99000000004 [-0.10%]
Windows-64-VC14:
OCCT
Total CPU difference: 17811.953125 / 17810.03125 [+0.01%]
Products
Total CPU difference: 8617.234375 / 8589.015625 [+0.33%]


Image differences :
No differences that require special attention

Memory differences :
No differences that require special attention