MantisBT - Open CASCADE
View Issue Details
0030239Open CASCADE[OCCT] OCCT:Visualizationpublic2018-10-14 13:582018-12-13 12:13
kgv 
apn 
normalintegration request 
verifiedfixed 
 
[OCCT] 7.4.0* 
Not needed
0030239: Visualization, Graphic3d_ArrayOfPrimitives - pass Graphic3d_ArrayFlags bitmask instead of dedicated Boolean flags to constructor
Currently primitive array constructors take dedicated Boolean flags for requesting vertex attributes like Normals, Colors, Texels.

This makes syntax confusing, because there is too many flags in constructors and their order is not straightforward.

It is proposed replacing Boolean flags with a single bitmask argument.
N/A
No tags attached.
Issue History
2018-10-14 13:58kgvNew Issue
2018-10-14 13:58kgvAssigned To => kgv
2018-10-14 14:49gitNote Added: 0079945
2018-10-15 14:21kgvRelationship addedrelated to 0030076
2018-10-15 23:49gitNote Added: 0079979
2018-10-15 23:51gitNote Added: 0079981
2018-10-15 23:54kgvNote Added: 0079983
2018-10-15 23:54kgvAssigned Tokgv => bugmaster
2018-10-15 23:54kgvStatusnew => resolved
2018-10-15 23:54kgvStatusresolved => reviewed
2018-10-16 22:29apnTest case number => Not needed
2018-10-16 22:29apnNote Added: 0080032
2018-10-16 22:29apnStatusreviewed => tested
2018-10-21 20:16apnChangeset attached => occt master 34253146
2018-10-21 20:16apnAssigned Tobugmaster => apn
2018-10-21 20:16apnStatustested => verified
2018-10-21 20:16apnResolutionopen => fixed
2018-10-22 11:52gitNote Added: 0080177
2018-12-06 12:40abaRelationship addedrelated to 0030358
2018-12-13 12:13kgvRelationship replacedparent of 0030358

Notes
(0079945)
git   
2018-10-14 14:49   
Branch CR30239 has been created by kgv.

SHA-1: a50f98447d751092470e6411e8cd7bf5fdcdffef


Detailed log of new commits:

Author: kgv
Date: Sun Oct 14 14:00:46 2018 +0300

    0030239: Visualization, Graphic3d_ArrayOfPrimitives - pass Graphic3d_ArrayFlags bitmask instead of dedicated Boolean flags to constructor
(0079979)
git   
2018-10-15 23:49   
Branch CR30239 has been updated forcibly by kgv.

SHA-1: 187a5cf637ff4703b941f8a4949d221dcb0ba08b
(0079981)
git   
2018-10-15 23:51   
Branch CR30239 has been updated forcibly by kgv.

SHA-1: 06113ca08cd6cde0c94a5bd05717f207a81fd338
(0079983)
kgv   
2018-10-15 23:54   
Please take the patch.
(0080032)
apn   
2018-10-16 22:29   
Combination -
OCCT branch : CR30239 SHA - a50f98447d751092470e6411e8cd7bf5fdcdffef
Products branch : CR30239 SHA - 38277e384d6ac06b5184c98ab1ed007a2c2eb56d
was compiled on Linux, MacOS and Windows platforms and tested in optimize mode.

Number of compiler warnings:
No new/fixed warnings

Regressions/Differences/Improvements:
No regressions/differences

CPU differences:
Debian80-64:
OCCT
Total CPU difference: 17507.10999999992 / 17553.839999999873 [-0.27%]
Products
Total CPU difference: 7446.830000000072 / 7416.290000000055 [+0.41%]
Windows-64-VC14:
OCCT
Total CPU difference: 17568.193015898425 / 17582.732309098545 [-0.08%]
Products
Total CPU difference: 8354.961157099993 / 8362.40240479998 [-0.09%]

Image differences :
No differences that require special attention

Memory differences :
No differences that require special attention
(0080177)
git   
2018-10-22 11:52   
Branch CR30239 has been deleted by inv.

SHA-1: 06113ca08cd6cde0c94a5bd05717f207a81fd338