MantisBT - Open CASCADE
View Issue Details
0030225Open CASCADE[OCCT] PRODUCTS:Point Cloud Renderingpublic2018-10-09 18:512018-11-04 14:12
gka 
bugmaster 
normalminor 
verifiedfixed 
[OCCT] 7.3.0 
[OCCT] 7.4.0 
Not needed
0030225: Point Cloud Rendering - diffuse_red/diffuse_green/diffuse_blue are not read from PLY file
Colors of the points are not read from ply file for case when names of properties defining colors are specified as "diffuse_red", "diffuse_green", "diffuse_blue".
N/A
No tags attached.
Issue History
2018-10-09 18:51gkaNew Issue
2018-10-09 18:51gkaAssigned To => gka
2018-10-09 18:51gkaDescription Updatedbug_revision_view_page.php?rev_id=20102#r20102
2018-10-10 15:56kgvSummaryColors of the points are not read from ply file. => Point Cloud Rendering - Colors of the points are not read from ply file
2018-10-10 16:03kgvNote Added: 0079856
2018-10-10 16:03kgvNote Edited: 0079856bug_revision_view_page.php?bugnote_id=79856#r20108
2018-10-10 16:03kgvNote Edited: 0079856bug_revision_view_page.php?bugnote_id=79856#r20109
2018-10-31 08:09kgvSummaryPoint Cloud Rendering - Colors of the points are not read from ply file => Point Cloud Rendering - diffuse_red/diffuse_green/diffuse_blue are not read from PLY file
2018-10-31 09:28kgvNote Added: 0080541
2018-10-31 09:28kgvAssigned Togka => bugmaster
2018-10-31 09:28kgvStatusnew => resolved
2018-10-31 09:28kgvStatusresolved => reviewed
2018-10-31 09:28kgvSteps to Reproduce Updatedbug_revision_view_page.php?rev_id=20259#r20259
2018-10-31 15:14bugmasterNote Added: 0080553
2018-10-31 15:14bugmasterStatusreviewed => tested
2018-11-04 13:03bugmasterNote Added: 0080673
2018-11-04 13:03bugmasterStatustested => verified
2018-11-04 13:03bugmasterResolutionopen => fixed
2018-11-04 14:12bugmasterTest case number => Not needed

Notes
(0079856)
kgv   
2018-10-10 16:03   
+    TCollection_AsciiString aPropName(aPropNameRaw);
+
+    Standard_Integer indColor = (aPropName.Search("red") >= 0 ? 0 : (aPropName.Search("green") 
>= 0 ? 1 :
+      aPropName.Search("blue") >=0 ? 2 : -1));

I don't see a rationale for complicating code by looking for arbitrary properties with "red", "blue" and "green" in their name.

In practice, only two schemes are used for storing per-node color
(apart from awkward texture mapping) in PLY:
- "red", "green", "blue", "alpha"
- "diffuse_red", "diffuse_green", "diffuse_blue", "diffuse_alpha"

(0080541)
kgv   
2018-10-31 09:28   
Please take the patch.

http://jenkins-test-12.nnov.opencascade.com:8080/view/master-CR30225_1-KGV/ [^]
(0080553)
bugmaster   
2018-10-31 15:14   
Combination -
OCCT branch : master
Products branch : CR30225_1 SHA - 3e98c4d40d8d6882a368b3f9e26306ec76508f07
was compiled on Linux, MacOS and Windows platforms and tested in optimize mode.

Number of compiler warnings:
No new/fixed warnings

Regressions/Differences/Improvements:
No regressions/differences

CPU differences:
Debian80-64:
OCCT
---
Products
Total CPU difference: 7086.800000000021 / 7077.76000000003 [+0.13%]
Windows-64-VC14:
OCCT
---
Products
Total CPU difference: 8530.984375 / 8596.328125 [-0.76%]


Image differences :
No differences that require special attention

Memory differences :
No differences that require special attention
(0080673)
bugmaster   
2018-11-04 13:03   
Fix has been integrated into master of occt-products repository