MantisBT - Open CASCADE
View Issue Details
0030180Open CASCADE[OCCT] OCCT:Data Exchangepublic2018-09-30 22:212019-09-29 12:36
kgv 
bugmaster 
normalminor 
closedfixed 
[OCCT] 7.3.0 
[OCCT] 7.4.0[OCCT] 7.4.0 
Not required
0030180: Data Exchange - VrmlAPI_Writer is expected to return export state
For some reason, VrmlAPI_Writer::WriteDoc(), ::Write() do not return export state in any way.
If file cannot be opened, writer just does not perform any action.

This doesn't look like a robust API.
Not required
No tags attached.
related to 0030115closed bugmaster Data Exchange - Implementation of import from XCAF to VRML. 
Issue History
2018-09-30 22:21kgvNew Issue
2018-09-30 22:21kgvAssigned To => gka
2018-09-30 22:21kgvAssigned Togka => ski
2018-09-30 22:21kgvStatusnew => assigned
2018-09-30 22:21kgvRelationship addedrelated to 0030115
2018-09-30 22:21kgvAssigned Toski => skl
2018-09-30 22:22kgvDescription Updatedbug_revision_view_page.php?rev_id=20008#r20008
2019-09-04 15:36abvTarget Version7.4.0 => 7.5.0
2019-09-04 16:10kgvAssigned Toskl => user897
2019-09-16 15:52gitNote Added: 0087142
2019-09-16 15:54user897Note Added: 0087143
2019-09-16 15:54user897Assigned Touser897 => osa
2019-09-16 15:54user897Statusassigned => resolved
2019-09-16 15:54user897Steps to Reproduce Updatedbug_revision_view_page.php?rev_id=21835#r21835
2019-09-16 16:12kgvTarget Version7.5.0 => 7.4.0
2019-09-16 16:59osaNote Added: 0087157
2019-09-16 16:59osaAssigned Toosa => user897
2019-09-16 16:59osaStatusresolved => assigned
2019-09-17 17:00gitNote Added: 0087207
2019-09-17 17:03gitNote Added: 0087208
2019-09-17 17:05user897Note Added: 0087209
2019-09-17 17:05user897Assigned Touser897 => osa
2019-09-17 17:05user897Statusassigned => resolved
2019-09-18 14:13osaNote Added: 0087252
2019-09-19 14:26gitNote Added: 0087303
2019-09-19 14:30user897Note Added: 0087304
2019-09-19 14:57gitNote Added: 0087308
2019-09-19 15:27osaAssigned Toosa => bugmaster
2019-09-19 15:27osaStatusresolved => reviewed
2019-09-19 18:48bugmasterTest case number => Not required
2019-09-20 07:53bugmasterNote Added: 0087339
2019-09-20 07:53bugmasterStatusreviewed => tested
2019-09-21 18:13bugmasterChangeset attached => occt master c42ef165
2019-09-21 18:13bugmasterStatustested => verified
2019-09-21 18:13bugmasterResolutionopen => fixed
2019-09-22 11:40gitNote Added: 0087408
2019-09-22 11:40gitNote Added: 0087409
2019-09-29 12:36gitNote Added: 0087612
2019-09-29 12:36gitNote Added: 0087613

Notes
(0087142)
git   
2019-09-16 15:52   
Branch CR30180 has been created by mzernova.

SHA-1: 47fe9c77baa022d5f44f94e76fe369f9a25d3f99


Detailed log of new commits:

Author: mzernova
Date: Mon Sep 16 13:44:02 2019 +0300

    0030180: Data Exchange - VrmlAPI_Writer is expected to return export state
    
    The VrmlAPI_Writer::WriteDoc() and VrmlAPI_Writer::Write() methods now return the export state.
(0087143)
user897   
2019-09-16 15:54   
The patch CR30180 is ready to review
(0087157)
osa   
2019-09-16 16:59   
+ if (outfile.fail())
+ {
+ return Standard_False;
+ }

Check stream to be opened also (aStream.is_open()).
(0087207)
git   
2019-09-17 17:00   
Branch CR30180 has been updated by mzernova.

SHA-1: 5020f61bd8a1c25f739e72679a1881ddf2c3f128


Detailed log of new commits:

Author: mzernova
Date: Tue Sep 17 16:57:02 2019 +0300

    #remarks from osa

(0087208)
git   
2019-09-17 17:03   
Branch CR30180_1 has been created by mzernova.

SHA-1: c09a44330c69a4f0df14ec4b94c6696e60ee8536


Detailed log of new commits:

Author: mzernova
Date: Mon Sep 16 13:44:02 2019 +0300

    0030180: Data Exchange - VrmlAPI_Writer is expected to return export state
    
    The VrmlAPI_Writer::WriteDoc() and VrmlAPI_Writer::Write() methods now return the export state.
(0087209)
user897   
2019-09-17 17:05   
The patch CR30180 is ready to review
(0087252)
osa   
2019-09-18 14:13   
http://vm-jenkins-test-12.nnov.opencascade.com:8080/view/CR30180_1-master-osa [^]
(0087303)
git   
2019-09-19 14:26   
Branch CR30180_2 has been created by mzernova.

SHA-1: 54fbc88dfdc362aa44e5ff5395187917ca77b9e1


Detailed log of new commits:

Author: mzernova
Date: Mon Sep 16 13:44:02 2019 +0300

    0030180: Data Exchange - VrmlAPI_Writer is expected to return export state
    
    The VrmlAPI_Writer::WriteDoc() and VrmlAPI_Writer::Write() methods now return the export state.
(0087304)
user897   
2019-09-19 14:30   
Please review the branch CR30180_2
(0087308)
git   
2019-09-19 14:57   
Branch CR30180_3 has been created by mzernova.

SHA-1: 9efb15a597eb1430da58d17a6247c6247934c427


Detailed log of new commits:

Author: mzernova
Date: Mon Sep 16 13:44:02 2019 +0300

    0030180: Data Exchange - VrmlAPI_Writer is expected to return export state
    
    The VrmlAPI_Writer::WriteDoc() and VrmlAPI_Writer::Write() methods now return the export state.
(0087339)
bugmaster   
2019-09-20 07:53   
Combination -
OCCT branch : WEEK-38
master SHA - 3561f506c83b672cc3e06b77029aafca8d91d5d9
5f5b1aed1c6e139bbd34314eca77ae7abcd8895c
Products branch : WEEK-38 SHA - 408582119deba96d291df52766ca720a3059ce71
was compiled on Linux, MacOS and Windows platforms and tested in optimize mode.

Number of compiler warnings:
No new/fixed warnings

Regressions/Differences/Improvements:
No regressions/differences

CPU differences:
Debian80-64:
OCCT
Total CPU difference: 16813.57000000016 / 16822.810000000067 [-0.05%]
Products
Total CPU difference: 10542.720000000027 / 10555.120000000048 [-0.12%]
Windows-64-VC14:
OCCT
Total CPU difference: 18271.390625 / 18222.765625 [+0.27%]
Products
Total CPU difference: 12493.84375 / 12438.984375 [+0.44%]


Image differences :
No differences that require special attention

Memory differences :
No differences that require special attention
(0087408)
git   
2019-09-22 11:40   
Branch CR30180 has been deleted by inv.

SHA-1: 5020f61bd8a1c25f739e72679a1881ddf2c3f128
(0087409)
git   
2019-09-22 11:40   
Branch CR30180_1 has been deleted by inv.

SHA-1: c09a44330c69a4f0df14ec4b94c6696e60ee8536
(0087612)
git   
2019-09-29 12:36   
Branch CR30180_2 has been deleted by inv.

SHA-1: 54fbc88dfdc362aa44e5ff5395187917ca77b9e1
(0087613)
git   
2019-09-29 12:36   
Branch CR30180_3 has been deleted by inv.

SHA-1: 9efb15a597eb1430da58d17a6247c6247934c427