MantisBT - Open CASCADE
View Issue Details
0030100Open CASCADE[OCCT] OCCT:Modeling Algorithmspublic2018-08-31 09:262018-09-09 13:08
emv 
bugmaster 
normalminor 
closedfixed 
[OCCT] 7.3.0 
[OCCT] 7.4.0[OCCT] 7.4.0 
bugs/modalg_7/bug30100_1, bugs/modalg_7/bug30100_2
0030100: Modeling Algorithms - ShapeUpgrade_UnifySameDomain is unable to unify faces based on the same toroidal surface
ShapeUpgrade_UnifySameDomain is unable to unify faces based on the same toroidal surface. It happens because the UnifySameDomain algorithm uses IntAna_QuadQuadGeo for comparing elementary surfaces (expecting the tangency flag), which returns IntAna_NoGeometricSolution.

The problem has been discovered while working on the issue 0030094.
restore [locate_data_file bug30100_usd.brep] f
unifysamedom result f
checkshape result
checknbshapes result -wire 1 -face 1

restore [locate_data_file bug30100_faces.brep] f
explode f
bopcurves f_1 f_2
No tags attached.
related to 0030094closed bugmaster Modeling Algorithms - Defeaturing does not work on the attached shape due to incorrect extension of the torus 
Issue History
2018-08-31 09:26emvNew Issue
2018-08-31 09:26emvAssigned To => msv
2018-08-31 09:52emvAssigned Tomsv => emv
2018-08-31 09:52emvStatusnew => assigned
2018-08-31 09:52emvSteps to Reproduce Updatedbug_revision_view_page.php?rev_id=19833#r19833
2018-08-31 10:00emvSteps to Reproduce Updatedbug_revision_view_page.php?rev_id=19836#r19836
2018-08-31 10:09gitNote Added: 0078873
2018-09-03 09:23emvRelationship addedrelated to 0030094
2018-09-03 14:46emvNote Added: 0078934
2018-09-03 14:46emvAssigned Toemv => msv
2018-09-03 14:46emvStatusassigned => resolved
2018-09-03 15:29msvNote Added: 0078940
2018-09-03 15:29msvAssigned Tomsv => emv
2018-09-03 15:29msvStatusresolved => assigned
2018-09-03 15:32gitNote Added: 0078942
2018-09-04 07:35emvNote Added: 0078957
2018-09-04 07:35emvAssigned Toemv => msv
2018-09-04 07:35emvStatusassigned => resolved
2018-09-04 09:25msvNote Added: 0078964
2018-09-04 09:25msvAssigned Tomsv => bugmaster
2018-09-04 09:25msvStatusresolved => reviewed
2018-09-04 15:24bugmasterTest case number => testsbugs/modalg_7/bug30100_1, bugs/modalg_7/bug30100_2
2018-09-04 15:24bugmasterTest case numbertestsbugs/modalg_7/bug30100_1, bugs/modalg_7/bug30100_2 => bugs/modalg_7/bug30100_1, bugs/modalg_7/bug30100_2
2018-09-04 15:28bugmasterNote Added: 0078988
2018-09-04 15:28bugmasterStatusreviewed => tested
2018-09-09 11:52bugmasterChangeset attached => occt master 83f7dbeb
2018-09-09 11:52bugmasterStatustested => verified
2018-09-09 11:52bugmasterResolutionopen => fixed
2018-09-09 12:21gitNote Added: 0079043

Notes
(0078873)
git   
2018-08-31 10:09   
Branch CR30100 has been created by emv.

SHA-1: 0cc996063fb9805776ba82c9b3a1a2233e0d6ca4


Detailed log of new commits:

Author: emv
Date: Fri Aug 31 10:07:05 2018 +0300

    0030100: Modeling Algorithms - ShapeUpgrade_UnifySameDomain is unable to unify faces based on the same toroidal surface
    
    When performing intersection of toroidal faces check first if they are based on the same surface.
    Test cases for the issue.
(0078934)
emv   
2018-09-03 14:46   
Dear Mikhail, could you please review the git branch CR30100?

Test results - http://jenkins-test-12.nnov.opencascade.com/view/CR30100-CR30100-emv/view/COMPARE/ [^]
(0078940)
msv   
2018-09-03 15:29   
src/IntPatch/IntPatch_Intersection.cxx
- Use TolTang to compare radii in order to make correspondence with IntAna algorithm.
(0078942)
git   
2018-09-03 15:32   
Branch CR30100 has been updated by emv.

SHA-1: eb805d4301666bcda5a0307f98afdd9b262cf2a9


Detailed log of new commits:

Author: emv
Date: Mon Sep 3 15:29:18 2018 +0300

    # Corrections according to remarks.

(0078957)
emv   
2018-09-04 07:35   
Please review again. Test results - http://vm-jenkins-test-12.nnov.opencascade.com:8080/view/CR30094-master-emv/view/COMPARE/. [^]
(0078964)
msv   
2018-09-04 09:25   
Reviewed.
(0078988)
bugmaster   
2018-09-04 15:28   
OCCT branch : CR30094 SHA - 4967999df25d25df578eef2cce56d7f655600459
Products branch : CR30100 SHA - 172af4d33029ab85a56ad72ea43f606b8d32245b
was compiled on Linux, MacOS and Windows platforms and tested in optimize mode.

Number of compiler warnings:
No new/fixed warnings

Regressions/Differences/Improvements:
No regressions/differences

CPU differences:
Debian80-64:
OCCT
Total CPU difference: 17570.309999999838 / 17510.19999999974 [+0.34%]
Products
Total CPU difference: 7473.800000000058 / 7448.370000000074 [+0.34%]
Windows-64-VC14:
OCCT
Total CPU difference: 17478.18043889853 / 17490.31731669841 [-0.07%]
Products
Total CPU difference: 8335.32063119999 / 8296.913184999985 [+0.46%]


Image differences :
No differences that require special attention

Memory differences :
No differences that require special attention
(0079043)
git   
2018-09-09 12:21   
Branch CR30100 has been deleted by inv.

SHA-1: eb805d4301666bcda5a0307f98afdd9b262cf2a9