MantisBT - Open CASCADE
View Issue Details
0029958Open CASCADE[OCCT] OCCT:Visualizationpublic2018-07-13 23:122018-07-28 12:38
kgv 
bugmaster 
normalfeature 
verifiedfixed 
 
[OCCT] 7.4.0* 
Not needed
0029958: Visualization - add method Graphic3d_ArrayOfPrimitives::AddEdges() taking up to 4 edges
Current interface of Graphic3d_ArrayOfPrimitives requires each index being added independently by ::AddEdge() call.

However, in case of most used collections Graphic3d_ArrayOfTriangles and Graphic3d_ArrayOfSegments it would be more natural having a method taking 3 (triangle) or 2 (segment) edges.
N/A
No tags attached.
Issue History
2018-07-13 23:12kgvNew Issue
2018-07-13 23:12kgvAssigned To => kgv
2018-07-13 23:14gitNote Added: 0077595
2018-07-13 23:15kgvNote Added: 0077596
2018-07-13 23:15kgvAssigned Tokgv => san
2018-07-13 23:15kgvStatusnew => resolved
2018-07-14 12:41gitNote Added: 0077598
2018-07-14 14:01gitNote Added: 0077628
2018-07-20 20:17gitNote Added: 0077863
2018-07-20 20:18sanNote Added: 0077864
2018-07-20 20:18sanAssigned Tosan => bugmaster
2018-07-20 20:18sanStatusresolved => reviewed
2018-07-23 17:17bugmasterTest case number => Not needed
2018-07-23 17:18bugmasterNote Added: 0077934
2018-07-23 17:18bugmasterStatusreviewed => tested
2018-07-28 12:26bugmasterChangeset attached => occt master fb60181a
2018-07-28 12:26bugmasterStatustested => verified
2018-07-28 12:26bugmasterResolutionopen => fixed
2018-07-28 12:38gitNote Added: 0078140

Notes
(0077595)
git   
2018-07-13 23:14   
Branch CR29958 has been created by kgv.

SHA-1: f36557f8b505d36a30eed20fbdbd68fef1db42b2


Detailed log of new commits:

Author: kgv
Date: Fri Jul 13 23:12:26 2018 +0300

    0029958: Visualization - add method Graphic3d_ArrayOfPrimitives::AddEdges() taking up to 4 edges
(0077596)
kgv   
2018-07-13 23:15   
Patch is ready for review.
(0077598)
git   
2018-07-14 12:41   
Branch CR29958 has been deleted by inv.

SHA-1: f36557f8b505d36a30eed20fbdbd68fef1db42b2
(0077628)
git   
2018-07-14 14:01   
Branch CR29958 has been created by inv.

SHA-1: c54280b74cff18ab396d214e0eb31962f5cb4be2


Detailed log of new commits:

Author: bugmaster
Date: Sat Jul 14 13:59:22 2018 +0300

    0029958: Visualization - add method Graphic3d_ArrayOfPrimitives::AddEdges() taking up to 4 edges
(0077863)
git   
2018-07-20 20:17   
Branch CR29958 has been updated forcibly by san.

SHA-1: 8e3bd3daf0102e3c5e436a678ee122f126ca5ff3
(0077864)
san   
2018-07-20 20:18   
Branch CR29958 reviewed without remarks
(0077934)
bugmaster   
2018-07-23 17:18   
Combination -
OCCT branch : CR29958 SHA - c54280b74cff18ab396d214e0eb31962f5cb4be2
Products branch : master SHA - edc03a9d94e87d0141f8dbfdc1c42f755e9765d9
was compiled on Linux, MacOS and Windows platforms and tested in optimize mode.

Number of compiler warnings:
No new/fixed warnings

Regressions/Differences/Improvements:
No regressions/differences

CPU differences:
Debian70-64:
OCCT
Total CPU difference: 17245.84000000005 / 17080.800000000007 [+0.97%]
Products
Total CPU difference: 7481.57000000003 / 7461.820000000036 [+0.26%]
Windows-64-VC10:
OCCT
Total CPU difference: 17068.209810898687 / 16984.608874998572 [+0.49%]
Products
Total CPU difference: 8188.196088099889 / 8248.209672799876 [-0.73%]


Image differences :
No differences that require special attention

Memory differences :
No differences that require special attention
(0078140)
git   
2018-07-28 12:38   
Branch CR29958 has been deleted by inv.

SHA-1: 8e3bd3daf0102e3c5e436a678ee122f126ca5ff3