MantisBT - Open CASCADE
View Issue Details
0029939Open CASCADE[OCCT] OCCT:Modeling Algorithmspublic2018-07-09 10:112018-10-20 13:23
kgv 
bugmaster 
normalminor 
verifiedfixed 
[OCCT] 6.3.1 
[OCCT] 7.4.0* 
bugs/modalg_7/bug29939
0029939: Modeling Algorithms - add NULL check to BRepGProp_Face::Load()
It is desired to protect BRepGProp_Face::Load() against possible NULL dereference (see 0029926)
pload MODELING VISUALIZATION
restore [locate_data bug29926.brep] f
vinit View1
vdisplay -dispMode 1 f
vfit
sprops f
vprops f

No tags attached.
related to 0030269verified apn Modeling Algorithms - unhandled Standard_NullObject within BRepBndLib::Add() 
child of 0029926assigned ifv Modeling Algorithms - NULL dereference within GProp_GProps on Edge without 2D Curve 
Issue History
2018-07-09 10:11kgvNew Issue
2018-07-09 10:11kgvAssigned To => msv
2018-07-09 10:12kgvRelationship addedchild of 0029926
2018-07-09 12:27gitNote Added: 0077389
2018-07-09 13:49kgvNote Added: 0077392
2018-07-09 13:49kgvAssigned Tomsv => bugmaster
2018-07-09 13:49kgvStatusnew => resolved
2018-07-10 13:10msvNote Added: 0077416
2018-07-10 13:10msvAssigned Tobugmaster => kgv
2018-07-10 13:10msvStatusresolved => assigned
2018-07-10 17:28gitNote Added: 0077428
2018-07-10 17:33gitNote Added: 0077429
2018-07-10 17:43gitNote Added: 0077430
2018-07-10 19:35kgvNote Added: 0077433
2018-07-10 19:35kgvAssigned Tokgv => msv
2018-07-10 19:35kgvStatusassigned => resolved
2018-07-10 19:35kgvNote Edited: 0077433bug_revision_view_page.php?bugnote_id=77433#r19473
2018-07-10 21:19gitNote Added: 0077436
2018-07-10 21:20msvNote Added: 0077437
2018-07-10 21:21msvNote Added: 0077438
2018-07-10 21:21msvAssigned Tomsv => bugmaster
2018-07-10 21:21msvStatusresolved => reviewed
2018-07-11 15:35bugmasterNote Added: 0077453
2018-07-11 15:35bugmasterStatusreviewed => tested
2018-07-11 15:36bugmasterTest case number => bugs/modalg_7/bug29939
2018-07-14 12:26bugmasterChangeset attached => occt master 8ff2e494
2018-07-14 12:26bugmasterStatustested => verified
2018-07-14 12:26bugmasterResolutionopen => fixed
2018-07-14 12:41gitNote Added: 0077611
2018-07-14 12:41gitNote Added: 0077613
2018-10-20 13:23kgvRelationship addedrelated to 0030269

Notes
(0077389)
git   
2018-07-09 12:27   
Branch CR29939 has been created by kgv.

SHA-1: 20275ee9ec1c12293faef00de9d4e291b7eaf34a


Detailed log of new commits:

Author: kgv
Date: Wed Jul 4 12:09:50 2018 +0300

    0029939: Modeling Algorithms - add NULL check to BRepGProp_Face::Load()
(0077392)
kgv   
2018-07-09 13:49   
Patch is ready for review.

http://jenkins-test-11.nnov.opencascade.com/view/CR29939-master-KGV [^]
(0077416)
msv   
2018-07-10 13:10   
src/BRepGProp/BRepGProp_Gauss.hxx
- 83, 103: these methods do not return bool.

src/BRepGProp/BRepGProp_Gauss.cxx
- 628: in this place there is still present risk of exception.

The methods of the upper level API (LinearProperties, SurfaceProperties, VolumeProperties of BRepGProp) do not utilize the new return value. So, in the view of this fix, change of API of all methods looks unnecessary.

tests/bugs/modalg_7/bug29939
- there is no need in creation of snapshot for this test.
(0077428)
git   
2018-07-10 17:28   
Branch CR29939 has been updated by kgv.

SHA-1: efc848a7ead11db1d3d18f3ecc440246458eb714


Detailed log of new commits:

Author: kgv
Date: Tue Jul 10 17:27:29 2018 +0300

    # remarks

(0077429)
git   
2018-07-10 17:33   
Branch CR29939_1 has been created by kgv.

SHA-1: e25e5e8f40f7579a4135d7af5ab2b7f3811fb876


Detailed log of new commits:

Author: kgv
Date: Wed Jul 4 12:09:50 2018 +0300

    0029939: Modeling Algorithms - add NULL check to BRepGProp_Face::Load()
(0077430)
git   
2018-07-10 17:43   
Branch CR29939_1 has been updated forcibly by kgv.

SHA-1: 225b4b20601dac30b1f3143fef4088525c3de33d
(0077433)
kgv   
2018-07-10 19:35   
Updated patch is ready for review.

http://jenkins-test-11.nnov.opencascade.com/view/CR29939_1-master-KGV/ [^]

(0077436)
git   
2018-07-10 21:19   
Branch CR29939_1 has been updated forcibly by msv.

SHA-1: 0adc6842d965068b8af10c284fbdd5edfedf7fb6
(0077437)
msv   
2018-07-10 21:20   
Commit message has been completed.
(0077438)
msv   
2018-07-10 21:21   
Reviewed.
(0077453)
bugmaster   
2018-07-11 15:35   
Combination -
OCCT branch : CR29939_1 SHA - 225b4b20601dac30b1f3143fef4088525c3de33d
Products branch : master SHA - 49c228d5213fed6561994d0148827917539e38c8
was compiled on Linux, MacOS and Windows platforms and tested in optimize mode.

Number of compiler warnings:
No new/fixed warnings

Regressions/Differences/Improvements:
No regressions/differences

CPU differences:
Debian70-64:
OCCT
Total CPU difference: 17289.279999999846 / 17169.739999999776 [+0.70%]
Products
Total CPU difference: 7529.330000000048 / 7501.920000000043 [+0.37%]
Windows-64-VC10:
OCCT
Total CPU difference: 16935.46855999858 / 16852.39802749857 [+0.49%]
Products
Total CPU difference: 8237.757605799887 / 8212.11104139987 [+0.31%]


Image differences :
No differences that require special attention

Memory differences :
No differences that require special attention
(0077611)
git   
2018-07-14 12:41   
Branch CR29939_1 has been deleted by inv.

SHA-1: 0adc6842d965068b8af10c284fbdd5edfedf7fb6
(0077613)
git   
2018-07-14 12:41   
Branch CR29939 has been deleted by inv.

SHA-1: efc848a7ead11db1d3d18f3ecc440246458eb714