MantisBT - Open CASCADE
View Issue Details
0029837Open CASCADE[OCCT] OCCT:Visualizationpublic2018-06-04 16:202019-08-11 10:50
ski 
bugmaster 
normalminor 
verifiedfixed 
[OCCT] 6.8.0 
[OCCT] 7.4.0 
bugs/vis/bug29837
0029837: Visualization, Graphic3d_Camera - Fit All operation works incorrectly on flat object
Fit All operation works not correct with attached shape after using of vviewparams operations.
pload VISUALIZATION
brestore shape.brep s
vclear
vinit View1
vtop
vdisplay s
vpoint p0 0 0 0
vfit
# OK
vremove p0
vfit
# KO nothing is displayed


pload ALL
vinit

brestore C:/shape.brep s
vdisplay s

vviewparams -up 1 0 0
vviewparams -proj 0 0 1
vfit
No tags attached.
related to 0025063closed bugmaster Open CASCADE Visualization - 2D objects are not displayed at some camera positions 
has duplicate 0029985new kgv Community Visualization - Wrong result of V3d_View::FitAll() for a straight line segment 
related to 0029388verified bugmaster Open CASCADE Visualization - Setting camera eye position to (0,0,0) kills the application 
related to 0029191verified kgv Open CASCADE Visualization - viewer rotations are not smooth 
related to 0028033new  Open CASCADE Visualization - Graphic3d_Camera::ZFitAll() throws exception on camera rotation 
? shape.brep (22,400) 2018-06-04 16:20
https://tracker.dev.opencascade.org/
? flat.brep (42,886) 2019-06-21 09:25
https://tracker.dev.opencascade.org/
Issue History
2018-06-04 16:20skiNew Issue
2018-06-04 16:20skiAssigned To => kgv
2018-06-04 16:20skiFile Added: shape.brep
2018-06-04 16:30kgvSteps to Reproduce Updatedbug_revision_view_page.php?rev_id=19219#r19219
2018-06-04 16:30kgvSteps to Reproduce Updatedbug_revision_view_page.php?rev_id=19220#r19220
2018-06-04 16:37kgvRelationship addedduplicate of 0026154
2018-06-04 16:38kgvSteps to Reproduce Updatedbug_revision_view_page.php?rev_id=19221#r19221
2018-06-04 16:41kgvProduct Version => 6.8.0
2018-06-04 16:41kgvSteps to Reproduce Updatedbug_revision_view_page.php?rev_id=19222#r19222
2018-06-14 17:51kgvRelationship addedrelated to 0029388
2018-07-25 11:47kgvRelationship addedhas duplicate 0029985
2019-06-21 09:24amlNote Added: 0085187
2019-06-21 09:25amlFile Added: flat.brep
2019-06-24 18:43kgvAssigned Tokgv => tizmaylo
2019-06-24 18:43kgvStatusnew => assigned
2019-06-25 19:52tizmayloRelationship addedrelated to 0025063
2019-06-25 20:03gitNote Added: 0085305
2019-06-26 10:29tizmayloNote Added: 0085311
2019-06-26 10:29tizmayloAssigned Totizmaylo => kgv
2019-06-26 10:29tizmayloStatusassigned => resolved
2019-06-27 11:31kgvRelationship addedrelated to 0024393
2019-06-27 11:34kgvNote Added: 0085318
2019-06-27 11:34kgvAssigned Tokgv => tizmaylo
2019-06-27 11:34kgvStatusresolved => assigned
2019-07-29 02:54kgvSummaryVisualization, TKOpenGl - Fit All operation works not correct => Visualization - Fit All operation works not correct
2019-07-29 03:04kgvSummaryVisualization - Fit All operation works not correct => Visualization - Fit All operation works incorrectly on flat object
2019-07-29 03:05kgvSummaryVisualization - Fit All operation works incorrectly on flat object => Visualization, Graphic3d_Camera - Fit All operation works incorrectly on flat object
2019-07-29 03:23gitNote Added: 0085921
2019-07-29 03:36gitNote Added: 0085922
2019-07-29 17:16gitNote Added: 0085939
2019-07-29 19:44kgvNote Added: 0085942
2019-07-29 19:44kgvAssigned Totizmaylo => san
2019-07-29 19:44kgvStatusassigned => resolved
2019-07-29 20:19gitNote Added: 0085943
2019-07-29 21:11kgvRelationship addedrelated to 0029191
2019-07-29 22:13kgvRelationship deleted0026154
2019-07-30 18:38sanNote Added: 0085953
2019-07-30 18:38sanAssigned Tosan => bugmaster
2019-07-30 18:38sanStatusresolved => reviewed
2019-07-30 19:27kgvRelationship addedrelated to 0028033
2019-07-31 14:00bugmasterTest case number => bugs/vis/bug29837_segment_2049
2019-07-31 14:01bugmasterTest case numberbugs/vis/bug29837_segment_2049 => bugs/vis/bug29837
2019-07-31 14:20bugmasterNote Added: 0085957
2019-07-31 14:20bugmasterStatusreviewed => tested
2019-07-31 15:15kgvRelationship addedrelated to 0030482
2019-08-11 10:40bugmasterChangeset attached => occt master 607e5e62
2019-08-11 10:40bugmasterStatustested => verified
2019-08-11 10:40bugmasterResolutionopen => fixed
2019-08-11 10:50gitNote Added: 0086151
2019-08-11 10:50gitNote Added: 0086154

Notes
(0085187)
aml   
2019-06-21 09:24   
One more test case:

restore d:/flat.brep a
vinit
vright
vviewparams -proj 1 0 0 -up 0.0 0.99754686591938924 -0.070001787794343212
vdisplay a
vfit
(0085305)
git   
2019-06-25 20:03   
Branch CR29837 has been created by tizmaylo.

SHA-1: 7c6d89d8c12c73ab4ac0c5e9655381aae0e7eb8f


Detailed log of new commits:

Author: tiv
Date: Tue Jun 25 19:46:26 2019 +0300

    0029837: Visualization, TKOpenGl - Fit All operation works not correct
    
    Minimal distance from camera eye to camera center is calculated now relatively to the distance from origin to camera center (to prevent problems with floating-point precision).
(0085311)
tizmaylo   
2019-06-26 10:29   
Patch is ready for review: http://jenkins-test-12.nnov.opencascade.com:8080/view/CR29837-master-TIV/view/ALL/ [^]
(0085318)
kgv   
2019-06-27 11:34   
The patch might downgrade camera manipulations with enhanced precision (when camera eye is moved to ZLayer origin) - to be checked/corrected.
(0085921)
git   
2019-07-29 03:23   
Branch CR29837_1 has been created by kgv.

SHA-1: 35647155f18558fb31848766cc23b6799f52185f


Detailed log of new commits:

Author: kgv
Date: Mon Jul 29 03:21:28 2019 +0300

    0029837: Visualization, Graphic3d_Camera - Fit All operation works incorrectly on flat object
    
    Graphic3d_Camera has been revised to store camera Direction from Eye explicitly
    and Distance to Center instead of auxiliary Center point.
    
    This allows setting camera Distance to 0 (for flat objects) without side effects
    like broken FitAll, wobbling on rotating.
(0085922)
git   
2019-07-29 03:36   
Branch CR29837_1 has been updated forcibly by kgv.

SHA-1: 86a48c9527c6a4168dbf48edae2a0a1759e7c01f
(0085939)
git   
2019-07-29 17:16   
Branch CR29837_1 has been updated forcibly by kgv.

SHA-1: 28d311e00cd19082fbfa633cc403234b38a8dbb8
(0085942)
kgv   
2019-07-29 19:44   
Patch is ready for review.

http://jenkins-test-12.nnov.opencascade.com:8080/view/CR29837_1-master-KGV [^]
(0085943)
git   
2019-07-29 20:19   
Branch CR29837_1 has been updated forcibly by kgv.

SHA-1: 380b2e6c88b42762d97aef809c4d188e4ed76ad4
(0085953)
san   
2019-07-30 18:38   
Branch CR29837_1 reviewed without remarks
(0085957)
bugmaster   
2019-07-31 14:20   
Combination -
OCCT branch : CR29837_1
master SHA - 28d311e00cd19082fbfa633cc403234b38a8dbb8
5f5b1aed1c6e139bbd34314eca77ae7abcd8895c
Products branch : master SHA - 53815c0544dd1e39d32ee14979d7d88e78729edc
was compiled on Linux, MacOS and Windows platforms and tested in optimize mode.

Number of compiler warnings:
No new/fixed warnings

Regressions/Differences/Improvements:
No regressions/differences

CPU differences:
Debian80-64:
OCCT
Total CPU difference: 16231.019999999995 / 16237.229999999976 [-0.04%]
Products
Total CPU difference: 10466.89000000005 / 10493.010000000033 [-0.25%]
Windows-64-VC14:
OCCT
Total CPU difference: 17644.21875 / 17592.765625 [+0.29%]
Products
Total CPU difference: 12081.203125 / 12065.453125 [+0.13%]


Image differences :
No differences that require special attention

Memory differences :
No differences that require special attention
(0086151)
git   
2019-08-11 10:50   
Branch CR29837_1 has been deleted by inv.

SHA-1: 380b2e6c88b42762d97aef809c4d188e4ed76ad4
(0086154)
git   
2019-08-11 10:50   
Branch CR29837 has been deleted by inv.

SHA-1: 7c6d89d8c12c73ab4ac0c5e9655381aae0e7eb8f