MantisBT - Open CASCADE
View Issue Details
0029750Open CASCADE[OCCT] OCCT:Samplespublic2018-05-10 10:192020-12-26 14:52
nds 
bugmaster 
normalminor 
verifiedfixed 
[OCCT] 7.5.0 
[OCCT] 7.6.0* 
Not required
0029750: Samples - function arrows are not updated by moving a node in FuncDemo qt sample
FuncDemo compiled with Qt 5.10.1 has not updated links as shown on attached picture.
Natasha, could you review please?

The tests passed well: http://vm-jenkins-test-12.nnov.opencascade.com:8080/view/CR29750_1-master-vro/view/COMPARE/ [^]

For bugmaster:
a sample Qt/FuncDemo in the branch CR29750_1.
No tags attached.
png FuncDemo_Sh_node_moved.png (84,691) 2018-05-10 10:19
https://tracker.dev.opencascade.org/
Issue History
2018-05-10 10:19ndsNew Issue
2018-05-10 10:19ndsAssigned To => vro
2018-05-10 10:19ndsFile Added: FuncDemo_Sh_node_moved.png
2018-07-05 10:06abvCategoryOCCT:Samples => OCCT:Inspectors
2019-09-04 15:36abvTarget Version7.4.0 => 7.5.0
2020-10-26 11:14ndsCategoryOCCT:Inspectors => OCCT:Samples
2020-10-26 11:14ndsSummarySamples - Inspector tool - function arrows are not updated by moving a node in FuncDemo qt sample => Samples - function arrows are not updated by moving a node in FuncDemo qt sample
2020-10-26 11:17vroTarget Version7.5.0 => 7.6.0*
2020-11-23 11:41gitNote Added: 0097005
2020-11-23 11:44kgvProduct Version => 7.5.0
2020-11-25 10:42gitNote Added: 0097055
2020-11-25 14:06vroAssigned Tovro => nds
2020-11-25 14:06vroStatusnew => resolved
2020-11-25 14:06vroSteps to Reproduce Updatedbug_revision_view_page.php?rev_id=24068#r24068
2020-11-26 12:15kgvNote Added: 0097092
2020-12-16 10:37ndsNote Added: 0097624
2020-12-16 10:37ndsAssigned Tonds => vro
2020-12-16 10:37ndsStatusresolved => assigned
2020-12-17 08:45vroNote Added: 0097652
2020-12-17 11:24ndsNote Added: 0097662
2020-12-17 11:24ndsAssigned Tovro => kgv
2020-12-17 11:24ndsStatusassigned => resolved
2020-12-17 11:29kgvNote Added: 0097664
2020-12-17 11:29kgvAssigned Tokgv => nds
2020-12-17 11:38ndsNote Added: 0097665
2020-12-17 11:38ndsAssigned Tonds => vro
2020-12-17 11:38ndsStatusresolved => reviewed
2020-12-17 11:43kgvNote Added: 0097666
2020-12-17 13:17gitNote Added: 0097673
2020-12-17 20:06vroNote Added: 0097695
2020-12-17 20:06vroAssigned Tovro => bugmaster
2020-12-17 20:06vroStatusreviewed => feedback
2020-12-25 15:07vroStatusfeedback => resolved
2020-12-25 16:57bugmasterStatusresolved => reviewed
2020-12-26 12:16bugmasterNote Added: 0097919
2020-12-26 12:16bugmasterStatusreviewed => tested
2020-12-26 12:22bugmasterTest case number => Not required
2020-12-26 14:40bugmasterChangeset attached => occt master 894133a5
2020-12-26 14:40bugmasterStatustested => verified
2020-12-26 14:40bugmasterResolutionopen => fixed
2020-12-26 14:52gitNote Added: 0097924
2020-12-26 14:52gitNote Added: 0097925
2020-12-26 14:52gitNote Added: 0097926

Notes
(0097005)
git   
2020-11-23 11:41   
Branch CR29750 has been created by vro.

SHA-1: 973ef894cd390f2c75262b67bcbb1ab287475ca0


Detailed log of new commits:

Author: Vlad Romashko
Date: Mon Nov 23 11:41:59 2020 +0300

    0029750: Samples - function arrows are not updated by moving a node in FuncDemo qt sample
    
    The visual links between functions are recovers.
    The demo is synchronized with a corresponding demo from Qt (qt486-vc10-32\examples\graphicsview\elasticnodes). It may be successfully compiled by any further versions of Qt including 5.10.1
(0097055)
git   
2020-11-25 10:42   
Branch CR29750_1 has been created by vro.

SHA-1: 943d7f611c785a04979079908fb781620b14e178


Detailed log of new commits:

Author: Vlad Romashko
Date: Wed Nov 25 10:42:20 2020 +0300

    0029750: Samples - function arrows are not updated by moving a node in FuncDemo qt sample
    
    The visual links between functions are recovers.
    The demo is synchronized with a corresponding demo from Qt (qt486-vc10-32\examples\graphicsview\elasticnodes). It may be successfully compiled by any further versions of Qt including 5.10.1
    Also, because Open CASCADE (and OCAF in particular) is improved for usage in multi-threading mode, usage of mutexes is added in this sample (for access to the sharing TNaming_UsedShapes attribute, for example).
(0097092)
kgv   
2020-11-26 12:15   
Vlad,

+//! [0]

what is the purpose for these new confusing comment blocks?
Could them be replaced by simple description?
(0097624)
nds   
2020-12-16 10:37   
Dear Vlad,
could you please correct Kirill's remark.
(0097652)
vro   
2020-12-17 08:45   
Hello Kirill, hello Natasha! These comments come from Qt's sample. All headers in the sample are kept as in Qt sample and all the code, except several lines dedicated to Function Demo.
I suppose the questionable comment comes from a tutorial in Qt. Should we remove these lines? Indeed, we don't need them, but if we remove them, we will introduce more difference to the Qt's sample.
I have no own opinion... If you think it worth removing the lines, I will do it. Just let me know please.
(0097662)
nds   
2020-12-17 11:24   
Kirill, please check.

It looks reasonable.
(0097664)
kgv   
2020-12-17 11:29   
OK.
(0097665)
nds   
2020-12-17 11:38   
Dear Vlad,

It's Ok, please cherry pick it on the current master and relaunch tests.
Please give details for Igor which branch is.

Best regards, Natalia
(0097666)
kgv   
2020-12-17 11:43   
Vlad, could you please also correct git commit author to match common style using acronyms?
(0097673)
git   
2020-12-17 13:17   
Branch CR29750_2 has been created by vro.

SHA-1: 953c28fb10494dd095b997258bc5199bf6ec42ef


Detailed log of new commits:

Author: vro
Date: Thu Dec 17 13:17:46 2020 +0300

    0029750: Samples - function arrows are not updated by moving a node in FuncDemo qt sample
    
    The visual links between functions are recovered.
    The demo is synchronized with a corresponding demo from Qt (qt486-vc10-32\examples\graphicsview\elasticnodes). It may be successfully compiled by any further versions of Qt including 5.10.1
    Also, because Open CASCADE (and OCAF in particular) is improved for usage in multi-threading mode, usage of mutexes is added in this sample (for access to the sharing TNaming_UsedShapes attribute, for example).
(0097695)
vro   
2020-12-17 20:06   
Updated to current master.
(0097919)
bugmaster   
2020-12-26 12:16   
Combination -
OCCT branch : WEEK-52
master SHA - 41046145c4a15f5cedf5f3c5877952ee00d568b4
a206de37fbfa0bf71bd534ae47192bbec23b8522
Products branch : WEEK-52 SHA - 290e5c74e8fef71947cadf90acb8e43c81ed10a1
was compiled on Linux, MacOS and Windows platforms and tested in optimize mode.

Number of compiler warnings:
No new/fixed warnings

Regressions/Differences/Improvements:
No regressions/differences

CPU differences:
Debian80-64:
OCCT
Total CPU difference: 17722.770000000193 / 17710.950000000055 [+0.07%]
Products
Total CPU difference: 12416.490000000109 / 12412.520000000126 [+0.03%]
Windows-64-VC14:
OCCT
Total CPU difference: 19321.5625 / 19274.6875 [+0.24%]
Products
Total CPU difference: 13844.421875 / 13853.046875 [-0.06%]


Image differences :
No differences that require special attention

Memory differences :
No differences that require special attention
(0097924)
git   
2020-12-26 14:52   
Branch CR29750 has been deleted by inv.

SHA-1: 973ef894cd390f2c75262b67bcbb1ab287475ca0
(0097925)
git   
2020-12-26 14:52   
Branch CR29750_1 has been deleted by inv.

SHA-1: 943d7f611c785a04979079908fb781620b14e178
(0097926)
git   
2020-12-26 14:52   
Branch CR29750_2 has been deleted by inv.

SHA-1: 953c28fb10494dd095b997258bc5199bf6ec42ef