MantisBT - Open CASCADE
View Issue Details
0029743Open CASCADE[OCCT] OCCT:Inspectorspublic2018-05-08 14:412018-07-05 10:06
nds 
abv 
normalminor 
closedfixed 
 
[OCCT] 7.3.0[OCCT] 7.3.0 
Not needed
0029743: Samples - Inspector tool - crash by selecting TNaming_UsedShapes tree item
After opening attached file in inspector and selection of TNaming_UsedShapes attribute, the tool is crashed.
tests/tools/dfbrowser/A7
No tags attached.
related to 0029733closed abv TInspector can't open several cbf files 
? bug29743.cbf (163,277) 2018-05-08 15:14
https://tracker.dev.opencascade.org/
Issue History
2018-05-08 14:41ndsNew Issue
2018-05-08 14:41ndsAssigned To => bugmaster
2018-05-08 14:42ndsRelationship addedrelated to 0029733
2018-05-08 14:48gitNote Added: 0075880
2018-05-08 14:54gitNote Added: 0075881
2018-05-08 15:12gitNote Added: 0075883
2018-05-08 15:14ndsFile Added: bug29743.cbf
2018-05-08 15:19gitNote Added: 0075884
2018-05-08 15:21ndsNote Added: 0075885
2018-05-08 15:21ndsAssigned Tobugmaster => szy
2018-05-08 15:21ndsStatusnew => resolved
2018-05-08 15:21ndsSteps to Reproduce Updatedbug_revision_view_page.php?rev_id=19043#r19043
2018-05-08 16:40szyNote Added: 0075893
2018-05-08 16:40szyAssigned Toszy => nds
2018-05-08 16:40szyStatusresolved => assigned
2018-05-08 17:55gitNote Added: 0075895
2018-05-08 17:58ndsNote Added: 0075896
2018-05-08 17:58ndsAssigned Tonds => szy
2018-05-08 17:58ndsStatusassigned => resolved
2018-05-10 11:18ndsNote Added: 0075919
2018-05-11 12:10szyNote Added: 0075939
2018-05-11 12:10szyAssigned Toszy => bugmaster
2018-05-11 12:10szyStatusresolved => reviewed
2018-05-23 11:35bugmasterNote Added: 0076146
2018-05-23 11:35bugmasterStatusreviewed => tested
2018-05-23 11:38bugmasterTest case number => Not needed
2018-05-24 16:02abvChangeset attached => occt master 26b004e9
2018-05-24 16:02abvAssigned Tobugmaster => abv
2018-05-24 16:02abvStatustested => verified
2018-05-24 16:02abvResolutionopen => fixed
2018-05-24 18:13gitNote Added: 0076281
2018-05-24 18:13gitNote Added: 0076282
2018-05-24 18:13gitNote Added: 0076283
2018-06-29 21:13aivFixed in Version => 7.3.0
2018-06-29 21:19aivStatusverified => closed
2018-07-05 10:06abvCategoryOCCT:Samples => OCCT:Inspectors

Notes
(0075880)
git   
2018-05-08 14:48   
Branch CR29743 has been created by nds.

SHA-1: ff4dca2ef55449eb900b01bfc18a22125d77300f


No new revisions were added by this update.
(0075881)
git   
2018-05-08 14:54   
Branch CR29743 has been updated by nds.

SHA-1: 3585c78e07c1d74af2547ee4ea259c3cba2300b9


Detailed log of new commits:

Author: nds
Date: Tue May 8 14:54:18 2018 +0300

    0029743: Samples - Inspector tool - crash by selecting TNaming_UsedShapes tree item
    
    - TNaming_UsedShapes is corrected to do not call methods of empty TopoDS_Shape
    - DFBrowserPane presentation tree item for this is corrected in the same way and obsolete methods of processing SortedReferences are removed.

(0075883)
git   
2018-05-08 15:12   
Branch CR29743 has been updated by nds.

SHA-1: 0c504ee5cd656a2f809267c1a8a6ccd55b028075


Detailed log of new commits:

Author: nds
Date: Tue May 8 15:12:45 2018 +0300

    # test case

(0075884)
git   
2018-05-08 15:19   
Branch CR29743_1 has been created by nds.

SHA-1: f553e187b384b91fae74ca92c23cebd4ef0aa95f


Detailed log of new commits:

Author: nds
Date: Tue May 8 15:19:28 2018 +0300

    0029743: Samples - Inspector tool - crash by selecting TNaming_UsedShapes tree item
    
    - TNaming_UsedShapes is corrected to do not call methods of empty TopoDS_Shape
    - DFBrowserPane presentation tree item for this is corrected in the same way and obsolete methods of processing SortedReferences are removed.
(0075885)
nds   
2018-05-08 15:21   
Please, review modifications
(0075893)
szy   
2018-05-08 16:40   
The line
anOS << "Empty Shape" << endl;
gives nothing. I suggest like this:
TCollection_AsciiString entry =...; // put entry of the label with null shape
anOS << "Empty Shape at label = " << entry.ToCString() <<endl;
(0075895)
git   
2018-05-08 17:55   
Branch CR29743_2 has been created by nds.

SHA-1: 32a023aa1f32e2bc0090568f14bba3d442f741d0


Detailed log of new commits:

Author: nds
Date: Tue May 8 17:55:09 2018 +0300

    0029743: Samples - Inspector tool - crash by selecting TNaming_UsedShapes tree item
    
    - TNaming_UsedShapes is corrected to do not call methods of empty TopoDS_Shape
    - TNaming_NamedShape is corrected to have not NULL TNaming_RefShape even if TopoDS_Shape is NULL(TNaming_Builder::Delete).
    - DFBrowserPane presentation tree item for this is corrected in the same way and obsolete methods of processing SortedReferences are removed.
(0075896)
nds   
2018-05-08 17:58   
Could you please, review modifications once again.
(0075919)
nds   
2018-05-10 11:18   
Jenkins for Branch CR29743_2 is in:
http://jenkins-test-11.nnov.opencascade.com:8080/view/CR29743_1-master-NDS/ [^]
(0075939)
szy   
2018-05-11 12:10   
Reviewed.
(0076146)
bugmaster   
2018-05-23 11:35   
Combination -
OCCT branch : CR29743_2 SHA - 32a023aa1f32e2bc0090568f14bba3d442f741d0
Products branch : master SHA - 300cf879a836fb8a5c4636713070ca9cf544749f
was compiled on Linux, MacOS and Windows platforms and tested in optimize mode.

Number of compiler warnings:
No new/fixed warnings

Regressions/Differences/Improvements:
No regressions/differences

CPU differences:
Debian70-64:
OCCT
Total CPU difference: 18246.29000000006 / 18243.73999999987 [+0.01%]
Products
Total CPU difference: 0 / 0
Windows-64-VC10:
OCCT
Total CPU difference: 18071.358641298586 / 18049.78370299853 [+0.12%]
Products
Total CPU difference: 7683.610853599943 / 7697.713343999945 [-0.18%]


Image differences :
No differences that require special attention

Memory differences :
No differences that require special attention
(0076281)
git   
2018-05-24 18:13   
Branch CR29743 has been deleted by kgv.

SHA-1: 0c504ee5cd656a2f809267c1a8a6ccd55b028075
(0076282)
git   
2018-05-24 18:13   
Branch CR29743_1 has been deleted by kgv.

SHA-1: f553e187b384b91fae74ca92c23cebd4ef0aa95f
(0076283)
git   
2018-05-24 18:13   
Branch CR29743_2 has been deleted by kgv.

SHA-1: 32a023aa1f32e2bc0090568f14bba3d442f741d0