MantisBT - Open CASCADE
View Issue Details
0029729Open CASCADE[OCCT] OCCT:Visualizationpublic2018-04-26 16:062019-02-14 12:05
kgv 
bugmaster 
normalfeature 
closedfixed 
 
[OCCT] 7.4.0[OCCT] 7.4.0 
v3d glsl clipping1
0029729: Visualization, Graphic3d_ClipPlane - add support of clipping plane chains
It is desired to support Box and 3/4 section clipping planes configuration, which currently cannot be defined using existing API.
No tags attached.
related to 0029768closed abv Open CASCADE Visualization, TKOpenGl - structure is entirely clipped by suppressed clipping 
parent of 0029975closed bugmaster Open CASCADE Visualization - Graphic3d_ClipPlane::ProbeBox() returns Out for fully In box 
parent of 0030081closed bugmaster Open CASCADE Visualization - selection does not work when two clipping planes cut object from opposite sides 
child of 0027748new kgv Open CASCADE Visualization - clipping and capping improvements 
png occt_clip_chain3.png (38,387) 2018-05-03 20:34
https://tracker.dev.opencascade.org/
png occt_clip_chain6.png (39,570) 2018-05-03 20:34
https://tracker.dev.opencascade.org/
Issue History
2018-04-26 16:06kgvNew Issue
2018-04-26 16:06kgvAssigned To => kgv
2018-04-26 16:06kgvRelationship addedchild of 0027748
2018-04-27 20:52kgvSummaryVisualization - add support of Box clipping => Visualization, Graphic3d_ClipPlane - add support of clipping plane chains
2018-04-27 20:53gitNote Added: 0075735
2018-04-28 14:57gitNote Added: 0075743
2018-04-28 17:04gitNote Added: 0075747
2018-04-28 18:00gitNote Added: 0075749
2018-05-03 18:22gitNote Added: 0075791
2018-05-03 20:18gitNote Added: 0075792
2018-05-03 20:34kgvFile Added: occt_clip_chain3.png
2018-05-03 20:34kgvFile Added: occt_clip_chain6.png
2018-05-03 20:36gitNote Added: 0075793
2018-05-03 20:44gitNote Added: 0075794
2018-05-03 20:49gitNote Added: 0075795
2018-05-03 22:39gitNote Added: 0075797
2018-05-04 00:19gitNote Added: 0075798
2018-05-04 00:27kgvNote Added: 0075799
2018-05-04 00:27kgvAssigned Tokgv => san
2018-05-04 00:27kgvStatusnew => resolved
2018-05-04 09:28gitNote Added: 0075803
2018-05-04 16:10kgvNote Edited: 0075799bug_revision_view_page.php?bugnote_id=75799#r19029
2018-05-10 19:31sanNote Added: 0075931
2018-05-10 19:31sanAssigned Tosan => bugmaster
2018-05-10 19:31sanStatusresolved => reviewed
2018-05-14 19:24kgvRelationship addedrelated to 0029768
2018-05-15 12:05kgvRelationship addedrelated to 0029772
2018-05-23 11:55bugmasterNote Added: 0076149
2018-05-23 11:55bugmasterStatusreviewed => tested
2018-05-23 11:57bugmasterTest case number => v3d glsl clipping1
2018-05-25 10:15gitNote Added: 0076312
2018-06-14 18:20bugmasterChangeset attached => occt master 25c35042
2018-06-14 18:20bugmasterStatustested => verified
2018-06-14 18:20bugmasterResolutionopen => fixed
2018-06-23 13:56gitNote Added: 0076936
2018-06-23 13:56gitNote Added: 0076937
2018-06-23 13:56gitNote Added: 0076938
2018-06-23 13:56gitNote Added: 0076939
2018-07-20 10:29kgvRelationship addedparent of 0029975
2018-08-23 16:44kgvRelationship addedparent of 0030081
2018-09-21 12:31kgvRelationship addedrelated to 0030152
2018-10-01 07:29kgvRelationship addedrelated to 0028383
2019-02-14 12:05bugmasterProjectInternal => Open CASCADE

Notes
(0075735)
git   
2018-04-27 20:53   
Branch CR29729 has been created by kgv.

SHA-1: 1ae6523ea253a5204fc50eeb34de6241b485863e


Detailed log of new commits:

Author: kgv
Date: Fri Apr 27 20:53:50 2018 +0300

    0029729: Visualization, Graphic3d_ClipPlane - add support of clipping plane chains
    
    Graphic3d_ClipPlane now can define a Chain of Planes (union operation).
    OpenGl_ShaderManager - added new GLSL sub-programs for clipping plane chains.
(0075743)
git   
2018-04-28 14:57   
Branch CR29729 has been updated forcibly by kgv.

SHA-1: 65b5809634af8c5217226738c5dbe8a9ff5a229c
(0075747)
git   
2018-04-28 17:04   
Branch CR29729_1 has been created by kgv.

SHA-1: ffb9ef697eaeefba08aa1ae86f81376ebe2daf17


Detailed log of new commits:

Author: kgv
Date: Sat Apr 28 17:04:05 2018 +0300

    OpenGl_Clipping::SetEnabled() - handle sub-planes separately
(0075749)
git   
2018-04-28 18:00   
Branch CR29729 has been updated by kgv.

SHA-1: 64972d25311b2e3af2dac8cb2b38c6916d2c71d0


Detailed log of new commits:

Author: kgv
Date: Sat Apr 28 17:59:56 2018 +0300

    OpenGl_CappingAlgo - draw sub-planes

(0075791)
git   
2018-05-03 18:22   
Branch CR29729 has been updated by kgv.

SHA-1: 669107898fc917daf3f3bdb11b12954bc27eecb6


Detailed log of new commits:

Author: kgv
Date: Thu May 3 18:22:34 2018 +0300

    Graphic3d_SequenceOfHClipPlane now aggregates NCollection_Sequence instead of inheritance.
    
    # fix capping

(0075792)
git   
2018-05-03 20:18   
Branch CR29729 has been updated by kgv.

SHA-1: fb2222c5b93305bf8348a2954992bdf0d89779b4


Detailed log of new commits:

Author: kgv
Date: Thu May 3 20:18:32 2018 +0300

    # code clean up

(0075793)
git   
2018-05-03 20:36   
Branch CR29729 has been updated by kgv.

SHA-1: ff0a40cb949303c8234ae4f7d9914ef2945f5a3c


Detailed log of new commits:

Author: kgv
Date: Thu May 3 20:36:28 2018 +0300

    # add test case

(0075794)
git   
2018-05-03 20:44   
Branch CR29729 has been updated by kgv.

SHA-1: edb3debd23236d3e080b4253252fe88c74b4b3d8


Detailed log of new commits:

Author: kgv
Date: Thu May 3 20:43:55 2018 +0300

    # fix passing undefined values on out limits

(0075795)
git   
2018-05-03 20:49   
Branch CR29729_2 has been created by kgv.

SHA-1: e69e87974400b51198eb1a58f3c078e10c802d1c


Detailed log of new commits:

Author: kgv
Date: Fri Apr 27 20:53:50 2018 +0300

    0029729: Visualization, Graphic3d_ClipPlane - add support of clipping plane chains
    
    Graphic3d_ClipPlane now can define a Chain of Planes (logical AND).
    OpenGl_ShaderManager - added new GLSL sub-programs for clipping plane chains.
    Bnd_Range::TrimFrom(), ::TrimTo() - added auxiliary methods for trimming the range.
    SelectMgr_ViewClipRange now handles non-continuous clipping range.
    Graphic3d_SequenceOfHClipPlane now aggregates NCollection_Sequence instead of inheritance.
(0075797)
git   
2018-05-03 22:39   
Branch CR29729_2 has been updated forcibly by kgv.

SHA-1: f9cc250529bd207aa5ac8a6bcd2e3525d37b3d78
(0075798)
git   
2018-05-04 00:19   
Branch CR29729_2 has been updated forcibly by kgv.

SHA-1: 9c13208ea676c0c57864204437b5abfeba16d6fb
(0075799)
kgv   
2018-05-04 00:27   
(edited on: 2018-05-04 16:10)
Patch is ready for review.

http://jenkins-test-11.nnov.opencascade.com/view/CR29729_2-CR29729_2-KGV/ [^]

(0075803)
git   
2018-05-04 09:28   
Branch CR29729_2 has been updated forcibly by kgv.

SHA-1: 1a085744cd0bfa4a62856df6b8ecb161b30fed5b
(0075931)
san   
2018-05-10 19:31   
Branch CR29729_2 in OCCT and OCC Products repositories reviewed without remarks.
(0076149)
bugmaster   
2018-05-23 11:55   
Combination -
OCCT branch : CR29729_2 SHA - 1a085744cd0bfa4a62856df6b8ecb161b30fed5b
Products branch : CR29729_2 SHA - 06be21f8171645013a6096615e5697867dd47827
was compiled on Linux, MacOS and Windows platforms and tested in optimize mode.

Number of compiler warnings:
No new/fixed warnings

Regressions/Differences/Improvements:
No regressions/differences

CPU differences:
Debian70-64:
OCCT
Total CPU difference: 18252.960000000003 / 18243.73999999987 [+0.05%]
Products
Total CPU difference: 7525.340000000048 / 7505.500000000054 [+0.26%]
Windows-64-VC10:
OCCT
Total CPU difference: 18062.513384598577 / 18049.78370299853 [+0.07%]
Products
Total CPU difference: 7696.465335999918 / 7697.713343999945 [-0.02%]


Image differences :
No differences that require special attention

Memory differences :
No differences that require special attention
(0076312)
git   
2018-05-25 10:15   
Branch CR29729_3 has been created by kgv.

SHA-1: d8274ed5b992ff63e910a76fa793b80b178a4e36


Detailed log of new commits:

Author: kgv
Date: Fri May 25 10:13:38 2018 +0300

    0029729: Visualization, Graphic3d_ClipPlane - add support of clipping plane chains
    
    Graphic3d_ClipPlane now can define a Chain of Planes (logical AND).
    OpenGl_ShaderManager - added new GLSL sub-programs for clipping plane chains.
    Bnd_Range::TrimFrom(), ::TrimTo() - added auxiliary methods for trimming the range.
    SelectMgr_ViewClipRange now handles non-continuous clipping range.
    Graphic3d_SequenceOfHClipPlane now aggregates NCollection_Sequence instead of inheritance.
    OpenGl_CappingPlaneResource - triangulation has been adjusted to make front face following CCW order.
(0076936)
git   
2018-06-23 13:56   
Branch CR29729 has been deleted by kgv.

SHA-1: edb3debd23236d3e080b4253252fe88c74b4b3d8
(0076937)
git   
2018-06-23 13:56   
Branch CR29729_1 has been deleted by kgv.

SHA-1: ffb9ef697eaeefba08aa1ae86f81376ebe2daf17
(0076938)
git   
2018-06-23 13:56   
Branch CR29729_2 has been deleted by kgv.

SHA-1: 1a085744cd0bfa4a62856df6b8ecb161b30fed5b
(0076939)
git   
2018-06-23 13:56   
Branch CR29729_3 has been deleted by kgv.

SHA-1: d8274ed5b992ff63e910a76fa793b80b178a4e36