MantisBT - Community
View Issue Details
0029717Community[OCCT] OCCT:Shape Healingpublic2018-04-23 17:032019-09-07 16:27
drazmyslovich 
bugmaster 
normalminor 
verifiedfixed 
WindowsVC++ 201064 bit
[OCCT] 7.1.0 
[OCCT] 7.4.0 
bugs heal bug25923
0029717: Shape Healing - ShapeFix_Face::FixSmallAreaWire delivers a face with wrong-oriented wires + 1 small crash-fix
If the provided face is reversed, then the algorithm starts with the empty-copied, but reversed face - this results in adding of forward-oriented wires to reverse-oriented face...

Another problem lies in ShapeFix_Face::FixOrientation function - it can cause a crash/exception if one of the curves has no 2D curve
Since the usage code is a part of my application, I can't provide any steps to reproduce. Still, the fixed issues are easily observable from the code.
No tags attached.
Issue History
2018-04-23 17:03drazmyslovichNew Issue
2018-04-23 17:03drazmyslovichAssigned To => gka
2018-04-23 17:38gitNote Added: 0075614
2018-04-23 17:39drazmyslovichNote Added: 0075615
2018-04-23 17:39drazmyslovichStatusnew => resolved
2018-04-23 17:40kgvSummaryShapeFix_Face::FixSmallAreaWire delivers a face with wrong-oriented wires + 1 small crash-fix => Shape Healing - ShapeFix_Face::FixSmallAreaWire delivers a face with wrong-oriented wires + 1 small crash-fix
2019-09-04 22:10gitNote Added: 0086756
2019-09-05 04:00abvRelationship addedrelated to 0025923
2019-09-05 04:35gitNote Added: 0086761
2019-09-05 04:37abvTest case number => bugs heal bug25923
2019-09-05 04:41abvNote Added: 0086762
2019-09-05 04:41abvAssigned Togka => bugmaster
2019-09-05 04:41abvStatusresolved => reviewed
2019-09-06 16:57bugmasterNote Added: 0086899
2019-09-06 16:57bugmasterStatusreviewed => tested
2019-09-07 11:38bugmasterChangeset attached => occt master 3f50e94e
2019-09-07 11:38bugmasterStatustested => verified
2019-09-07 11:38bugmasterResolutionopen => fixed
2019-09-07 16:26gitNote Added: 0086933
2019-09-07 16:27gitNote Added: 0086958

Notes
(0075614)
git   
2018-04-23 17:38   
Branch CR29717 has been created by drazmyslovich.

SHA-1: d4f63f269e4fc0c68d3684916471f2d3afb288f9


Detailed log of new commits:

Author: drazmyslovich
Date: Mon Apr 23 16:38:32 2018 +0200

    0029717: Fix FixSmallAreaWire for the reversed faces. Add nullptr check for FixOrientation.
(0075615)
drazmyslovich   
2018-04-23 17:39   
Dear gka. The branch is ready for review. Thank you.
(0086756)
git   
2019-09-04 22:10   
Branch CR29717_1 has been created by abv.

SHA-1: 057c17251939a9208bb828cd0fd281329e7d5dcb


Detailed log of new commits:

Author: drazmyslovich
Date: Mon Apr 23 16:38:32 2018 +0200

    0029717: Fix FixSmallAreaWire for the reversed faces. Add nullptr check for FixOrientation.
(0086761)
git   
2019-09-05 04:35   
Branch CR29717_1 has been updated by abv.

SHA-1: 32222f1385bbaed5b1ce3d8a9fd22e2d006bc436


Detailed log of new commits:

Author: abv
Date: Thu Sep 5 04:32:08 2019 +0300

    Test bugs heal bug25923 is corrected to avoid relying on wrong orientation of face after fixing small wire

(0086762)
abv   
2019-09-05 04:41   
Reviewed, please integrate. Test results are in Jenkins job CR29717-abv. Note that test bugs heal bug25923 was reported as Failed because it relied on wrong behavior (creation of incorrectly oriented wire) to check that the fix has been actually done; this test is corrected.
(0086899)
bugmaster   
2019-09-06 16:57   
Combination -
OCCT branch : WEEK-36
master SHA - 39ac47df8cd6df3a58e95e460a580a0bbcf04e26
5f5b1aed1c6e139bbd34314eca77ae7abcd8895c
Products branch : WEEK-36 SHA - d0069f6ae5aec77b9487ab84664fb1572c4e95fe
was compiled on Linux, MacOS and Windows platforms and tested in optimize mode.

Number of compiler warnings:
No new/fixed warnings

Regressions/Differences/Improvements:
No regressions/differences

CPU differences:
Debian80-64:
OCCT
Total CPU difference: 16175.440000000028 / 16167.270000000033 [+0.05%]
Products
Total CPU difference: 10467.530000000015 / 10475.630000000048 [-0.08%]
Windows-64-VC14:
OCCT
Total CPU difference: 18251.171875 / 18256.515625 [-0.03%]
Products
Total CPU difference: 10129.234375 / 12158.609375 [-16.69%]


Image differences :
No differences that require special attention

Memory differences :
No differences that require special attention
(0086933)
git   
2019-09-07 16:26   
Branch CR29717_1 has been deleted by inv.

SHA-1: 32222f1385bbaed5b1ce3d8a9fd22e2d006bc436
(0086958)
git   
2019-09-07 16:27   
Branch CR29717 has been deleted by inv.

SHA-1: d4f63f269e4fc0c68d3684916471f2d3afb288f9