MantisBT - Open CASCADE
View Issue Details
0029691Open CASCADE[OCCT] OCCT:Modeling Algorithmspublic2018-04-12 11:042018-06-23 13:56
nbv 
bugmaster 
normalminor 
closedfixed 
 
[OCCT] 7.4.0[OCCT] 7.4.0 
Not needed
0029691: Constructor of BRepFill_MultiLine adjusts V-parameter of sphere in the range -PI/2 ... +PI/2 mistakenly.
See IR-2018-04-10, BRepFill_MultiLine.cxx, line 230.

1. Sphere is not V-periodic surface. See the section "Periodicity concept" written in frame of the fix 0029115. Therefore, applying ElCLib::AdjustPeriodic(...) method is a foolish.

2. Default U work range of sphere is 0 ... 2*PI. Therefore, adjusting U parameter in range -PI/2 ... +PI/2 is a foolish.
Not required
See the message 0029115:0075138, item 8.
No tags attached.
Issue History
2018-04-12 11:04nbvNew Issue
2018-04-12 11:04nbvAssigned To => msv
2018-04-12 11:11gitNote Added: 0075401
2018-04-12 11:12nbvAdditional Information Updatedbug_revision_view_page.php?rev_id=18932#r18932
2018-04-12 13:23gitNote Added: 0075415
2018-04-12 13:25nbvNote Added: 0075416
2018-04-12 13:31nbvStatusnew => resolved
2018-04-12 13:31nbvSteps to Reproduce Updatedbug_revision_view_page.php?rev_id=18934#r18934
2018-04-17 13:05gitNote Added: 0075473
2018-04-17 13:07msvNote Added: 0075474
2018-04-17 13:07msvAssigned Tomsv => bugmaster
2018-04-17 13:07msvStatusresolved => reviewed
2018-05-23 17:06bugmasterNote Added: 0076190
2018-05-23 17:06bugmasterStatusreviewed => tested
2018-05-23 17:10bugmasterNote Added: 0076192
2018-05-24 14:39bugmasterTest case number => Not needed
2018-06-14 18:20bugmasterChangeset attached => occt master ef33df51
2018-06-14 18:20bugmasterStatustested => verified
2018-06-14 18:20bugmasterResolutionopen => fixed
2018-06-23 13:56gitNote Added: 0076916
2018-06-23 13:56gitNote Added: 0076917

Notes
(0075401)
git   
2018-04-12 11:11   
Branch CR29691 has been created by nbv.

SHA-1: 8924bd092586601b767f8fd3b0cd556addfadea9


Detailed log of new commits:

Author: nbv
Date: Thu Apr 12 11:10:22 2018 +0300

    0029691: Constructor of BRepFill_MultiLine adjusts V-parameter of sphere in the range -PI/2 ... +PI/2 mistakenly.
    
    Stupid code has been deleted.
(0075415)
git   
2018-04-12 13:23   
Branch CR29691_1 has been created by nbv.

SHA-1: 7719e870f7152ad66d2500b124528a1529f47c97


Detailed log of new commits:

Author: nbv
Date: Thu Apr 12 11:10:22 2018 +0300

    0029691: Constructor of BRepFill_MultiLine adjusts V-parameter of sphere in the range -PI/2 ... +PI/2 mistakenly.
    
    1. Sphere is not V-periodic surface. See the section "Periodicity concept" written in frame of the fix 0029115. Therefore, applying ElCLib::AdjustPeriodic(...) method is a foolish.
    
    2. Default U work range of sphere is 0 ... 2*PI. Therefore, adjusting U parameter in range -PI/2 ... +PI/2 is a foolish.
(0075416)
nbv   
2018-04-12 13:25   
Dear Mikhail,

The branch CR29691_1 is ready for review.

Test results are here: http://jenkins-test-11.nnov.opencascade.com/view/CR29691-master_NBV/ [^]

Please pay attention to the fact that the branch CR29691 has been tested (instead of CR29691_1). However, these branches differ the comiit message only. I.e. they are equivalent.
(0075473)
git   
2018-04-17 13:05   
Branch CR29691_1 has been updated forcibly by nbv.

SHA-1: 8594d539298713af9b4950c884a5721b4d4d5a7e
(0075474)
msv   
2018-04-17 13:07   
Reviewed.
(0076190)
bugmaster   
2018-05-23 17:06   
Combination -
OCCT branch : CR29691 SHA - 8924bd092586601b767f8fd3b0cd556addfadea9
Products branch : master SHA - 8471189e8649026d76950924f8ec2b4878cba528
was compiled on Linux, MacOS and Windows platforms and tested in optimize mode.

Number of compiler warnings:
No new/fixed warnings

Regressions/Differences/Improvements:
No regressions/differences

CPU differences:
Debian70-64:
OCCT
Total CPU difference: 17998.599999999842 / 18092.32999999989 [-0.52%]
Products
Total CPU difference: 7490.810000000032 / 7480.610000000005 [+0.14%]
Windows-64-VC10:
OCCT
Total CPU difference: 17912.5184230984 / 17813.754189998494 [+0.55%]
Products
Total CPU difference: 8215.839465299863 / 8149.242638399972 [+0.82%]


Image differences :
No differences that require special attention

Memory differences :
No differences that require special attention
(0076192)
bugmaster   
2018-05-23 17:10   
NBV recommended to integrate CR29691_1 with more right wording of commits
(0076916)
git   
2018-06-23 13:56   
Branch CR29691 has been deleted by kgv.

SHA-1: 8924bd092586601b767f8fd3b0cd556addfadea9
(0076917)
git   
2018-06-23 13:56   
Branch CR29691_1 has been deleted by kgv.

SHA-1: 8594d539298713af9b4950c884a5721b4d4d5a7e