MantisBT - Open CASCADE
View Issue Details
0029642Open CASCADE[OCCT] OCCT:Foundation Classespublic2018-03-24 20:502020-11-21 13:30
abv 
bugmaster 
normalminor 
verifiedfixed 
[OCCT] 7.0.0 
[OCCT] 7.6.0* 
Not required
0029642: Foundation Classes - deprecate TCollection classes except strings
TCollection package was used to define generic CDL collections, which are now out of use (replaced by templated versions from NCollection package). It is a time to define all that stuff deprecated (and remove it in the next version).
No tags attached.
related to 0030165closed bugmaster Foundation Classes, TColStd_PackedMapOfInteger - provide flag for pre-allocating map of fixed size 
parent of 0031943verified bugmaster Foundation Classes, TColStd_PackedMapOfInteger - get rid of TCollection_BasicMap 
related to 0031636verified bugmaster Codig Rules, OMFAlgo - replace TCollection templates with NCollection 
Issue History
2018-03-24 20:50abvNew Issue
2018-03-24 20:50abvAssigned To => abv
2019-09-04 15:36abvTarget Version7.4.0 => 7.5.0
2020-09-11 16:13utverdovTarget Version7.5.0 => 7.6.0*
2020-11-16 22:05abvRelationship addedrelated to 0031636
2020-11-16 22:07abvNote Added: 0096801
2020-11-16 22:16kgvRelationship addedrelated to 0030165
2020-11-16 22:30kgvRelationship addedparent of 0031943
2020-11-17 09:44kgvSummaryDeprecate TCollection classes except strings => Foundation Classes - deprecate TCollection classes except strings
2020-11-17 09:45gitNote Added: 0096813
2020-11-17 10:00gitNote Added: 0096816
2020-11-17 10:00gitNote Added: 0096817
2020-11-17 19:13kgvNote Added: 0096844
2020-11-17 19:13kgvAssigned Toabv => osa
2020-11-17 19:13kgvStatusnew => resolved
2020-11-17 19:15gitNote Added: 0096845
2020-11-18 10:08gitNote Added: 0096863
2020-11-18 10:28osaNote Added: 0096865
2020-11-18 10:28osaAssigned Toosa => bugmaster
2020-11-18 10:28osaStatusresolved => reviewed
2020-11-18 10:49gitNote Added: 0096866
2020-11-21 12:39bugmasterChangeset attached => occt master 81ff4915
2020-11-21 12:39bugmasterStatusreviewed => verified
2020-11-21 12:39bugmasterResolutionopen => fixed
2020-11-21 12:42bugmasterNote Added: 0096929
2020-11-21 12:45bugmasterTest case number => Not required
2020-11-21 13:27gitNote Added: 0096947

Notes
(0096801)
abv   
2020-11-16 22:07   
Note that TColStd_PackedMapOfInteger is still using TCollection_BasicMap, it should be redirected to NCollection to remove TCollection_BasicMap
(0096813)
git   
2020-11-17 09:45   
Branch CR29642 has been created by kgv.

SHA-1: 583709dfbef0986342f225ef2c00ac86dafb87e8


Detailed log of new commits:

Author: kgv
Date: Mon Jun 29 10:35:07 2020 +0300

    0029642: Foundation Classes - deprecate TCollection classes except strings
    
    Removed remnants of generic templates in TCollection package.
(0096816)
git   
2020-11-17 10:00   
Branch CR29642 has been updated forcibly by kgv.

SHA-1: d25303111ea640c86b573258aec6116c01c9bf31
(0096817)
git   
2020-11-17 10:00   
Branch CR29642 has been updated by kgv.

SHA-1: 99828a1b90cf83bbc9f60e82b72b8f2835fd94fa


Detailed log of new commits:

Author: kgv
Date: Tue Nov 17 10:00:22 2020 +0300

    Removed TCollection_BasicMap class.

(0096844)
kgv   
2020-11-17 19:13   
Patch is ready for review
- OCCT branch: CR29642;
- Products branch: CR29642.
(0096845)
git   
2020-11-17 19:15   
Branch CR29642 has been updated forcibly by kgv.

SHA-1: b1f0fc1d529d7d93c29e1a566c930c5c57f3f0cc
(0096863)
git   
2020-11-18 10:08   
Branch CR29642 has been updated forcibly by kgv.

SHA-1: 3f9b720d49f306ff2178ae3ebc8c7539cbc9c96e
(0096865)
osa   
2020-11-18 10:28   
The patch was reviewed without remarks
(0096866)
git   
2020-11-18 10:49   
Branch CR29642 has been updated forcibly by kgv.

SHA-1: 5d1c699c7ac13fd9273a86438be60c5aa7ce7b6d
(0096929)
bugmaster   
2020-11-21 12:42   
Combination -
OCCT branch : IR-2020-11-20
master SHA - c5892d852bb462075f9db03f31085e35d7b59f35
a206de37fbfa0bf71bd534ae47192bbec23b8522
Products branch : IR-2020-11-20 SHA - a5d1f89f5fa83c955e6a604f57a5b590eb433b43
was compiled on Linux, MacOS and Windows platforms and tested in optimize mode.

Number of compiler warnings:
No new/fixed warnings

Regressions/Differences/Improvements:
No regressions/differences

CPU differences:
Debian80-64:
OCCT
Total CPU difference: 18024.090000000127 / 17964.340000000077 [+0.33%]
Products
Total CPU difference: 12166.12000000011 / 12169.520000000111 [-0.03%]
Windows-64-VC14:
OCCT
Total CPU difference: 19696.90625 / 19723.125 [-0.13%]
Products
Total CPU difference: 13644.875 / 13567.078125 [+0.57%]


Image differences :
No differences that require special attention

Memory differences :
No differences that require special attention
(0096947)
git   
2020-11-21 13:27   
Branch CR29642 has been deleted by inv.

SHA-1: 5d1c699c7ac13fd9273a86438be60c5aa7ce7b6d