MantisBT - Open CASCADE
View Issue Details
0029519Open CASCADE[OCCT] OCCT:Visualizationpublic2018-02-20 07:442018-06-29 21:21
kgv 
bugmaster 
normaltrivial 
closedfixed 
[OCCT] 6.8.0 
[OCCT] 7.3.0[OCCT] 7.3.0 
Not needed
0029519: Visualization, TKOpenGl - fallback to Graphic3d_TOSM_FACET from Gouraud/Phong when nodal normals are undefined
In previous OCCT versions, Primitive Array of triangles without normal vertex attributes have been treated implicitly as no Shading (lighting) should be done.

Introduction of explicit Shading Model within each Fill Area aspect by 0029097 makes this behavior less obvious, because it is expected now that Shading should be explicitly disabled by specifying Graphic3d_TOSM_UNLIT.

Moreover, Graphic3d_TOSM_FACET is treated specifically and ignores missing normal attributes (since normal attributes are not required for this Shading Model, and sparing vertex attributes is one of the benefit of using it).

It is proposed unifying behavior, so that Graphic3d_TOSM_VERTEX and Graphic3d_TOSM_FRAGMENT will fallback to Graphic3d_TOSM_FACET instead of Graphic3d_TOSM_UNLIT when no normal attributes are defined for triangles array. As result, user should specify explicitly Graphic3d_TOSM_UNLIT Shading Model or material without reflecting properties to preserve old behavior.
bugs vis bug26028

pload ALL
vclear
vinit View1
meshfromstl m2 [locate_data_file data/stl/bearing.stl]
meshcolors m2 elem2 0
vbottom
vfit

Bug: the back side of a mesh presentation should be RED, but it is BLUE as front side.
No tags attached.
related to 0029097closed bugmaster Visualization - allow picking Graphic3d_TypeOfShadingModel per-object 
Issue History
2018-02-20 07:44kgvNew Issue
2018-02-20 07:44kgvAssigned To => kgv
2018-02-20 07:44kgvRelationship addedrelated to 0029097
2018-02-20 07:46kgvSummaryVisualization, TKOpenGl - fallback to Graphic3d_TOSM_FACET when nodal normals are undefined => Visualization, TKOpenGl - fallback to Graphic3d_TOSM_FACET from Gouraud/Phong when nodal normals are undefined
2018-02-20 08:00gitNote Added: 0074061
2018-02-21 17:29gitNote Added: 0074092
2018-02-22 10:29kgvSeverityintegration request => trivial
2018-02-22 10:29kgvProduct Version => 6.8.0
2018-02-22 10:29kgvSteps to Reproduce Updatedbug_revision_view_page.php?rev_id=18649#r18649
2018-02-22 11:58kgvNote Added: 0074109
2018-02-22 11:58kgvAssigned Tokgv => bugmaster
2018-02-22 11:58kgvStatusnew => resolved
2018-02-22 11:59kgvStatusresolved => reviewed
2018-02-22 13:23bugmasterNote Added: 0074115
2018-02-22 13:23bugmasterStatusreviewed => tested
2018-02-22 13:23bugmasterTest case number => Not needed
2018-02-22 13:31kgvNote Added: 0074116
2018-03-04 15:34bugmasterChangeset attached => occt master db5d29de
2018-03-04 15:34bugmasterStatustested => verified
2018-03-04 15:34bugmasterResolutionopen => fixed
2018-03-06 15:50gitNote Added: 0074297
2018-06-29 21:16aivFixed in Version => 7.3.0
2018-06-29 21:21aivStatusverified => closed

Notes
(0074061)
git   
2018-02-20 08:00   
Branch CR29519 has been created by kgv.

SHA-1: 9d7d096a23ad066f9f2887c0d7ef3997f4c89967


Detailed log of new commits:

Author: kgv
Date: Tue Feb 20 08:00:01 2018 +0300

    0029519: Visualization, TKOpenGl - fallback to Graphic3d_TOSM_FACET from Gouraud/Phong when nodal normals are undefined
(0074092)
git   
2018-02-21 17:29   
Branch CR29519 has been updated forcibly by kgv.

SHA-1: 62d01cc8a8b9f511ed471c318ac40b80a3968d0c
(0074109)
kgv   
2018-02-22 11:58   
Please take the patch.

http://jenkins-test-10.nnov.opencascade.com:8080//view/CR29519-CR29519-KGV [^]
(0074115)
bugmaster   
2018-02-22 13:23   
Combination -
OCCT branch : CR29519 SHA - 62d01cc8a8b9f511ed471c318ac40b80a3968d0c
Products branch : CR29519 SHA - 14347aa3a6996e51ea01a4dbb023f668af5ac3a3
was compiled on Linux, MacOS and Windows platforms and tested in optimize mode.

Number of compiler warnings:
No new/fixed warnings

Regressions/Differences/Improvements:
No regressions/differences

CPU differences:
Debian70-64:
OCCT
Total CPU difference: 18238.949999999622 / 18347.729999999596 [-0.59%]
Products
Total CPU difference: 7469.459999999996 / 7469.6700000000055 [-0.00%]
Windows-64-VC10:
OCCT
Total CPU difference: 17694.5226256986 / 17722.010001898587 [-0.16%]
Products
Total CPU difference: 8008.919738899983 / 8043.3491595999785 [-0.43%]


Image differences :
No differences that require special attention

Memory differences :
No differences that require special attention
(0074116)
kgv   
2018-02-22 13:31   
> 2018-02-22 13:23 bugmaster Test case number => Not needed
bugs/vis/bug26028 could be specified (requires visual check).
(0074297)
git   
2018-03-06 15:50   
Branch CR29519 has been deleted by kgv.

SHA-1: 62d01cc8a8b9f511ed471c318ac40b80a3968d0c