MantisBT - Open CASCADE
View Issue Details
0029516Open CASCADE[OCCT] OCCT:Visualizationpublic2018-02-19 22:242019-09-07 16:31
kgv 
bugmaster 
normalintegration request 
verifiedfixed 
 
[OCCT] 7.4.0 
0029516: Visualization - eliminate redundant property Graphic3d_MaterialAspect::ReflectionMode()
Graphic3d_MaterialAspect::ReflectionMode() returns FALSE for disabled material components.

This functionality is redundant - the same can be done in several other ways:
- By setting material component coefficient to 0.0.
- By setting material component color to zeros.
- By setting Shading Model to unlit.

It is proposed to remove redundant property to simplify materials management.
N/A
No tags attached.
related to 0029097closed bugmaster Visualization - allow picking Graphic3d_TypeOfShadingModel per-object 
related to 0030930verified apn Draw Harness, ViewerTest - add commands vlistcolors and vlistmaterials listing standard Colors and Materials 
related to 0030700assigned iko Visualization, TKOpenGl - support PBR Metallic-Roughness shading model 
Issue History
2018-02-19 22:24kgvNew Issue
2018-02-19 22:24kgvAssigned To => kgv
2018-02-19 22:24kgvRelationship addedrelated to 0029097
2018-03-11 13:09kgvTarget Version7.3.0 => 7.4.0
2019-05-07 14:26kgvRelationship addedrelated to 0030700
2019-08-30 21:55gitNote Added: 0086560
2019-08-31 09:46gitNote Added: 0086565
2019-08-31 09:54gitNote Added: 0086567
2019-08-31 13:16gitNote Added: 0086570
2019-08-31 13:32gitNote Added: 0086572
2019-08-31 21:26gitNote Added: 0086576
2019-08-31 22:01gitNote Added: 0086577
2019-08-31 22:26gitNote Added: 0086578
2019-08-31 22:34gitNote Added: 0086579
2019-08-31 22:56gitNote Added: 0086580
2019-08-31 22:57gitNote Added: 0086581
2019-08-31 23:19gitNote Added: 0086583
2019-09-01 00:15gitNote Added: 0086585
2019-09-01 00:18gitNote Added: 0086586
2019-09-01 10:37kgvNote Added: 0086588
2019-09-01 10:37kgvAssigned Tokgv => san
2019-09-01 10:37kgvStatusnew => resolved
2019-09-01 10:38kgvRelationship addedrelated to 0030930
2019-09-02 17:28gitNote Added: 0086625
2019-09-04 12:37kgvAssigned Tosan => osa
2019-09-04 12:40osaNote Added: 0086729
2019-09-04 12:40osaAssigned Toosa => bugmaster
2019-09-04 12:40osaStatusresolved => reviewed
2019-09-04 15:14bugmasterNote Added: 0086736
2019-09-04 15:14bugmasterStatusreviewed => tested
2019-09-07 11:38bugmasterChangeset attached => occt master 61168418
2019-09-07 11:38bugmasterStatustested => verified
2019-09-07 11:38bugmasterResolutionopen => fixed
2019-09-07 16:27gitNote Added: 0086942
2019-09-07 16:27gitNote Added: 0086945

Notes
(0086560)
git   
2019-08-30 21:55   
Branch CR29516 has been created by kgv.

SHA-1: 91c5170fc187afddb633ba0c9d506dd186f172a7


Detailed log of new commits:

Author: kgv
Date: Fri Aug 30 21:52:12 2019 +0300

    0029516: Visualization - eliminate redundant property Graphic3d_MaterialAspect::ReflectionMode()
(0086565)
git   
2019-08-31 09:46   
Branch CR29516 has been updated forcibly by kgv.

SHA-1: 30b0d9d04c7fe394ffb7b24f5e7cf6a42c79cbe0
(0086567)
git   
2019-08-31 09:54   
Branch CR29516 has been updated forcibly by kgv.

SHA-1: 951534267d572de9937a3f3c110bd444f8dcde70
(0086570)
git   
2019-08-31 13:16   
Branch CR29516 has been updated forcibly by kgv.

SHA-1: e0e142e8adb5cb6165c4a7cf099fc0954f7857c6
(0086572)
git   
2019-08-31 13:32   
Branch CR29516 has been updated forcibly by kgv.

SHA-1: 3f78c59a69687e67e1d6c2199a3537faa9b3d454
(0086576)
git   
2019-08-31 21:26   
Branch CR29516 has been updated forcibly by kgv.

SHA-1: 41ded72e9f5af099f1b53055aee48b1463328172
(0086577)
git   
2019-08-31 22:01   
Branch CR29516 has been updated forcibly by kgv.

SHA-1: fe6487919f38310797aaf72543e7d6bdc39a9b46
(0086578)
git   
2019-08-31 22:26   
Branch CR29516 has been updated forcibly by kgv.

SHA-1: 09f4a33cc40cd525806af970c3fb9724bd5e6b6e
(0086579)
git   
2019-08-31 22:34   
Branch CR29516 has been updated forcibly by kgv.

SHA-1: aa37cba1613b4a2e12fd193521be73df8f4cf736
(0086580)
git   
2019-08-31 22:56   
Branch CR29516 has been updated forcibly by kgv.

SHA-1: 3988998dedb0ffbd64932fa7a9fdf538cba4e4b5
(0086581)
git   
2019-08-31 22:57   
Branch CR29516 has been updated forcibly by kgv.

SHA-1: cb93b890b6dd96657746a3c8e8b1e7ab43e463f7
(0086583)
git   
2019-08-31 23:19   
Branch CR29516 has been updated forcibly by kgv.

SHA-1: 06c6b7dba7975ec979c121e3405d2e3ba4a92fcc
(0086585)
git   
2019-09-01 00:15   
Branch CR29516_1 has been created by kgv.

SHA-1: 350b99d9c24f913fe5e9fe4cc11e7a57336962aa


Detailed log of new commits:

Author: kgv
Date: Fri Aug 30 21:52:12 2019 +0300

    0029516: Visualization - eliminate redundant property Graphic3d_MaterialAspect::ReflectionMode()
    
    Decomposition of Ambient, Diffuse, Specular and Emissive properties has been eliminated within *Graphic3d_MaterialAspect* definition,
    so that following methods of *Graphic3d_MaterialAspect* class have been removed:
    SetReflectionMode(), SetReflectionModeOn(), Ambient(), Diffuse(), Emissive(), Specular(), SetAmbient(), SetDiffuse(), SetSpecular(), SetEmissive().
    
    Graphic3d_NOM_NEON_GNC non-physical material definition has been corrected
    and define WHITE emission color coefficient instead of YELLOW.
    
    Added method Graphic3d_ClipPlane::SetCappingColor() for more straight-forward modification of Capping color in case of non-physical material.
    Prs3d_ShadingAspect::Color() has been fixed to return InteriorColor instead of material color coefficient in case of non-physical material.
(0086586)
git   
2019-09-01 00:18   
Branch CR29516_1 has been updated forcibly by kgv.

SHA-1: e550f6869977aaa0876d2c82a9ed8118087ee8da
(0086588)
kgv   
2019-09-01 10:37   
Patch is ready for review.

http://jenkins-test-12.nnov.opencascade.com:8080/view/CR29516_1-CR29516-KGV/ [^]
(0086625)
git   
2019-09-02 17:28   
Branch CR29516_1 has been updated forcibly by kgv.

SHA-1: 80bf2e1fad31635d1cd7521986b25d5b3477d7af
(0086729)
osa   
2019-09-04 12:40   
The patch was reviewed without remarks
(0086736)
bugmaster   
2019-09-04 15:14   
Combination -
OCCT branch : CR29516_1
master SHA - e550f6869977aaa0876d2c82a9ed8118087ee8da
5f5b1aed1c6e139bbd34314eca77ae7abcd8895c
Products branch : CR29516 SHA - 6990be2fe5e87b8cf6754ae407546f07b28e8419
was compiled on Linux, MacOS and Windows platforms and tested in optimize mode.

Number of compiler warnings:
No new/fixed warnings

Regressions/Differences/Improvements:
No regressions/differences

CPU differences:
Debian80-64:
OCCT
Total CPU difference: 16185.080000000082 / 16167.270000000033 [+0.11%]
Products
Total CPU difference: 10470.100000000053 / 10484.930000000048 [-0.14%]
Windows-64-VC14:
OCCT
Total CPU difference: 18310.25 / 18256.515625 [+0.29%]
Products
Total CPU difference: 12204.84375 / 12168.265625 [+0.30%]


Image differences :
No differences that require special attention

Memory differences :
No differences that require special attention
(0086942)
git   
2019-09-07 16:27   
Branch CR29516_1 has been deleted by inv.

SHA-1: 80bf2e1fad31635d1cd7521986b25d5b3477d7af
(0086945)
git   
2019-09-07 16:27   
Branch CR29516 has been deleted by inv.

SHA-1: 06c6b7dba7975ec979c121e3405d2e3ba4a92fcc