MantisBT - Open CASCADE
View Issue Details
0029492Open CASCADE[OCCT] OCCT:Codingpublic2018-02-08 11:102018-06-29 21:21
kgv 
bugmaster 
normaltrivial 
closedfixed 
[OCCT] 7.2.0 
[OCCT] 7.3.0[OCCT] 7.3.0 
Not needed
0029492: Coding Rules. NCollection_IndexedDataMap - add missing documentation to method ::Add()
Various DataMap collections within NCollection package have similar methods with different undocumented behavior:
- NCollection_IndexedDataMap::Add() adds new key if it does not exist and does not modify existing value if it was already bound.
- NCollection_DataMap::Bind() adds new key if it does not exist and overrides existing value if it was already bound.

It is proposed to document current behavior.
N/A
No tags attached.
Issue History
2018-02-08 11:10kgvNew Issue
2018-02-08 11:10kgvAssigned To => abv
2018-02-08 16:16gitNote Added: 0073886
2018-02-11 13:38kgvSeverityfeature => integration request
2018-02-11 13:38kgvCategoryOCCT:Foundation Classes => OCCT:Coding
2018-02-11 13:38kgvSummaryFoundation Classes, NCollection - add method Get() to DataMap collections analogous to operator[] in std::map => Coding Rules. NCollection_IndexedDataMap - add missing documentation to method ::Add()
2018-02-11 13:40gitNote Added: 0073922
2018-02-11 13:41kgvDescription Updatedbug_revision_view_page.php?rev_id=18598#r18598
2018-02-11 13:42kgvNote Added: 0073923
2018-02-11 13:42kgvSeverityintegration request => trivial
2018-02-11 13:42kgvStatusnew => resolved
2018-02-11 13:42kgvProduct Version => 7.2.0
2018-02-11 13:42kgvTarget Version7.4.0 => 7.3.0
2018-02-12 16:41gitNote Added: 0073937
2018-02-16 17:44abvNote Added: 0074027
2018-02-16 17:44abvAssigned Toabv => bugmaster
2018-02-16 17:44abvStatusresolved => reviewed
2018-02-16 17:44abvNote Edited: 0074027bug_revision_view_page.php?bugnote_id=74027#r18639
2018-02-19 10:48apnTest case number => Not needed
2018-02-19 10:48apnStatusreviewed => tested
2018-03-04 15:34bugmasterChangeset attached => occt master 94807a7d
2018-03-04 15:34bugmasterStatustested => verified
2018-03-04 15:34bugmasterResolutionopen => fixed
2018-03-06 15:50gitNote Added: 0074278
2018-03-06 15:50gitNote Added: 0074279
2018-06-29 21:16aivFixed in Version => 7.3.0
2018-06-29 21:21aivStatusverified => closed

Notes
(0073886)
git   
2018-02-08 16:16   
Branch CR29492 has been created by kgv.

SHA-1: 2a613da8374bc623afe30594af91d08fb050fd58


Detailed log of new commits:

Author: kgv
Date: Thu Feb 8 16:16:45 2018 +0300

    0029492: Foundation Classes, NCollection - add method Get() to DataMap collections analogous to operator[] in std::map
(0073922)
git   
2018-02-11 13:40   
Branch CR29492_1 has been created by kgv.

SHA-1: 02c415ea8b7f14b31a00ca3c59b304ef53fb81f6


Detailed log of new commits:

Author: kgv
Date: Thu Feb 8 16:16:45 2018 +0300

    0029492: Coding Rules. NCollection_IndexedDataMap - add missing documentation to method ::Add()
(0073923)
kgv   
2018-02-11 13:42   
Patch is ready for review.
(0073937)
git   
2018-02-12 16:41   
Branch CR29492_1 has been updated forcibly by kgv.

SHA-1: e6934c58ed83e411baf7f134bb67131794e38377
(0074027)
abv   
2018-02-16 17:44   
No remarks, please integrate (testing is not required -- the changes are in comments only)

(0074278)
git   
2018-03-06 15:50   
Branch CR29492 has been deleted by kgv.

SHA-1: 2a613da8374bc623afe30594af91d08fb050fd58
(0074279)
git   
2018-03-06 15:50   
Branch CR29492_1 has been deleted by kgv.

SHA-1: e6934c58ed83e411baf7f134bb67131794e38377