MantisBT - Open CASCADE
View Issue Details
0029491Open CASCADE[OCCT] OCCT:Visualizationpublic2018-02-08 09:172018-06-29 21:19
kgv 
apn 
normaltrivial 
closedfixed 
[OCCT] 6.3.1 
[OCCT] 7.3.0[OCCT] 7.3.0 
Not needed
0029491: Visualization, AIS_Shape - filter unsupported Display Modes within ::AcceptDisplayMode()
AIS_Shape does not implement ::AcceptDisplayMode() which makes this presentation accepting any Display Modes, even unsupported ones.

This issue might lead to various application bugs and unexpected behavior.
Thus, the missing method should be added.

In addition, AIS_ColoredShape::Compute() does not filter unsupported Display Modes and computes Wireframe presentation in such cases.
This is also misbehavior which should be fixed.
N/A
No tags attached.
parent of 0029882closed kgv Community Visualization - AcceptDisplayMode() should be redefined in class AIS_TexturedShape 
Issue History
2018-02-08 09:17kgvNew Issue
2018-02-08 09:17kgvAssigned To => kgv
2018-02-08 09:30gitNote Added: 0073867
2018-02-08 13:50gitNote Added: 0073878
2018-02-08 13:51kgvNote Added: 0073879
2018-02-08 13:51kgvAssigned Tokgv => san
2018-02-08 13:51kgvSeverityminor => trivial
2018-02-08 13:51kgvStatusnew => resolved
2018-02-09 09:40kgvProduct Version7.2.0 => 6.3.1
2018-02-09 09:41kgvRelationship addedrelated to 0027916
2018-02-09 14:26sanNote Added: 0073902
2018-02-09 14:26sanAssigned Tosan => bugmaster
2018-02-09 14:26sanStatusresolved => reviewed
2018-02-09 14:34apnTest case number => Not needed
2018-02-09 14:34apnNote Added: 0073903
2018-02-09 14:34apnStatusreviewed => tested
2018-02-10 17:14apnChangeset attached => occt master f8e0c6c4
2018-02-10 17:14apnAssigned Tobugmaster => apn
2018-02-10 17:14apnStatustested => verified
2018-02-10 17:14apnResolutionopen => fixed
2018-02-11 09:55gitNote Added: 0073916
2018-02-20 12:58aivTarget Version7.4.0 => 7.3.0
2018-06-19 10:26kgvRelationship addedparent of 0029882
2018-06-29 21:13aivFixed in Version => 7.3.0
2018-06-29 21:19aivStatusverified => closed

Notes
(0073867)
git   
2018-02-08 09:30   
Branch CR29491 has been created by kgv.

SHA-1: 8069d0fbbca2739c624c1891d2f01121121532f3


Detailed log of new commits:

Author: kgv
Date: Thu Feb 8 09:30:39 2018 +0300

    0029491: Visualization, AIS_Shape - filter unsupported Display Modes within ::AcceptDisplayMode()
    
    AIS_Shape::AcceptDisplayMode() now accepts only modes 0,1 and 2.
    AIS_ColoredShape::Compute() no more computes presentation for unknown display mode.
(0073878)
git   
2018-02-08 13:50   
Branch CR29491 has been updated forcibly by kgv.

SHA-1: 939b7c6e826317cfd00ecc4306c54060127bf59b
(0073879)
kgv   
2018-02-08 13:51   
Patch is ready for review.

http://jenkins-test-10.nnov.opencascade.com/view/CR29491-master-KGV [^]
(0073902)
san   
2018-02-09 14:26   
Branch CR29491 reviewed without remarks, ready for testing.
(0073903)
apn   
2018-02-09 14:34   
Combination -
OCCT branch : CR29491 SHA - 939b7c6e826317cfd00ecc4306c54060127bf59b
Products branch : master SHA - a8f3ddb817485da4a83285b039a03044dfa7f6c0
was compiled on Linux, MacOS and Windows platforms and tested in optimize mode.

Number of compiler warnings:
No new/fixed warnings

Regressions/Differences/Improvements:
No regressions/differences

CPU differences:
Debian70-64:
OCCT
Total CPU difference: 18287.079999999667 / 18606.899999999736 [-1.72%]
Products
Total CPU difference: 7491.640000000005 / 7496.730000000002 [-0.07%]
Windows-64-VC10:
OCCT
Total CPU difference: 17673.66529199852 / 17649.12633469849 [+0.14%]
Products
Total CPU difference: 8071.63214089993 / 8001.213289499973 [+0.88%]

Image differences :
No differences that require special attention

Memory differences :
No differences that require special attention
(0073916)
git   
2018-02-11 09:55   
Branch CR29491 has been deleted by kgv.

SHA-1: 939b7c6e826317cfd00ecc4306c54060127bf59b