MantisBT - Community
View Issue Details
0029419Community[OCCT] OCCT:Codingpublic2018-01-11 16:212018-06-29 21:19
Vico Liang 
apn 
normaltweak 
closedfixed 
 
[OCCT] 7.3.0[OCCT] 7.3.0 
Not needed
0029419: Make V3d_Viewer::PrivilegedPlane() return const reference rather than a temp object
The declare of of PrivilegedPlane in class V3d_Viewer as below:

gp_Ax3 PrivilegedPlane() const;

It's better to change it to:
inline const gp_Ax3& PrivilegedPlane() const {return myPrivilegedPlane;}

I have one more question, why not use gp_Ax2 as PrivilegedPlane? is it need to use left hand coordinate system?
No tags attached.
Issue History
2018-01-11 16:21Vico LiangNew Issue
2018-01-11 16:21Vico LiangAssigned To => kgv
2018-01-11 16:23Vico LiangDescription Updatedbug_revision_view_page.php?rev_id=18446#r18446
2018-01-12 10:34kgvSeverityminor => tweak
2018-01-12 10:34kgvTarget Version => 7.4.0*
2018-01-12 10:36gitNote Added: 0073373
2018-01-12 11:16kgvNote Added: 0073376
2018-01-12 11:16kgvAssigned Tokgv => bugmaster
2018-01-12 11:16kgvStatusnew => resolved
2018-01-12 11:16kgvStatusresolved => reviewed
2018-01-12 11:52apnTest case number => Not needed
2018-01-12 11:52apnNote Added: 0073384
2018-01-12 11:52apnStatusreviewed => tested
2018-01-13 15:26apnChangeset attached => occt master 67b3d2a8
2018-01-13 15:26apnAssigned Tobugmaster => apn
2018-01-13 15:26apnStatustested => verified
2018-01-13 15:26apnResolutionopen => fixed
2018-02-05 11:39gitNote Added: 0073776
2018-02-20 12:58aivTarget Version7.4.0* => 7.3.0
2018-06-29 21:15aivFixed in Version => 7.3.0
2018-06-29 21:19aivStatusverified => closed

Notes
(0073373)
git   
2018-01-12 10:36   
Branch CR29419 has been created by kgv.

SHA-1: 919f63242464c8a88698b146b1aa8173c5fc2c8e


Detailed log of new commits:

Author: kgv
Date: Fri Jan 12 10:36:18 2018 +0300

    0029419: Make V3d_Viewer::PrivilegedPlane() return const reference rather than a temp object
(0073376)
kgv   
2018-01-12 11:16   
Please take the patch.

http://jenkins-test-10.nnov.opencascade.com/view/CR29419-master-KGV/ [^]
(0073384)
apn   
2018-01-12 11:52   
Combination -
OCCT branch : CR29419 SHA - 919f63242464c8a88698b146b1aa8173c5fc2c8e
Products branch : master SHA - c667ca9e3bc920614b06911e337a09899f80aa2f
was compiled on Linux, MacOS and Windows platforms and tested in optimize mode.

Number of compiler warnings:
No new/fixed warnings
(0073776)
git   
2018-02-05 11:39   
Branch CR29419 has been deleted by kgv.

SHA-1: 919f63242464c8a88698b146b1aa8173c5fc2c8e